From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B813EE0206 for ; Wed, 11 Sep 2024 18:39:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 725FF940088; Wed, 11 Sep 2024 14:39:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D427940066; Wed, 11 Sep 2024 14:39:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59C98940088; Wed, 11 Sep 2024 14:39:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B087940066 for ; Wed, 11 Sep 2024 14:39:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E2FC841944 for ; Wed, 11 Sep 2024 18:39:07 +0000 (UTC) X-FDA: 82553319534.25.E40B478 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 1D03AC0003 for ; Wed, 11 Sep 2024 18:39:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BetaLl2V; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726079830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bBlyjsl1JUfOI2o7k6saqLEJMvFt2budXFRawXFvPas=; b=xbMgvHcjxzoDeMrn9wpNHH2C+2j6spwv/xbUtSVWU0qkHkolFjpINouuyOROHjBb5hr/1d WSVZ1bmQIjs0RhWCd9FlCVwq5kMx2JswuxKX17D7ItnwxewXnD2kxeMB5jq/orUtJtS99q EiUTuBqECLZvwJt5kmC+Ro1R17SWbcc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726079830; a=rsa-sha256; cv=none; b=OUEmxAlHsi7AIVZ5YjdGD+veUMcfACs+8HHIGuIgoih0PaZF6ww33NlYH84l8hAmr2uoE+ VF0ZVRkAeKbAiHbT+CDr3lIGHhpLDg5agr2VyeUIgau7qxK42u9/R2BmX6Cu5TBDqtFm8c x3wOtKVX4Cg7/Xkr/kK/Y87w3727Gg0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BetaLl2V; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 497A85C051A; Wed, 11 Sep 2024 18:39:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3A8BC4CEC0; Wed, 11 Sep 2024 18:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1726079944; bh=fE8k7OulKbaTRhw8YHBg8jnmWQYa0ibHRQ7QYjB63Uo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BetaLl2VlS0ZlixiXNNLpsgkji9gI5+Eu1bYAr0gIylzJ/FbyqeedaNbAEndkCnZ6 4b8tulhaGqBzfQ/iwdJjnylrhD8fNxosT/fxCOVXzs8Phz2ECpyzvzXmAJhxmBeUIk 60ykj0SuDQWjTfwl0005DRbkJ0C1+f0suOnPiQVY= Date: Wed, 11 Sep 2024 11:38:50 -0700 From: Andrew Morton To: Jens Axboe Cc: Yu Zhao , Linux-MM , Johannes Weiner , Muchun Song Subject: Re: Hugepage program taking forever to exit Message-Id: <20240911113850.95592d074cb0ce1430ec1bd3@linux-foundation.org> In-Reply-To: References: <02ffa542-ce49-4755-9d2b-29841f9973e0@kernel.dk> <9a924b36-aea7-4492-912a-a7ab4f2cbb96@kernel.dk> <20240910204202.6235f8023bff8303aa2463b7@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1D03AC0003 X-Stat-Signature: pywckqx5fgd9hojouxm6ntpnkss34r16 X-Rspam-User: X-HE-Tag: 1726079945-234404 X-HE-Meta: U2FsdGVkX1+vlC4jlwkk0UL8iJIfrisa5M3PXXTJD7IG9aK0+AbLAszqJd5XqsWjjrr+t6h3VEciDyu2U2fWPGd4bX2vPCKP0wdpmzCvyHNVL1IAQgBDifIhkHnjZi2U71svNBCSvZWmJN5NqqdtEoe8PlKkpUL1YOgCWslAFknfT8CmCuUBXSjwMkzIDJkuvPG/HT7VFiwf7AN+hDCzJuoRjqSwDGbRUtC4/Hazwk1vLujg6Y3xvxOS+SmluxnuDz5Lsgjy8TaQg0nbfmkhLrEOkXOEZqlLcI41dUwi987GK6hVDNMMoMqMpHm7dzTDgRGh7r/waU9CQaBLw9+7sjARigSdgKkjp3FmV79/VjI8NXmoVEzIP/bHehFzyBTcA642OFr+2o4EOTv/GFbCMfwaZdXb82H9RoRn2ueoRcSEWYyrXi+us5uWv+aAx5jg06z1+fXYdSarwnLSIjbOHg50hCXkcw2R0n16stmOmIgcBwWt7eZXbbDsjiZ4ulZTDLy8OZWaq/ohMdgozuovpHsnV8suI6+PSXh5WFEg4tPXUL+w1o1lOcrmef6y2IX9P1U/+s2QaebTMROUNEER8THmVntNRZpElayiGM0zeP+YkK2DtaCh4TJZAOyGU/6+EyPQ5ei5dJdjO5eHNXdqvYyalOharBxjqjsz4vZlSf3hKo60Xr7e85MGmPOyJsRwBDKVQ7lhhukRe+5K8MpBKe9PuEcX/7F9tnKjc3IBJbPeBORiPC8Nm89/hLvTXFpBWLdcDqnt9NnBx+BR3NhP9yN5R3HxVGDl6h1tav3NjkfBYgVw7smu2B0sl/VmAG8y2ecS52UoOGgZPYmuLXxAc5m2pTxlqvEoRaY3wjVd8Ugf6bvPAmyTyiHeesmCYYfV2U6Mkvw2Eim4TwbIhlQ+NTgEt7/ZQ9So8nR+MS7UlNv/CHChVNYYaTgUlVd8kuJxrx1MwrSKjpj2uZuXmiO f0tpEwU+ QSS9QlIcOscDEI9cnGNoXo61fqG/YTsewcLkbriQ0d1tfQj5Oe4OIR8hgaMgN/knlr5uUsOSfC6+iWxPK9o+L7V5ZJjhuV+LD9Cp29+sQCkGHdaVLLP/Co2vuYFjXun6BXMxbCE5dZ/rkgcc8HQvdgN7B0h5EksNfDkt2R1XIcaxtj5OaSS5RoSYqvjcY36CwkY4TVIyhtB5wG70tF/o1uROdFT1OR0r/ioX6OHGu9ZtNLFvC8jUys9F9Wy8i7ID+kFcdI10WZKjIzuk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 11 Sep 2024 07:22:17 -0600 Jens Axboe wrote: > On 9/10/24 9:42 PM, Andrew Morton wrote: > > On Tue, 10 Sep 2024 17:08:30 -0600 Jens Axboe wrote: > > > >>> Fixes are in git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-stable > >>> > >>> c2a967f6ab0e mm/hugetlb_vmemmap: don't synchronize_rcu() without HVO > >>> c0f398c3b2cf mm/hugetlb_vmemmap: batch HVO work when demoting > >>> > >>> Additional improvements from mm-stable that may or may not help your test case: > >>> > >>> e98337d11bbd mm/contig_alloc: support __GFP_COMP > >>> 463586e9ff39 mm/cma: add cma_{alloc,free}_folio() > >>> cf54f310d0d3 mm/hugetlb: use __GFP_COMP for gigantic folios > >> > >> I didn't pick patches, just pulled all of mm-stable - yep that fixes it > >> for me, no longer spending 60+% of the runtime during exit. I trust > >> these are heading to stable? > > > > None of these are tagged for -stable backporting. We can later request > > a backport without the cc:stable tag, although narrowing down the > > required patches would be good. > > These two: > > c2a967f6ab0e mm/hugetlb_vmemmap: don't synchronize_rcu() without HVO > c0f398c3b2cf mm/hugetlb_vmemmap: batch HVO work when demoting > > to cover both cases. OK thanks. Yu, could you please request a -stable backport after this hits mainline? Thanks.