From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AF8EB64DE for ; Tue, 10 Sep 2024 13:47:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2C148D0071; Tue, 10 Sep 2024 09:47:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADC528D0002; Tue, 10 Sep 2024 09:47:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A3ED8D0071; Tue, 10 Sep 2024 09:47:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7CE6A8D0002 for ; Tue, 10 Sep 2024 09:47:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 256081C38DB for ; Tue, 10 Sep 2024 13:47:51 +0000 (UTC) X-FDA: 82548956742.04.FE4466A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id 80DAF1C000E for ; Tue, 10 Sep 2024 13:47:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IEY2rbqH; spf=pass (imf18.hostedemail.com: domain of helgaas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725975965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=Wg/cH+2RcgFDN1mTjbwYncl/wcwKDf0twqiwDnUR1W0=; b=fktKK5s0+YWqrlv1ctpwC+bEbPyb7qn/L1cPfxJMSGqJxLOQqPHCgLt2M8ADows72MVVCh /QxC6sW1DiyXJsSoR7nYPwT3FiStooWlmM/ExmjWRnZh7/NCxTks0sNAVobecFM+sIFBrG shjnJemEpDa0dyDjzfRkv2/zsuAX4ic= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725975965; a=rsa-sha256; cv=none; b=k37k0KZ0T3EaS4K/hYS68yZzVAgMOAJmt3cBquSPmzOcDmNl0ypu+D9q/LlogD8wgeyOCW m0/nUUzdG72rOmR2IhGBWgSXmg0XReJ9qoJO/d5jU3WHkX5VNkVRw5gponSPkv3ptK17Gm Ry78h0sO+tYQNFPqJ4/b5C62a+M52JQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IEY2rbqH; spf=pass (imf18.hostedemail.com: domain of helgaas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id EC9DDA44828; Tue, 10 Sep 2024 13:47:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D511CC4CEC3; Tue, 10 Sep 2024 13:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725976067; bh=5BIOwvLP7xQQalA/sz2+3hW69BzQPTxbRY8bNFFdbAI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=IEY2rbqH3w3QWrZlffkEMhj/SAK8BlbPxQf4rRb1zSHKyK4xF+Srv+UDY+zHbUHzs JA0DvU5f0DbgBMr3Sb5NitOnO2l6OHERxru8WQxOi/fJE6CW+QLpPt6O5/ESc2+/r+ nEyp+8CDZog+NSU2TE5LTInkxU2EuSK5CR0ndMZpCY+3IMEwxr53HALAeZLU8Bi7l/ cUTwVYBmS/QHkMC1jDttI9VWJbTdhB+eeTr/YItiNqDBT0HATyT6n3eyy5pPwSbLn2 iHAiH4D62eBGk+h2r6ea7QlTKFYhvpIXWUtNZ+ZEIM4X00o83BFiF+6ZPyxS5I2Qe6 0pct/bThNgVEA== Date: Tue, 10 Sep 2024 08:47:45 -0500 From: Bjorn Helgaas To: Alistair Popple Cc: dan.j.williams@intel.com, linux-mm@kvack.org, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com Subject: Re: [PATCH 02/12] pci/p2pdma: Don't initialise page refcount to one Message-ID: <20240910134745.GA577955@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f8326d9d9e81f1cb893c2bd6f17878b138cf93d.1725941415.git-series.apopple@nvidia.com> X-Stat-Signature: d1kewcx56cijp8r55ur5r9gfoa6n4d1b X-Rspamd-Queue-Id: 80DAF1C000E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725976068-495805 X-HE-Meta: U2FsdGVkX1+UNu/cWJbcuBV6le6Q2xoiWHiOiBJMde4IQnJ4Cg/X4nJ3Ry+oixNBAiAjJ8dz/4oge4iO6mBN020R73d+lMT9FGtg9YvJUjvI/W+AYBTw1kc5RXi8jBJ3VK41SmrToeEkyh9Pj97ZLk4Vf75oiV5tMuxAeYjNfou3zXP6NS50uXgpJVxyid2KiFCZio8qJzibFAb5R6nLwC3CJNHwFyPJm0gQh2Al0g0gpm0zH1hkJS0kVpyhXrgWLlC5DCyr1CHZeO4Nc06BYHFH1VYOwz348w9jyEHrehcFX5kl4pL4wDRAv25s7gJkEQzcczWlB+yo36eqk2MOMEskiYRIqnk4ozhDjjFi+kYDRRLYQbzQhms01OshrKZO898zaNO0kRDWqZhgyhEbAQndTlRljuWDWdtiNREaNrDQcQCloBf2zQMlT8BhlAP7IByBQX/o55fXCJ1SAdDA7xU/tjQUKIjrPGalzaIxIMFznoT2VyVTynIluWDFZByfiwgc10+FlDGlrtnX8KriufS4jPs8vMTEaqczgDjXVMRbIQogMifvth/cwnbDK7haAzYu/idp8jpoHFp9tNieC9sxIbeczvmjYh/ElPlRZ6SZ+ks5KCcYEtl6gp8XcuL7S+boS0cLZnqGM9SmdZjWwIerq270dHx3Rc5XslNzVDoc3vZKcip5E8a0jacNSATSHvzMWYXfsSTtpBnF7GBZOJgYa6eTMbEJL8qCPwD57tPwWoEPWrJyrjNdunExnER4zqL+71EC7OAilhQsU2Jby4BmOFXp5ip8E0/KD4xGiDdzXd7P3+Ob/LY+H7BLSPhNev7ADwk6xTGzL0SIZEfM/6F6DLeqiqcKPGK49snyaU6/jRZTI0vLri2Sowv5X4GZf9RASWIN46RlBX8sWz6d5UI7zvKTMSIbK9t4Dw1HypcdxFoCMPntHP5EA5v2vP5AlWAQ6zpeupTCU6PLiN0 IOgUa8sb wGFdW4DmlRZxBuiCaiob8CoyqTHkqmwEDvc/CmC/lxF3v1v+IFXk+IyRDVfnQEd/kr83KPsgmsFgIDTi9Kz26eZOvSIpzcgMXHqlqnHSflDZ/DWuN9APH891o9hZf30qXPr5+NHhEf8Apd9xj6EdgAWOQzUpc1QzoERBxN4xmr2lBh2jNGMxshPY2jCeJ5iqP/4pVTn5SDkRjrg80VmhKCyz7/67UGI76ZadcRjwqyDpFZ6wXuUnr4I3JnX22j9Bt879fkOFY72CroL4r8k6dthJnDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In subject: PCI/P2PDMA: ... would match previous history. On Tue, Sep 10, 2024 at 02:14:27PM +1000, Alistair Popple wrote: > The reference counts for ZONE_DEVICE private pages should be > initialised by the driver when the page is actually allocated by the > driver allocator, not when they are first created. This is currently > the case for MEMORY_DEVICE_PRIVATE and MEMORY_DEVICE_COHERENT pages > but not MEMORY_DEVICE_PCI_P2PDMA pages so fix that up. > > Signed-off-by: Alistair Popple > --- > drivers/pci/p2pdma.c | 6 ++++++ > mm/memremap.c | 17 +++++++++++++---- > mm/mm_init.c | 22 ++++++++++++++++++---- > 3 files changed, 37 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index 4f47a13..210b9f4 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -129,6 +129,12 @@ static int p2pmem_alloc_mmap(struct file *filp, struct kobject *kobj, > } > > /* > + * Initialise the refcount for the freshly allocated page. As we have > + * just allocated the page no one else should be using it. > + */ > + set_page_count(virt_to_page(kaddr), 1); No doubt the subject line is true in some overall context, but it does seem to say the opposite of what happens here. Bjorn