From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8B7EDE9B8 for ; Tue, 10 Sep 2024 20:14:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 934448D00BC; Tue, 10 Sep 2024 16:13:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E09B8D0056; Tue, 10 Sep 2024 16:13:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CF508D00BC; Tue, 10 Sep 2024 16:13:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B7008D0056 for ; Tue, 10 Sep 2024 16:13:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1B351A8D5E for ; Tue, 10 Sep 2024 20:13:59 +0000 (UTC) X-FDA: 82549929798.24.A5EDF1B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 551C7C0008 for ; Tue, 10 Sep 2024 20:13:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=V3C7t2Qf; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725999209; a=rsa-sha256; cv=none; b=UmgEGPXAW25o5m5jWyzT6bYkG95G3YzsCdSTs1hdfkrkJDBWmjoybAKqfMiJt8fGl2TxjY 8cWxiuy4ybURV0DehYy+MmUo7CtmumGi6VSFxGCRcH97WcF0AfbLv28WzovXif77z53NYR T8Z/CaP9lkV9kDmo2ajcSEFbucerHRs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=V3C7t2Qf; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725999209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eUjCUsXH8OeKEhCLm3st5U/Z4WV4Fw9WjL4jb1DqTSI=; b=fueWGk1Y6aXbS9+TtuBszjinI2qTuLcDePyryFVNYWn8b+Mq3GSoBaY+4KHT6aqo5C96aU szRWogqCwJ+d+kkRPJLzV2SPE0pDeju6j9MmCVNjRtHWLXkavud9NNfiD+Rwd84YUXbEmK qp0uyHiQppLq5hWuzSabfs9mE15JF2I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D552A5C0179; Tue, 10 Sep 2024 20:13:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D34A9C4CEC3; Tue, 10 Sep 2024 20:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725999236; bh=RVb1qy8SWy2cizWVjiqhWziVC2adHgDmVd9oAe/UJGQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V3C7t2QfbdI1X8VlP1ziBglWkGBwLOR8xKbC/iV21r+u2AWwXcm0cX/zrL+GjiI6U lloGefrXqP8dr7B7cqJJV6iK4TZW/BZ1IG3Ip9wr3ogS5a5diOHjVRjSIiXLoBvhWb tqy96oiQJL+hbtPSzLKvs42mcNZ+frS28sxjCrgk= Date: Tue, 10 Sep 2024 13:13:55 -0700 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, David Hildenbrand , Ryan Roberts , "Mike Rapoport (IBM)" , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm: Drop unused set_pte_safe() Message-Id: <20240910131355.8f56f86045c745cee7a97f85@linux-foundation.org> In-Reply-To: <20240910101026.428808-1-anshuman.khandual@arm.com> References: <20240910101026.428808-1-anshuman.khandual@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 551C7C0008 X-Rspamd-Server: rspam01 X-Stat-Signature: 5jy9tm3ykiekhzkpwxjm55u4p7ra78rb X-HE-Tag: 1725999237-514269 X-HE-Meta: U2FsdGVkX1/nPxFxVla8SqO2zJYFEPYeHV6sJEVWqZpkOYPKR4QrZSbfvr/6qOKe6FSXSsXSlZNL5cxi9lRUfwCTgD9+1O+6uPSEnGB+JyIZRSM78UY4qTtaphCBbkcSiEw+rz/elE/OUcRqPy9ACLijQFlFI3TmBlopGyvfLOxZqUElGSMjC9z/Su6D0/Op01ls4V+YHsq9qUTkVz80upbGta6BvB1YdE3//Vrc8fB7pcQtgcr03291kQyX4Z7CRuiv+8sET6bOHabpxikm9Pzm2k/G15xE+UNGtvzxU9vO3ZjkDSxyTmeI6P4RMH02kFGKNqrKA7aU3tk3YKUocSCexGBtGZh6bi0eEoaIPnWTu2RvhdsxSBdfmZYIl+iY5zG0TzNcC8IetFGn3rNms2npFZWgta73/j1WDQ1ZabjCVX5ulbu9no60LB/YPpj54g2sO/d2EezEKHdNOiTJzFkpUMCkUIYVzG/FiZD4hrFpwQXyz6rIiWF5d6uEigbeJqkE4l7kobh91E0ucp5DrGBLP9eU9rqw7IdKJa59+HtaEM0lbczfj50aMgOBjKy7VLAZPGgtQe15uQFvIYLy0V2Qc4ZapBltgtRAp4l/H4uxUk2xGNGlBV20upzy6EurO7Y0Ds3WouwAvwfVa3tp9NqF0sHSqed5UWfh9OAUonlyD5P4KVaEEpm3ISWXYdYZc6TOAs7WnvqYIkVzDMgC0MXEJUHB7v1a3tFiEGP3cD6W4xYlVsmmOy2Goi4UpUKynYADTpqj22hxbJUVk2Qmuy3ieEgoY5L9eF+MewnmB2yga2ZROlr1QzjP2EsIso0J1elRLJ2p6YCxeL3Hn/yPR9c4n+migt9Sb6Mk0wlPVlwK7Qb69nd43Ztxq5pq2QjQEUckHUB5j2loZQn/5+v2BrJLgVmPT1YwY/80ImX90NFyBHEj2LBtKcqVkOIg7ImTjl0QhvpMPkQ/rVMN7ai 78/Ee0Wt K83Q0vlUewtPAPtRYq9z0v5Ek9fFf++ZxkCcTHmr68sFDgCoq4cdiJ2aqu0UXGXhi5zHn+iKncTUYF3QwlKk5/VmioxFqqePjBZWlWSufzwR5TnrqQnSZIhNTFHQrNzhehc/AOuy2jV5YWrg2mQNO7gWUM590ji/RWL3VFTh1IJmnEQPQzYsVmYjibMhy4KAgYJpr/0uaILUgaiNN8wbqRqzuKqw0VzU8+8HckhiZIRT6TjtpKk1ye1GVViAl53jtuveKH8clYpba50pvSUmoWDysbADm1hqkD2tRaFlRCl48USUd9XGL/YHrD3Z+tdvDHJhe95rbH1pWna0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Sep 2024 15:40:26 +0530 Anshuman Khandual wrote: > All set_pte_safe() usage have been dropped after the commit eccd906484d1 > ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page") > This just drops now unused helper set_pte_safe(). > > Besides this macro was buggy due to doing direct dereferencing of the pte, > and if it were to be kept, it should have been updated to use a single call > to ptep_get(). > arch/x86/mm/init_64.c: In function 'set_pte_init': arch/x86/mm/init_64.c:83:17: error: implicit declaration of function 'set_pte_safe'; did you mean 'set_pmd_safe'? [-Werror=implicit-function-declaration] 83 | set_##type1##_safe(arg1, arg2); \ | ^~~~ arch/x86/mm/init_64.c:91:1: note: in expansion of macro 'DEFINE_ENTRY' 91 | DEFINE_ENTRY(pte, pte, init) | ^~~~~~~~~~~~