From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6508CEDE9AB for ; Tue, 10 Sep 2024 17:41:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D04C38D009C; Tue, 10 Sep 2024 13:41:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB4438D0056; Tue, 10 Sep 2024 13:41:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B550E8D009C; Tue, 10 Sep 2024 13:41:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9030D8D0056 for ; Tue, 10 Sep 2024 13:41:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3D8E040862 for ; Tue, 10 Sep 2024 17:41:00 +0000 (UTC) X-FDA: 82549544280.01.90B5157 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 90C0F80019 for ; Tue, 10 Sep 2024 17:40:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kPLVdU9j; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725990031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0k202Mnqc7USmS+jQaiZ2LEpFM1s7ZQx7wRNnA7Y38A=; b=qLRP/9ftMKAmO+QR+9Xp+rv6Tft/0w4go7y9KoFI9gmwhDvz20cVVr/4Bw3mxNHzw4MC5N KPT6qhuOkqHNk+8tjC+B/VXMdZQfu4FEHtvMo3EtdSjwNr5pXo4ZUHpApWSNYKhDAe63aI 95EHh7nmCkTXaS7TsF9z9FyySrKQ1xM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kPLVdU9j; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725990031; a=rsa-sha256; cv=none; b=l9In6SQqQPJI3NGxmiuaMnUFS0OocLwT76J0mmWEhLqbMsMnIsohPKlayIXlGcrpiiUXW8 cSsT9bqVSFmcJTC+V6mT8EkA/5Cb8yZ4Cl7vhz9316vb/Nw2lqWRCMIi5gGaRygu3salCv pRck3PlcWUcELOA66CNWN1T6tfdT6TQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 36CC7A449EF; Tue, 10 Sep 2024 17:40:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B281C4CEC3; Tue, 10 Sep 2024 17:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725990057; bh=Y5BFVWwAGNaN/6+LqhIBkQunwJLzvu1IrletRRXdq0A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kPLVdU9jVF9ruqeF09W7d1IaHHhYVcGjX+zojPd+ydRS+FHXi92jZhHYCH5NOAKV1 w00vxFQESo/meOF3tKu7uCuel4s6P61YAL3LDlnKCoQ9FrY88k7kc0Ob5PHllZAiaf gHuH8CJjgJAsx0N96NzxfpJ1uyACUCW7dGO1/rg8= Date: Tue, 10 Sep 2024 10:40:56 -0700 From: Andrew Morton To: "Huang, Ying" Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Thomas Gleixner Subject: Re: [linux-next:master 10352/10516] include/linux/mm.h:101:35: error: 'MAX_PHYSMEM_BITS' undeclared Message-Id: <20240910104056.343d7154134fb7fc6942075a@linux-foundation.org> In-Reply-To: <87wmjkyshl.fsf@yhuang6-desk2.ccr.corp.intel.com> References: <202409100913.RxkfrKU6-lkp@intel.com> <20240909204555.ab57c729531c83a0685cfa8e@linux-foundation.org> <87wmjkyshl.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: bogt1b984sfub1zerf7hd4nty9zhw9b6 X-Rspamd-Queue-Id: 90C0F80019 X-Rspamd-Server: rspam11 X-HE-Tag: 1725990058-284489 X-HE-Meta: U2FsdGVkX1/R2leFLF+qLbfv0ZjS+IKMH7q5O4q3pahbK8oQZaB9GMNTSnUFBIVQAkZGu/o93BoVPKSkl2l2LS+Zz+viWQMaIFgUp0C47/euvnx/ZIrbMFtOnabWPTlGVQUEHABjamCA+nI3VlE2ENa+19nbOJWN5SBDTpztKgaTTD3dR5yi4wNMztrG2cafyh+/VRVWfXlFho28o+VP7UXwA3igOsDdCPG2fJI37GsqXN17upOicdvvemo46lqy1BNd/zheX78UhlDFMhlrOxVEQ97OHNAzQLXXSFScz4ofa6gapq1+9gzC8ZduZYqhvStRLfseCwI4qk5k5RZpp62TWn8JExYmfYevc8L0pHKDfh5Fr3+Vm05Ow08l3QFvizHooGR2xVmfh96Zjk33v2iW+soTo9hLwpF5GqPxRepjgn8Jxi/djfzUeAVKGWVkZrF3QSuoQodLmOLWsZN7OXafX0oV/v5kgpJ+HOrfo6P0H2IN5E3nyILV1OpbAGVF2vMmHfQgjJTyQir4OTAPg8SSiE/RvhmmTXFwA5kk9UhkB+vkf4jWwHnKhb9MBGexBG1YZJvmTU1gAsBBEMDqHHuEhKPAqM7TogHrErQ9j0f6XtzSVNa6M6fMiBs9fTxXd87eag+AY9B5jJfcGbvy55CKa62yVj7PrCWljWD9URwKj5UeBj8z+3YNAuxXXtYxjFynvJnjVKPI1wqxZPIu4ZG5bvdj28SQaHNXuf137/dor+DoF7mkb5Q/JcOaWFF01jKb0ZD2mGtCXfGWoVmNtuhmXpI+yWbt7L4oQNLcUEewPDyTbYE8nV/6ngY/tNIxMD3srSU6I4JWaPTmzYokCUsqvnPRTzDD8k9NSCwwYo3OvvuxsZtEWql0yswOpMVqDJMWVVO63PrKbzfAjpjMTRO0DokPje7KuAVlNS+doGzalH12jpykSLeAMpgsT7MgUll7GF4MkCkdSGQIVKf vRAwmENm IEDaKsYjhAvA9WEb5pLinqGpr0lxiSv3tGPrkxUfWBhT2x3XM1E0KPkVnkcZqTJ4FZGYS1nXn0dcbN1983tEqz/ZPDqR8uTOIF2BOgZv4BSC/N8mQ4OgcXlD13307wQ+aifc2GqsNz9sklECZaku7cUOcCMB6qExR5LtuiCJ3wHgHUImkaIKmIAv5dcVQh7ytdyS6muBjSc6B1cxd3kHI/4v5kCsfljINA0P0ns//P2zmvtW+o659x/HzVPVzzSpifbiK7eKDhS4OYkwsypICg1apR7hwKMKICe8MNe3+zrc4SFzvBPokIuHG+489kXDjYN3rfhuLsNE6hqL0h33WTD78pM09CigOP0lm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Sep 2024 13:42:30 +0800 "Huang, Ying" wrote: > >> 93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) > >> | ^ > > > > Thanks. "resource, kunit: add test case for region_intersects" is the culprit. > > Yes. Although the definition in include/linux/mm.h introduced in > > commit ea72ce5da228 ("x86/kaslr: Expose and use the end of the physical memory address space") > > doesn't compile on m68k. There are no users of PHYSMEM_END before patch > "resource, kunit: add test case for region_intersects". This can be > fixed via the following patch. > > ---------------------------------8<-------------------------------------- > >From 00d176e0cd07e3df1ea37a5e56ca576c819b585a Mon Sep 17 00:00:00 2001 > From: Huang Ying > Date: Tue, 10 Sep 2024 13:20:40 +0800 > Subject: [PATCH] mm: fix PHYSMEM_END build error on m68k > > 0Day build system reported build error on m68k architecture for missing > the definition of MAX_PHYSMEM_BITS when defining PHYSMEM_END. Fixed it > via making PHYSMEM_END definition depends on MAX_PHYSMEM_BITS definition > conditionally. > > Signed-off-by: "Huang, Ying" > Cc: Thomas Gleixner > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202409100913.RxkfrKU6-lkp@intel.com/ > --- > include/linux/mm.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 147073601716..62bb7e7e0a17 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -98,7 +98,11 @@ extern int mmap_rnd_compat_bits __read_mostly; > #endif > > #ifndef PHYSMEM_END > -# define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) > +# ifdef MAX_PHYSMEM_BITS > +# define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) > +# else > +# define PHYSMEM_END (-1ULL) > +# endif > #endif > > #include I'm not really understanding. This patch (which I assume is against linux-next?) requires the presence of ea72ce5da228 ("x86/kaslr: Expose and use the end of the physical memory address space"), which is not present in mm.git. Yet mm.git exhibits the build failure.