From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Peter Xu <peterx@redhat.com>, Muchun Song <muchun.song@linux.dev>,
David Hildenbrand <david@redhat.com>,
Donet Tom <donettom@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v3 0/9] Unify hugetlb into arch_get_unmapped_area functions
Date: Tue, 10 Sep 2024 10:00:21 +0200 [thread overview]
Message-ID: <20240910080030.1272373-1-osalvador@suse.de> (raw)
rfc -> v1: Fix s390 compilation errors
Tested on s390
v1 -> v2: Rebased on top of mm-unstable
Fix sparc64 compilation errors
v2 -> v3: Rebased on top of mm-unstable
Fix bug reported by Lorenzo Stoakes
This is an attempt to get rid of a fair amount of duplicated code
wrt. hugetlb and *get_unmapped_area* functions.
HugeTLB registers a .get_unmapped_area function which gets called from
__get_unmapped_area().
hugetlb_get_unmapped_area() is defined by a bunch of architectures and
it also has a generic definition for those that do not define it.
Short-long story is that there is a ton of duplicated code between
specific hugetlb *_get_unmapped_area_* functions and mm-core functions,
so we can do better by teaching arch_get_unmapped_area* functions how
to deal with hugetlb mappings.
Note that not a lot of things need to be taught though.
hugetlb_get_unmapped_area, that gets called for hugetlb mappings,
runs some sanity checks prior to calling mm_get_unmapped_area_vmflags(),
so we do not need to that down the road in the respective
{generic,arch}_get_unmapped_area* functions.
More information can be found in the respective patches.
LTP mmapstress hugetlb selftests were ran succesfully on:
- arm64
- powerpc64
- s390
- x86_64
Oscar Salvador (9):
mm/mmap: Teach generic_get_unmapped_area{_topdown} to handle hugetlb
mappings
arch/s390: Teach arch_get_unmapped_area{_topdown} to handle hugetlb
mappings
arch/x86: Teach arch_get_unmapped_area_vmflags to handle hugetlb
mappings
arch/sparc: Teach arch_get_unmapped_area{_topdown} to handle hugetlb
mappings
arch/powerpc: Teach book3s64 arch_get_unmapped_area{_topdown} to
handle hugetlb mappings
mm: Make hugetlb mappings go through mm_get_unmapped_area_vmflags
mm: Drop hugetlb_get_unmapped_area{_*} functions
arch/s390: Clean up hugetlb definitions
mm: Consolidate common checks in hugetlb_get_unmapped_area
arch/loongarch/include/asm/hugetlb.h | 4 -
arch/mips/include/asm/hugetlb.h | 4 -
arch/parisc/include/asm/hugetlb.h | 15 ----
arch/parisc/mm/hugetlbpage.c | 21 ------
arch/powerpc/mm/book3s64/slice.c | 50 ++++++++-----
arch/s390/include/asm/hugetlb.h | 73 ++++--------------
arch/s390/mm/hugetlbpage.c | 85 ---------------------
arch/s390/mm/mmap.c | 9 ++-
arch/sh/include/asm/hugetlb.h | 15 ----
arch/sparc/kernel/sys_sparc_32.c | 17 ++++-
arch/sparc/kernel/sys_sparc_64.c | 37 +++++++--
arch/sparc/mm/hugetlbpage.c | 108 ---------------------------
arch/x86/kernel/sys_x86_64.c | 24 ++++--
arch/x86/mm/hugetlbpage.c | 101 -------------------------
fs/hugetlbfs/inode.c | 94 +++--------------------
include/asm-generic/hugetlb.h | 15 ++--
include/linux/hugetlb.h | 22 +++---
mm/mmap.c | 4 +
18 files changed, 145 insertions(+), 553 deletions(-)
--
2.46.0
next reply other threads:[~2024-09-10 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 8:00 Oscar Salvador [this message]
2024-09-10 8:00 ` [PATCH v3 1/9] mm/mmap: Teach generic_get_unmapped_area{_topdown} to handle hugetlb mappings Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 2/9] arch/s390: Teach arch_get_unmapped_area{_topdown} " Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 3/9] arch/x86: Teach arch_get_unmapped_area_vmflags " Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 4/9] arch/sparc: Teach arch_get_unmapped_area{_topdown} " Oscar Salvador
2024-09-13 11:16 ` kernel test robot
2024-09-10 8:00 ` [PATCH v3 5/9] arch/powerpc: Teach book3s64 " Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 6/9] mm: Make hugetlb mappings go through mm_get_unmapped_area_vmflags Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 7/9] mm: Drop hugetlb_get_unmapped_area{_*} functions Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 8/9] arch/s390: Clean up hugetlb definitions Oscar Salvador
2024-09-10 8:00 ` [PATCH v3 9/9] mm: Consolidate common checks in hugetlb_get_unmapped_area Oscar Salvador
2024-09-13 8:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910080030.1272373-1-osalvador@suse.de \
--to=osalvador@suse.de \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=donettom@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=peterx@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox