From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1A7ECE57E for ; Mon, 9 Sep 2024 22:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0E6E6B024A; Mon, 9 Sep 2024 18:30:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBD866B024B; Mon, 9 Sep 2024 18:30:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5E686B024C; Mon, 9 Sep 2024 18:30:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8823B6B024A for ; Mon, 9 Sep 2024 18:30:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3938F14014D for ; Mon, 9 Sep 2024 22:30:01 +0000 (UTC) X-FDA: 82546643802.27.37F55F4 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf06.hostedemail.com (Postfix) with ESMTP id 92A8F180007 for ; Mon, 9 Sep 2024 22:29:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fGARQLp7; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725920886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ELdw3m6NPb36FzZVf1fQMZc3BoSChv1vf5XeqAPXUpA=; b=fAB/AYHbuhgxsuK7OXRrJNybaxj33lPcDzPEIRSVxNqB/5JaMQqcZJjG/IHKZFKuOSZ2+F p+T701fYXerLSyQc4H9dXkKlMNC2XFPHaw/cidiWWVk5ZjqDE3mtaXjZQN/7mLDo4JDAx4 K/o+uqtkskb14nAV8of1arBr1ydLwA4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725920886; a=rsa-sha256; cv=none; b=vNojeYKo5A6lgiM1odLql2orcRYjfiPnW6hwP7zjqXTxccrNXCo9CThuHagbUhb5zPTxhI Po/LiLXSa3qYt9nKWArb2dLv1gJROhiWC0qC1vLR2CW3bpOSEcdQEWydox9FZxyHYcN5nh XHq/0jW2HzvVGXlDV0iKK2x8CRJ4a6A= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fGARQLp7; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5B969A43F91; Mon, 9 Sep 2024 22:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CDB6C4CEC5; Mon, 9 Sep 2024 22:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725920998; bh=qJ0xsOPGneJ9o+apQBK8rKN15U71Go1quiMy+DWSIdM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fGARQLp7dysAWus/Tj+ffB7ylN/IfM1r7UY5FquA2dS5Jz8BEt4g6lkaPxnou8dT8 wvnXYBZbVzBYnGhNB20wp2X/I+IsP4mcM48ok0qTLy+3K/tYiFSGErbF/smpXMSAcK rd6fBL2dw4N3QkS+J2ajpNvO477aZHJcTiNfftfs= Date: Mon, 9 Sep 2024 15:29:57 -0700 From: Andrew Morton To: Jingxiang Zeng Cc: Jingxiang Zeng , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcontrol: add per-memcg pgpgin/pswpin counter Message-Id: <20240909152957.f3d57c43fc6a21319c6e3776@linux-foundation.org> In-Reply-To: <20240830082244.156923-1-jingxiangzeng.cas@gmail.com> References: <20240830082244.156923-1-jingxiangzeng.cas@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 92A8F180007 X-Stat-Signature: tbur7sm6xmt9oichmw5y55d1nbjxf7ki X-Rspam-User: X-HE-Tag: 1725920999-321145 X-HE-Meta: U2FsdGVkX1/fvVxCiBI40HcSszEsp3AsG0rFQphevOqvhKtoMNu4Ahy5cgk/ZzjrbPRzEMAoZhKZuC6BJ0E4/Rn5TvkZW8MNO8yaFIb7tI2dZEGZ/3n2DT0OyiP3JXx0bnIeeXBedDsanT0/oNMCVzbOrSohJYH3KmghtnsK8eNmWmqOtOKIzV0oBoIHwV9hvnU/vzpWkcJdjC6ZlH5V6WRzSlV21hKU8qGZxfXdskIcp1xi7wsbu1j75pAUDCtaLDRvpgIeYUfCPjq5mD7ItaRO1dATXkkcGEsHYEYrNhTzy5D3rmXamZm1cYxgHK1F5Rg0mR86sxncKjI9i0pYqaKrStcMrJ0bGj3K8bMa+p55eTk+V2/nMIa1quFaVwj0lrsQoy1SMGNs9Q5ZLnM7UZYO4xATxn3tgH3LuU31X0NSiUlwuEBKGTYFw8M2uh3BNr1oj1x/hL8/1U5hgiE7FToFMt436f0Q3R3WcmS3dHiX8MZHg3j9UV9bd2IUdP9+C42XlFCZMZQLRCx0qasIplC9KJodAQ/ZLaTzIY78Y5cbrieq7kUXZdgD/CbQpmG9mV9ogS2nAxJ241VnnspVLLb7iBGX7aEzuhkQbZHpsSu7uOHLUzrm1DeKBw1jFJH6JquV+G4srZ8fm6RaqOQAa2wbM/V7Nw6BVj3y98xgaxserE7FksV/yaN6U3VsDDW6U5v3/gRd2Iq7hwYbjtbLVhFkUMCYtuTF0Zy9ia3vcukgbDSNIQlJtZ8eMPgwEGO2+gePrWmD5KSUWWO0QIyjZPWh2lp6l0S2Nzpo/9ZxH3jiguQZC3CMeEsbmGm0zQZC9oNG2i8rIRr0NM4cNSUJSn+1LdXN1NYzhozKcZ8APNra92N9z3n7gZju3K8gsFoCte9bJRHM1M0CJZD0VriJLegQQ4FpaH1n5gSb9Nd4S3dxtWy/hi9jFFL3WAfSFR6FMoaeTAdgVDCLrHzafNe /A/Utm6+ a6ZXrLeXsgkpPCxKmuCbKRpLAkscuRL2c/QyMZnUbDFVENtagvJ0EDtynxg2vzMkPzQ8+V9ML4mhNEsJ61fxE7+eTtKvhLPwg+7KYhGU8gIbJ80xBjg77fOAfsyp6iF4C/i4GelPWgmbFjo/KBQfVjvvaxems/wCa+pBpNzDAh9PhIDW3ln+RrZ2+zyWBpsgtUBGp4L2D2VO7Rkh9Rvs5ZtNEOhXczOjsXt5zMh6MXGJbXjTAxa9QpdOjceO307VQaMnOXiD7sHkOEfH42KioxTGcIAcp+kb2cBm732nnBXTLyotH8w8OEzsMT65LzjyD4IV/QaunhnrVJgEhS22S7/91BS5WpYdmZ+/VH3bPyW2yQWA/1mOPvR8/mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 30 Aug 2024 16:22:44 +0800 Jingxiang Zeng wrote: > From: Jingxiang Zeng > > In proactive memory reclamation scenarios, it is necessary to > estimate the pswpin and pswpout metrics of the cgroup to > determine whether to continue reclaiming anonymous pages in > the current batch. This patch will collect these metrics and > expose them. Could we have some reviewer input on this please? > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index b37c0d870816..44803cbea38a 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -2729,6 +2729,8 @@ static const char *const memcg1_stat_names[] = { > static const unsigned int memcg1_events[] = { > PGPGIN, > PGPGOUT, > + PSWPIN, > + PSWPOUT, > PGFAULT, > PGMAJFAULT, > }; > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 087a8cb1a6d8..dde3d026f174 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -418,6 +418,8 @@ static const unsigned int memcg_vm_event_stat[] = { > PGPGIN, > PGPGOUT, > #endif > + PSWPIN, > + PSWPOUT, > PGSCAN_KSWAPD, > PGSCAN_DIRECT, > PGSCAN_KHUGEPAGED, > diff --git a/mm/page_io.c b/mm/page_io.c > index b6f1519d63b0..4bc77d1c6bfa 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -310,6 +310,7 @@ static inline void count_swpout_vm_event(struct folio *folio) > } > count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT); > #endif > + count_memcg_folio_events(folio, PSWPOUT, folio_nr_pages(folio)); > count_vm_events(PSWPOUT, folio_nr_pages(folio)); > } > > @@ -505,6 +506,7 @@ static void sio_read_complete(struct kiocb *iocb, long ret) > for (p = 0; p < sio->pages; p++) { > struct folio *folio = page_folio(sio->bvec[p].bv_page); > > + count_memcg_folio_events(folio, PSWPIN, folio_nr_pages(folio)); > folio_mark_uptodate(folio); > folio_unlock(folio); > } > @@ -588,6 +590,7 @@ static void swap_read_folio_bdev_sync(struct folio *folio, > * attempt to access it in the page fault retry time check. > */ > get_task_struct(current); > + count_memcg_folio_events(folio, PSWPIN, folio_nr_pages(folio)); > count_vm_event(PSWPIN); > submit_bio_wait(&bio); > __end_swap_bio_read(&bio); > @@ -603,6 +606,7 @@ static void swap_read_folio_bdev_async(struct folio *folio, > bio->bi_iter.bi_sector = swap_folio_sector(folio); > bio->bi_end_io = end_swap_bio_read; > bio_add_folio_nofail(bio, folio, folio_size(folio), 0); > + count_memcg_folio_events(folio, PSWPIN, folio_nr_pages(folio)); > count_vm_event(PSWPIN); > submit_bio(bio); > } > -- > 2.43.5 >