From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D1CECE587 for ; Mon, 9 Sep 2024 19:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C79A6B01F4; Mon, 9 Sep 2024 15:26:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 677E46B01F5; Mon, 9 Sep 2024 15:26:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 566366B01F6; Mon, 9 Sep 2024 15:26:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3A0EB6B01F4 for ; Mon, 9 Sep 2024 15:26:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B971041078 for ; Mon, 9 Sep 2024 19:26:01 +0000 (UTC) X-FDA: 82546180122.12.073FA00 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 1345914000B for ; Mon, 9 Sep 2024 19:25:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LlCkyin9; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725909933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7hT7mwP/bPK/R52Y2PIBMgyPSbX+GR6PqxprMZx8Tfk=; b=CmrqqhtyUq+MHMyJ3WuuBKIMDticKcwVkjUk1OKe25FWL6AqhJ5XV3oUYxZyZQht4rbHnG T2ecWywhZ7bt827Ixn+DL80FZbQK3rPIz+k190BAZGZYL+j29uKYEXkr94QkXSO2+S848S FaWYdD93hoEqTiWvqR127nxD4iSOaFI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LlCkyin9; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725909933; a=rsa-sha256; cv=none; b=dj+ucGzm2qkk/a/K3sQkK3YI3ka3xluDEv/DIUwM5E69hbRjhCAwn+eecNfXZ7HQYtj98k Jv766zKhESPAwK6UvpccIi5jiHRZNALQHF+R2A4VorVH6iDnGWBoN+ML7SJdI5YM7Zo7gC nWtQkh/0cjLe+qtQ6MkceZ0iA5dbPfA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C4DADA4264A; Mon, 9 Sep 2024 19:25:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD15FC4CEC5; Mon, 9 Sep 2024 19:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725909959; bh=6cFRJ7QTI060/l0RiIArue/oZNh9iSuzlPNI3agtK8I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LlCkyin9vMc8xX57B9Zd1YcvgW2JL9aXetMjuqwNUl42LCW6rfw340z2V8z3kmd9v 1OjkWjwjM3Ny4TxaH2H/EgqXHaaIvqwPCtsOb8rXHt++nDkICnf7wDAMoo4qxEZ0/J o7wTylyb81oK22MOsgpl6/AIa/gH2b1rQ+2VvRrQ= Date: Mon, 9 Sep 2024 12:25:58 -0700 From: Andrew Morton To: "Kirill A. Shutemov" Cc: Vlastimil Babka , Mike Rapoport , "Matthew Wilcox (Oracle)" , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] mm/page: Drop has_unaccepted_memory() helper Message-Id: <20240909122558.aa726d312d8b166a515dd751@linux-foundation.org> In-Reply-To: <20240909081930.748708-1-kirill.shutemov@linux.intel.com> References: <20240909081930.748708-1-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: orncz78tjccej5jtcoxfkp9ya33igzpm X-Rspamd-Queue-Id: 1345914000B X-Rspamd-Server: rspam11 X-HE-Tag: 1725909959-61128 X-HE-Meta: U2FsdGVkX1+iD3Bc0mcp/bo8k5RVbBZz0QT2M5e9LE2DpGGPAY6RDalwBxdFBe2fbVtYJ9vSD0bAazpQLXrB9bTw/BqHp5LOuUdBDTL7WMH2mCAV3MoSvicPJvNnq8ek3TL3xaaSVVrQ6KaytYcl5l6jT5312vn1kE5sz3Q9y33f2nomV903R8Ist3PLjN0gG+L+E3R7OVedsza7NXn7XUC0hjO7AK0isEB22L+mlXn4FaT3R6wcPejhgJIqOEuM+YPV5xs8eXdAwlz1zmRhZ6mdDYdeO0bvdeAMVILw4pvqFMPqThUHmLSzFallnIwt/UMQBh2gJaecoAdJaNGgbAUj31qUeG4SI/17rAItJGKzm1FmNKoDdkZAI1AfqDIH3pT+zV2Ju8RErshdOqea3ziBVej5iOtaWtC8NKS/a0knJd8mCw+gd5LYFd3Sy2Rrs8gpxYhifhKiVYdMH+JNSXBFC0s/T46vMYn9FiB/jebjuuClkIUOHppGjpzk3wjV0ncQCGdNsDStoz/hoJ2bQpQrqTDxss3fQGMLvhkCwbpEEqvxJEdexyTUvw5zniHSVpqGL0hwSDOZ5RKkTIIePnbdzj3Ardc3bzlyoyNs0bwbXi1Rcv54VSwVlZnm/e7nDQR8557CpsxX6NeZNCMf0pesVrIhEw4yksZ5HBbsp/L2Jcd7LOfUwWg6AxBv0GqelXLwc7C3o0J4TZ2SravJLmoxQyjl4qRYOrnR3bTnvAQSvsSQhsarc/zcbkXZXDTwdHAicy3nzMNHwjs5ubFa+H8vhZyMAYg2KqB6xSMm/Q5FTVLxydWVNPIY00e4SRB2xhbslzhgdEsH02UP8BCARychEenk9rtzmp0qaJ0ULVF4rfshhY8LZTYLYEOQgp+Qbhe8HjjX0q1wsYM/ntrleOyhOTEBs1WSX/HK0XkYcVBunxNsdwFcYnJXtor2f97OvvOTo01yAPMumLE7xV3 p9bot9Nz ISfWDuvOQnm/5IVf1pjzmhXq17N9XoV2TjNu/m1hkSC3N+c/8yS+HWkEczzvzzNfMzrOG4qVD9mZ2zCjCbm3AnVr1vNlLRyi4feUf+lePagrc+y4g1pka0wBBUcJZtJfE7LJf2npDlXV584+Axwr1VnK1C/0yUnNbB3qGI+gjk/IUWK+ZNYxzTz2xx8CWQq3BiFwXoRMFaf1ph3sKQeFrEg9kdcf52YkmpX2Be9KSbZVi0676BkxN20FR99dnLTJKeB/NIVyDjRJcbDPLDVRyltly6fZGvqeDxb+4SqHYHewCxE/p4ToLdJPvua4b7dYBA+2j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Sep 2024 11:19:30 +0300 "Kirill A. Shutemov" wrote: > has_unaccepted_memory() has the only caller -- cond_accept_memory(). > > Remove the helper and check zones_with_unaccepted_pages directly in > cond_accept_memory(). > > It also fixes warning with clang 18 when kernel is compiled without > unaccepted memory support: > > mm/page_alloc.c:7043:20: error: unused function 'has_unaccepted_memory' [-Werror,-Wunused-function] > Thanks, mm-unstable has a similar fix: --- a/mm/page_alloc.c~mm-page_alloc-fix-build-with-config_unaccepted_memory=n +++ a/mm/page_alloc.c @@ -287,7 +287,6 @@ EXPORT_SYMBOL(nr_online_nodes); static bool page_contains_unaccepted(struct page *page, unsigned int order); static bool cond_accept_memory(struct zone *zone, unsigned int order); -static inline bool has_unaccepted_memory(void); static bool __free_unaccepted(struct page *page); int page_group_by_mobility_disabled __read_mostly; @@ -7068,6 +7067,11 @@ static bool try_to_accept_memory_one(str return true; } +static inline bool has_unaccepted_memory(void) +{ + return static_branch_unlikely(&zones_with_unaccepted_pages); +} + static bool cond_accept_memory(struct zone *zone, unsigned int order) { long to_accept; @@ -7095,11 +7099,6 @@ static bool cond_accept_memory(struct zo return ret; } -static inline bool has_unaccepted_memory(void) -{ - return static_branch_unlikely(&zones_with_unaccepted_pages); -} - static bool __free_unaccepted(struct page *page) { struct zone *zone = page_zone(page); @@ -7134,11 +7133,6 @@ static bool cond_accept_memory(struct zo { return false; } - -static inline bool has_unaccepted_memory(void) -{ - return false; -} static bool __free_unaccepted(struct page *page) { _