From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945A5ECE57A for ; Mon, 9 Sep 2024 14:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A2C26B017F; Mon, 9 Sep 2024 10:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252CE6B0180; Mon, 9 Sep 2024 10:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 141E36B0181; Mon, 9 Sep 2024 10:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E9EA66B017F for ; Mon, 9 Sep 2024 10:49:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9E5B1120503 for ; Mon, 9 Sep 2024 14:49:50 +0000 (UTC) X-FDA: 82545484140.08.9692548 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id E168E1A000F for ; Mon, 9 Sep 2024 14:49:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=5O0H=QH=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=5O0H=QH=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725893338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rCUjKs3zWYCyeMG5H+lBybDJNyI55woPVsrQWuULxrg=; b=tbzuAUj11VmC3/3Gcm0GKnMFTg8GR4DHdH9g6hDlgfMJQmub6u1cpIF4GJPey7OvQushod SMSvGHsDKuexQ+TcADZatRreRrkAyxzzVEuHxsfOKHXlbuAGGZTDN7rjzuBGMicplwzQl6 2rwIOS8vk1bMAQxXRvDxItnqtDPCL/w= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=5O0H=QH=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=5O0H=QH=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725893338; a=rsa-sha256; cv=none; b=bmRToicH8EevoD0Xv+RXv2pNUKPoyb4hLD37YHsacADO9IXVZ95lytIsJbt6ALKnc3MXTO 5L55D7DDCH0CnqsF8Z7Rxn64JKCezzBZl8kmuvhywBNlzFBpobEZWKvKAAK7JkB2sPrjnS 1dlRT6MtWrosAoIbFHmLVHXVOFg1OFA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B62E3A43CB7; Mon, 9 Sep 2024 14:49:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B23C7C4CEC5; Mon, 9 Sep 2024 14:49:41 +0000 (UTC) Date: Mon, 9 Sep 2024 10:49:40 -0400 From: Steven Rostedt To: Mike Rapoport Cc: Peter Zijlstra , Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: <20240909104940.71d8464c@gandalf.local.home> In-Reply-To: References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-7-rppt@kernel.org> <20240909092923.GB4723@noisy.programming.kicks-ass.net> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E168E1A000F X-Stat-Signature: rr3ktwi7kytrq5sdxuz5bc8o9wpmesqi X-HE-Tag: 1725893388-108815 X-HE-Meta: U2FsdGVkX1+V2Q4vZoZSy6ogii68CoYYkUxEOyY1d+fOjHomtqe8p5+oOUvuJZa2wh4Vp/Q9JG94AUtJYdGj6CLa+un7jq3lZdJeog2nva7krEGfdCfk88TWSwtD+aEe5knoKV/RcwSgg42eEl5aC9iorottHmMa4eISVqBH/+MGDBI4oLSIPUBKDgWTdBEGkXBj5ygFPO1r5jTIctq+4eLFJ1/TVRRoPUfvZKbM8m7aLU9JTQ8XU+66vEQPSfgcQKZmVkWmOxUfq9IbCXJ78MckwRkoYzfR16kBM8w4F2bGqB+BCwBZkEhXXW62hGrN+TBHvibchBlPBbePj42g2f6WtuG+jl6h2VdFyvta99Yq8BedbI+/OqcklhYL19QdW6w4ShcM/ue5yYjjqGKDiUAkI3yQ8DzrrRqlJuOi5AzQ+Z0r2xmdItgDbKH7yZheyrRJW/YjMY4sjLh8JysSdKWXOWilMQ7fA/tRpc0HIw7+7vBnrS2JWRKy9NWjck4JldsThCbTnrMVtfHoF46UR+M7Vbcjg8tHNIvy8gP+6EP4fmfNJP6FrsGGM2zk4xL3tDnRxYvRpwmGpt13x2zSTH8WHkRs/jpHoCiOv6UX8EAhhzAWHmZjs83yMBwG4U32b8MUetmOIfpYSX5Rm7GopWGqHdA3jGzBei79D6OxMY3nkKrEe8aNaPxq36+JWkbbJta9rSBndmpqoSlS1hdx4lzmJOkMwP4MKfr86g2g7UOH4BMZ5oviPb8nXrTutUDhYxbOJKplQpzBktT41j5Y8GU2waXmI6iQwJYLQzuJGrIPJbK7N7Kbu3Qf+3U5h1eXD+ucAS+HLAOCUdmGCY2z6sTTC++82rm6NLg50k94WGZvUGN5k23RNwCDh9SqzeAe/hLS/0ozsqEiNyEOFAMJTGXGrV/qlOuCZTVbqDN5tby+oeuK4lzoWp1sD4yjSGWgO4fWpwig9KNLccBSwRh BPJlBQEg H/nnzG0rA40Szn9AeomjIMd3zu7KFIyw5jOoUIWLPhwinotX90ypD1vFm9IaPoYZ5a13cR+7ctt2ybW/EGMcDyu6LWL0Z2ASs9PKv27v3UxG2/hD/v7BK2odvlboNE/Xf1Hh/Bi9EK5LmwwRTmtGhzouVmIHjhyJq4C+IeGMJesCFbu2S22UouEJsSjfnqEGuzhqtpeXVLeOftXoxlvccQdm6lgr5UZXOWlW6LvmBjnbrTnhvwynFAu/ACPYoMrJT2nE3X1RgxHfRWaXnc+guSwTs+Lf/uYRAO8cklWahXmVEc/watWxLsH42eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Sep 2024 17:34:48 +0300 Mike Rapoport wrote: > > This is insane, just force BUILDTIME_MCOUNT_SORT > > The comment in ftrace.c says "... while mcount loc in modules can not be > sorted at build time" > > I don't know enough about objtool, but I'd presume it's because the sorting > should happen after relocations, no? > IIRC, the sorting at build time uses scripts/sorttable.c, which from what I can tell, only gets called on vmlinux. -- Steve