From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180B8ECE57B for ; Mon, 9 Sep 2024 09:30:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83CC36B0149; Mon, 9 Sep 2024 05:30:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 815A86B014A; Mon, 9 Sep 2024 05:30:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4BF6B014B; Mon, 9 Sep 2024 05:30:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4AE606B0149 for ; Mon, 9 Sep 2024 05:30:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AE472AAA23 for ; Mon, 9 Sep 2024 09:29:59 +0000 (UTC) X-FDA: 82544678118.30.AEB9DD9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 7B40F10000A for ; Mon, 9 Sep 2024 09:29:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PHcK1SUW; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725874096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f16Hum48X2/PRv+OYRnrqWvXhbLKUUXP4MBg4DPZdlQ=; b=wfh43VGkIwAAIKntm++rzByAD23Epg9Kq3D0txrX5D1VrjCApWGkZWd+b3nqUsIfc6OrAS v9bwx0/hRhWDm3EyDg9sCZaTmNsGv9nILB2FQsxeaMTB7hKzR7gOZMDyoMy61H587DDUr6 /LDH07DOD4n4EOQMkbP4IIQ65pjIT4k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725874096; a=rsa-sha256; cv=none; b=xBsLYxyjE8hNl140o08gM6U4RmxcXLgc4zFrSNtE9TDQ91DV7cc6ToSy3bmN7d2ivKi+6p yKJthHT38Olbx6v8SI2YkcEjaD4UwG9jo2Wz8bflyDcwxhhzbQMwQbwFPVboGqhfaksNP5 6i22EE+qbBtHDQ7vJfjrYt/9e0Slarc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PHcK1SUW; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f16Hum48X2/PRv+OYRnrqWvXhbLKUUXP4MBg4DPZdlQ=; b=PHcK1SUWaNK+mGL/l3LU81VEdD D9nBb1lF9fC+k5KduxINliKCuQNtwOV9r3VV7JhDFojWrMZqtjtzwsWQR7ymjqHMdZK4/Tzo1krQG l72L0TWbRaFKsNxIJEvL02K4akN/vihdxELVqTsQPMZh102jhI0PE6Yrqkpm+R5bTxUWvCjPykmtq WlbddJH0odsLTU/9pMOdxn+PkTNa49n7N5ZvM4UD0maObK3Zd9qj9kNJXbjqHQeNmT1JTuolvrtNi Vpta2pPXprvf8lrp/xLulCdRHeE9tzU/AQ/jRdr1yi09xwhjfkgynp4ly+k7LQoKGQqGefX9PFflQ rxIuTYAw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1snai3-0000000AlXL-0vBQ; Mon, 09 Sep 2024 09:29:24 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 80F5330047C; Mon, 9 Sep 2024 11:29:23 +0200 (CEST) Date: Mon, 9 Sep 2024 11:29:23 +0200 From: Peter Zijlstra To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: <20240909092923.GB4723@noisy.programming.kicks-ass.net> References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-7-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909064730.3290724-7-rppt@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7B40F10000A X-Stat-Signature: aquxmewcj3dkrmko36eamts6yx9k78sz X-HE-Tag: 1725874197-360497 X-HE-Meta: U2FsdGVkX18ZROuEKWBzI2FNJbjDlcZAuXrDn2KuO6bnWAcgPfmW84GucLmtWdcjqUTy6SG7df7NQm40iXj5xiWOgNbiL3muR3y5q6ReckFz+eQpKVv31FhE7Sex1FoxVFzI8D1EF9TB4/RBirGlpXgMBj7mGpLuYGitYUPR9Q6K/zHRrrzIxzWnkHWpTpZE73LwYZazoghN97qlIlin/vFWIx4dPeDC6Zo6g3EgT+42Q+gBXUaloNuCZPxRrss08epcQ45mVY9deHmXWSs3mn0ETLzfMhGNlVxKvYcDdpHtJeCZFE6TXbKqplA6uycXL207W7TPhJ2OZmgrFUlIFtkFqsTTSPOdsXG/4mpW35uH34US6bSvJd8XdMRGGgkM3NbXPud9s1xvipRMjklMlE2WUTndPZr0MAAtBZy8732b5Zqebw6ryMnWzMdnAf+n3E4PNBykG9m2ESPZNz08xcdeVZd5jIoCrY+NkgbP6FssBH58fhgW63xw43r7cBTF3yzjuvFDr9smcmTnUp/4PU/Fb3iJ61+95K3EtSNKBBo7UAr6vWe7xMwoaMXh71vPKwC7bTGlFHjzJT9duB+Mzhe9tZoMREA6QHc2udwIcQEx8N8NXpdB+t3IEBVXFThaIC5Co4XvVguE4NCQHjBUcUimGQ8hEEK0HLCEZHFfxb7BFNai4MhX7z0ofotxA72T0JmIZlOCRig836CHjKm8OjGXokOCQGkbDn7v/hJ4dX2sBCm/ojTOvjDiPDRPVNU+x038FkR6PLlCKIKneN19Ph08Q5nvbqYiPsfD+jFd6dFdt+CyUnQjnlhkb/R2ap3hP8QghmsAko3eLMSYM6+PAPbsgg4Xu87qJMtu6WcO4WO/5KIG+SibxaVaxbpOaUhkesAaT7gP+G/yj7HSoU2cKb6z/fNwXjy+vD/k/PW6t/ZOI4xT7lJYm0Dxtk1li7SvnYI/DprVaUEPRDfqQQb zCcTT411 heiXyE//4dwSpgAzQjsGlM5bPxZV7kysnrdXmlPWnkUmKbaiXKp1y8m7jlZmXZQXrOAa7lw3kOX8p/akS7hCBHpF2uf4ZW/QHlzMwrbTDV4kOrBt4MlLNZ2FStgHlm4mYohYu4jLvFaLzCa/ZGCWSbBVpX0B8arzP6ktVNnZwp+kcfwo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 09:47:28AM +0300, Mike Rapoport wrote: > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > index 8da0e66ca22d..563d9a890ce2 100644 > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -654,4 +656,15 @@ void ftrace_graph_func(unsigned long ip, unsigned long parent_ip, > } > #endif > > +void ftrace_swap_func(void *a, void *b, int n) > +{ > + unsigned long t; > + > + WARN_ON_ONCE(n != sizeof(t)); > + > + t = *((unsigned long *)a); > + text_poke_copy(a, b, sizeof(t)); > + text_poke_copy(b, &t, sizeof(t)); > +} This is insane, just force BUILDTIME_MCOUNT_SORT