From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26238EB64CD for ; Sat, 7 Sep 2024 17:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D8836B00A8; Sat, 7 Sep 2024 13:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 888636B00A9; Sat, 7 Sep 2024 13:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 751336B00AA; Sat, 7 Sep 2024 13:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 57B376B00A8 for ; Sat, 7 Sep 2024 13:38:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0548B1A1967 for ; Sat, 7 Sep 2024 17:38:09 +0000 (UTC) X-FDA: 82538650698.10.B4CC226 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf09.hostedemail.com (Postfix) with ESMTP id B1C1F14000C for ; Sat, 7 Sep 2024 17:38:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Zjg2HNwK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725730576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=40CJg+QTHMTD1DbxBrYOIfNgDYiqQbIto6TMaaaynLc=; b=1CuRyqU/TAyItbLgoZOTm6nxQeNyz+ZpFMrxxUzDZT15otNDmmwfvOEL9i+xBVNhJsK4yy GqmWqTchI2UZPtniC/EswXkQJ0nrqfAJ3Xyh3N+W5aFwmCArkWQSvA1btFjZK5jV8ReIte DbFx0ymGjmlH0pD9la3rj5CeHeoyyrA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725730576; a=rsa-sha256; cv=none; b=EmM3iyzowr/IwLoHxffiFWMDheLgV1Nz0kv5tGE9y3+d1+Fol7HXwy1M1qul/hANPDnkzf U2nhOSYM4tHWiqwWB2ts+jtGxz7USlieZRRcB1lhyQ3PnqZMo9o2c6P5zSwiIJn9iqJ3dJ URPGEuzSeyUFxQZMftN0Mv7qFkztcU8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Zjg2HNwK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725730687; x=1757266687; h=date:from:to:cc:subject:message-id:mime-version; bh=ut056WosS5bH9O8MuEeJK01sOG52OioJ7v3sbE25gXI=; b=Zjg2HNwKlREYaA8KD1s6wpIS2kly01dHXXb4QPI5v2G4NaGoPjTwMRoa Tb/9/mVSYpuvoh41GjeZWfaUiM2vLWRXdGt817UPNhL3PO30mdpQuxEKQ b5WuoRGZTrkIEQz1uGfeBJABj4LIsrYJIv2aIuKB0mxrHiONgApj8Gazr tOqQTckr560hqJWGK/wTFiKJJj2A0yQ4kZUhl+aEgE04nCnUhpnXI4i6a asSrXMoNiNFtgRWpSFRkFil7ah2MoqVqgcEkqOWFLs7IFMWpIA5bwJf4G KCtZ7zSwq55/CDKPK7ORG9sv+jfblrtEN6uxOAxvHNdfdKJ3q4ooPj1PT Q==; X-CSE-ConnectionGUID: swrDIhsaTqyAXX+gWtnH2A== X-CSE-MsgGUID: FdU723CBRBOb6RNQteTeZA== X-IronPort-AV: E=McAfee;i="6700,10204,11188"; a="24265633" X-IronPort-AV: E=Sophos;i="6.10,210,1719903600"; d="scan'208";a="24265633" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2024 10:38:05 -0700 X-CSE-ConnectionGUID: ZK29G6hORkmc0tIX2+Hk3g== X-CSE-MsgGUID: 5CN3PwV5QuOZDtTQgqAoVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,210,1719903600"; d="scan'208";a="66788055" Received: from lkp-server01.sh.intel.com (HELO 9c6b1c7d3b50) ([10.239.97.150]) by orviesa007.jf.intel.com with ESMTP; 07 Sep 2024 10:38:04 -0700 Received: from kbuild by 9c6b1c7d3b50 with local (Exim 4.96) (envelope-from ) id 1smzNp-000Cn5-1e; Sat, 07 Sep 2024 17:38:01 +0000 Date: Sun, 8 Sep 2024 01:37:08 +0800 From: kernel test robot To: Stephen Rothwell Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:master 10291/10296] drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:416:18: warning: this 'if' clause does not guard... Message-ID: <202409080140.ncu18wOy-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B1C1F14000C X-Stat-Signature: o5dmbxdpww7w89sugc3jwuxwtrs54xur X-Rspam-User: X-HE-Tag: 1725730686-988094 X-HE-Meta: U2FsdGVkX1//083dM0wTg0GcB0x+lNHUHKxptCg+9BryPP3PgBPOXOZBNnIKvmxVqcH2r4PcbM7OXaTljghayD30elGnTgXs8Hrxn2UreEnSsS3TG7nLGE+EmJ4zRq1K3LXqjmPClQpmpggz9wO10fjachjz26i4ZunKg7O57WQ03axAIYknfJjhLYnk3HZgk/tZLksUORysbZIhjGRZrVay+driWo6PQGE+FbQYe9x7g13qc+P1mffLTNnb+vMEFWMPFpj3B8pwrZQnrkIjxeTtFDiL2WKclJUwpJzL6sR2Kkaf7asDLPt+iRQomWMycHdbh2933oCCgOQOizHacQdRfQ2pHKGKYf3GYDD3cNQ3IEITLpwR0qj3SU0xjRtbNQ81V0SjTyvUfKjMfBOIf8OWUx0/oFcoGd5dTt+HfKpBzp3oMGbjZq0gW9Fp5bXOoUm5R3Jdz4pfoh1MzXywgnBtYSbU7J1qZRHBcR0DD0WkuufSaRuEVkss6e/vZDJVQUNNCWo6kxl+2oPA7COodV3ipbnJJdZTr5z3fHQYcUzTa/0ThgnYumM3JcvoJ24lhozw620B3DAoDbNx354vII74lZN1AjL/hpaIhThqRDijVLuXhvPbC5hzx50KHDniV7bY7B37N8s6xiHdr3sM8f8WaL8zCLt5mdwcM8pairpbG//2ClAVGnqAeh61W0pe5rLZnSR8C3qwwJ3DX1h4DNVLzzrp81q12Ojl1utdiTfCXqz+Gn/JMnYRtmXm5o7pDB2VHHzbCbpCYFQK9MJcnNkPpz+XEGDIU852HTXxDNDrvAlCyjonazPlylz2VQK75pC9LYOyoxd0OWjVMT4ix5++DNkSLELLXO64kk08PwonXXYawWeh3swiIG5Hl6cekwUWq930ykvsryLZVN72pQEbfIZl7G4y9VfZfJxOVgYDiTmf6++HRR+zGJy1Nzv5a2KiIqqy50ht4cvonNn FXwF5QdN YmsfVdWdQE/x1iUkSjk3sGYNKH53ozlBA2oheNXvnoN3jAoo7ljGU/9eUXUDuw/xjZpywvhWz4Vbj9xLNd/vEeCRjBlULPbvEpjIQDqj/4WCouiTN0wEbQmcf+lJNNwf9pe4SD5fBG6Zq/upgJAkQ/yWKRrSdiXiOUUXsmN3u01QjzpKeXscwWRq/sWuQJayvgZHZ05lu7rLUn3Ery/+kQXFmtW8EQb+fceEOzOct7S5cYZuhNe+PIdZwsfAukf4DCEDGIuLyZxI4y3ZEl+mKKCQt1UsLBHnUJXhncNdStRHAkZiaCJxcOhQvsYl31jC6rkgAwe+Jr1EeTHmud6OU3inbXLd6IOjXnNjmsdclJ1ki+V1MshpdG8NhDYh921sdPPsr7Khg9mBP2eg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 9aaeb87ce1e966169a57f53a02ba05b30880ffb8 commit: be28b79807f6ed29ff87ffedfac848ea50c1e2fe [10291/10296] fix up for "lib/string_choices: Add str_true_false()/str_false_true() helper' config: s390-randconfig-r004-20220823 (https://download.01.org/0day-ci/archive/20240908/202409080140.ncu18wOy-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240908/202409080140.ncu18wOy-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409080140.ncu18wOy-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/amd/amdgpu/mes_v11_0.c: In function 'mes_v11_0_reset_queue_mmio': >> drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:416:18: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 416 | for (i = 0; i < adev->usec_timeout; i++) { | ^~ In file included from include/linux/delay.h:27, from drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:32, from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29, from drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:62, from drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:26: arch/s390/include/asm/delay.h:21:19: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 21 | #define udelay(n) __udelay((unsigned long)(n)) | ^~~~~~~~ drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:418:25: note: in expansion of macro 'udelay' 418 | break; | ^~~~~~ vim +/if +416 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c 028c3fb37e705b Jack Xiao 2022-04-13 363 178ad0e280c088 Jiadong Zhu 2024-07-04 364 static int mes_v11_0_reset_queue_mmio(struct amdgpu_mes *mes, uint32_t queue_type, 178ad0e280c088 Jiadong Zhu 2024-07-04 365 uint32_t me_id, uint32_t pipe_id, 178ad0e280c088 Jiadong Zhu 2024-07-04 366 uint32_t queue_id, uint32_t vmid) 178ad0e280c088 Jiadong Zhu 2024-07-04 367 { 178ad0e280c088 Jiadong Zhu 2024-07-04 368 struct amdgpu_device *adev = mes->adev; 178ad0e280c088 Jiadong Zhu 2024-07-04 369 uint32_t value; 178ad0e280c088 Jiadong Zhu 2024-07-04 370 int i, r = 0; 178ad0e280c088 Jiadong Zhu 2024-07-04 371 178ad0e280c088 Jiadong Zhu 2024-07-04 372 amdgpu_gfx_rlc_enter_safe_mode(adev, 0); 178ad0e280c088 Jiadong Zhu 2024-07-04 373 178ad0e280c088 Jiadong Zhu 2024-07-04 374 if (queue_type == AMDGPU_RING_TYPE_GFX) { 178ad0e280c088 Jiadong Zhu 2024-07-04 375 dev_info(adev->dev, "reset gfx queue (%d:%d:%d: vmid:%d)\n", 178ad0e280c088 Jiadong Zhu 2024-07-04 376 me_id, pipe_id, queue_id, vmid); 178ad0e280c088 Jiadong Zhu 2024-07-04 377 178ad0e280c088 Jiadong Zhu 2024-07-04 378 mutex_lock(&adev->gfx.reset_sem_mutex); 178ad0e280c088 Jiadong Zhu 2024-07-04 379 gfx_v11_0_request_gfx_index_mutex(adev, true); 178ad0e280c088 Jiadong Zhu 2024-07-04 380 /* all se allow writes */ 178ad0e280c088 Jiadong Zhu 2024-07-04 381 WREG32_SOC15(GC, 0, regGRBM_GFX_INDEX, 178ad0e280c088 Jiadong Zhu 2024-07-04 382 (uint32_t)(0x1 << GRBM_GFX_INDEX__SE_BROADCAST_WRITES__SHIFT)); 178ad0e280c088 Jiadong Zhu 2024-07-04 383 value = REG_SET_FIELD(0, CP_VMID_RESET, RESET_REQUEST, 1 << vmid); 178ad0e280c088 Jiadong Zhu 2024-07-04 384 if (pipe_id == 0) 178ad0e280c088 Jiadong Zhu 2024-07-04 385 value = REG_SET_FIELD(value, CP_VMID_RESET, PIPE0_QUEUES, 1 << queue_id); 178ad0e280c088 Jiadong Zhu 2024-07-04 386 else 178ad0e280c088 Jiadong Zhu 2024-07-04 387 value = REG_SET_FIELD(value, CP_VMID_RESET, PIPE1_QUEUES, 1 << queue_id); 178ad0e280c088 Jiadong Zhu 2024-07-04 388 WREG32_SOC15(GC, 0, regCP_VMID_RESET, value); 178ad0e280c088 Jiadong Zhu 2024-07-04 389 gfx_v11_0_request_gfx_index_mutex(adev, false); 178ad0e280c088 Jiadong Zhu 2024-07-04 390 mutex_unlock(&adev->gfx.reset_sem_mutex); 178ad0e280c088 Jiadong Zhu 2024-07-04 391 178ad0e280c088 Jiadong Zhu 2024-07-04 392 mutex_lock(&adev->srbm_mutex); 178ad0e280c088 Jiadong Zhu 2024-07-04 393 soc21_grbm_select(adev, me_id, pipe_id, queue_id, 0); 178ad0e280c088 Jiadong Zhu 2024-07-04 394 /* wait till dequeue take effects */ 178ad0e280c088 Jiadong Zhu 2024-07-04 395 for (i = 0; i < adev->usec_timeout; i++) { 178ad0e280c088 Jiadong Zhu 2024-07-04 396 if (!(RREG32_SOC15(GC, 0, regCP_GFX_HQD_ACTIVE) & 1)) 178ad0e280c088 Jiadong Zhu 2024-07-04 397 break; 178ad0e280c088 Jiadong Zhu 2024-07-04 398 udelay(1); 178ad0e280c088 Jiadong Zhu 2024-07-04 399 } 178ad0e280c088 Jiadong Zhu 2024-07-04 400 if (i >= adev->usec_timeout) { 178ad0e280c088 Jiadong Zhu 2024-07-04 401 dev_err(adev->dev, "failed to wait on gfx hqd deactivate\n"); 178ad0e280c088 Jiadong Zhu 2024-07-04 402 r = -ETIMEDOUT; 178ad0e280c088 Jiadong Zhu 2024-07-04 403 } 178ad0e280c088 Jiadong Zhu 2024-07-04 404 178ad0e280c088 Jiadong Zhu 2024-07-04 405 soc21_grbm_select(adev, 0, 0, 0, 0); 178ad0e280c088 Jiadong Zhu 2024-07-04 406 mutex_unlock(&adev->srbm_mutex); 178ad0e280c088 Jiadong Zhu 2024-07-04 407 } else if (queue_type == AMDGPU_RING_TYPE_COMPUTE) { 178ad0e280c088 Jiadong Zhu 2024-07-04 408 dev_info(adev->dev, "reset compute queue (%d:%d:%d)\n", 178ad0e280c088 Jiadong Zhu 2024-07-04 409 me_id, pipe_id, queue_id); 178ad0e280c088 Jiadong Zhu 2024-07-04 410 mutex_lock(&adev->srbm_mutex); 178ad0e280c088 Jiadong Zhu 2024-07-04 411 soc21_grbm_select(adev, me_id, pipe_id, queue_id, 0); 178ad0e280c088 Jiadong Zhu 2024-07-04 412 WREG32_SOC15(GC, 0, regCP_HQD_DEQUEUE_REQUEST, 0x2); 178ad0e280c088 Jiadong Zhu 2024-07-04 413 WREG32_SOC15(GC, 0, regSPI_COMPUTE_QUEUE_RESET, 0x1); 178ad0e280c088 Jiadong Zhu 2024-07-04 414 178ad0e280c088 Jiadong Zhu 2024-07-04 415 /* wait till dequeue take effects */ 178ad0e280c088 Jiadong Zhu 2024-07-04 @416 for (i = 0; i < adev->usec_timeout; i++) { 178ad0e280c088 Jiadong Zhu 2024-07-04 417 if (!(RREG32_SOC15(GC, 0, regCP_HQD_ACTIVE) & 1)) 178ad0e280c088 Jiadong Zhu 2024-07-04 418 break; 178ad0e280c088 Jiadong Zhu 2024-07-04 419 udelay(1); 178ad0e280c088 Jiadong Zhu 2024-07-04 420 } 178ad0e280c088 Jiadong Zhu 2024-07-04 421 if (i >= adev->usec_timeout) { 178ad0e280c088 Jiadong Zhu 2024-07-04 422 dev_err(adev->dev, "failed to wait on hqd deactivate\n"); 178ad0e280c088 Jiadong Zhu 2024-07-04 423 r = -ETIMEDOUT; 178ad0e280c088 Jiadong Zhu 2024-07-04 424 } 178ad0e280c088 Jiadong Zhu 2024-07-04 425 soc21_grbm_select(adev, 0, 0, 0, 0); 178ad0e280c088 Jiadong Zhu 2024-07-04 426 mutex_unlock(&adev->srbm_mutex); 178ad0e280c088 Jiadong Zhu 2024-07-04 427 } 178ad0e280c088 Jiadong Zhu 2024-07-04 428 178ad0e280c088 Jiadong Zhu 2024-07-04 429 amdgpu_gfx_rlc_exit_safe_mode(adev, 0); 178ad0e280c088 Jiadong Zhu 2024-07-04 430 return r; 178ad0e280c088 Jiadong Zhu 2024-07-04 431 } 178ad0e280c088 Jiadong Zhu 2024-07-04 432 :::::: The code at line 416 was first introduced by commit :::::: 178ad0e280c088f5abfa61793cb992fa120d1830 drm/amdgpu/mes11: implement mmio queue reset for gfx11 :::::: TO: Jiadong Zhu :::::: CC: Alex Deucher -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki