linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 9848/10296] fs/xfs/xfs_file.c:1286:undefined reference to `filemap_fsnotify_fault'
@ 2024-09-07  2:07 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-07  2:07 UTC (permalink / raw)
  To: Josef Bacik
  Cc: oe-kbuild-all, Linux Memory Management List, Jan Kara, Amir Goldstein

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9aaeb87ce1e966169a57f53a02ba05b30880ffb8
commit: 436df5326f579750c9a03b986e81132c4bab46f6 [9848/10296] xfs: add pre-content fsnotify hook for write faults
config: arm-randconfig-r031-20230101 (https://download.01.org/0day-ci/archive/20240907/202409071013.bbWWqWwI-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240907/202409071013.bbWWqWwI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409071013.bbWWqWwI-lkp@intel.com/

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: fs/xfs/xfs_file.o: in function `xfs_write_fault':
>> fs/xfs/xfs_file.c:1286:(.text+0xd5a): undefined reference to `filemap_fsnotify_fault'


vim +1286 fs/xfs/xfs_file.c

  1275	
  1276	static vm_fault_t
  1277	xfs_write_fault(
  1278		struct vm_fault		*vmf,
  1279		unsigned int		order)
  1280	{
  1281		struct inode		*inode = file_inode(vmf->vma->vm_file);
  1282		struct xfs_inode	*ip = XFS_I(inode);
  1283		unsigned int		lock_mode = XFS_MMAPLOCK_SHARED;
  1284		vm_fault_t		ret;
  1285	
> 1286		ret = filemap_fsnotify_fault(vmf);
  1287		if (unlikely(ret))
  1288			return ret;
  1289	
  1290		sb_start_pagefault(inode->i_sb);
  1291		file_update_time(vmf->vma->vm_file);
  1292	
  1293		/*
  1294		 * Normally we only need the shared mmaplock, but if a reflink remap is
  1295		 * in progress we take the exclusive lock to wait for the remap to
  1296		 * finish before taking a write fault.
  1297		 */
  1298		xfs_ilock(ip, XFS_MMAPLOCK_SHARED);
  1299		if (xfs_iflags_test(ip, XFS_IREMAPPING)) {
  1300			xfs_iunlock(ip, XFS_MMAPLOCK_SHARED);
  1301			xfs_ilock(ip, XFS_MMAPLOCK_EXCL);
  1302			lock_mode = XFS_MMAPLOCK_EXCL;
  1303		}
  1304	
  1305		if (IS_DAX(inode))
  1306			ret = xfs_dax_fault_locked(vmf, order, true);
  1307		else
  1308			ret = iomap_page_mkwrite(vmf, &xfs_page_mkwrite_iomap_ops);
  1309		xfs_iunlock(ip, lock_mode);
  1310	
  1311		sb_end_pagefault(inode->i_sb);
  1312		return ret;
  1313	}
  1314	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-09-07  2:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-07  2:07 [linux-next:master 9848/10296] fs/xfs/xfs_file.c:1286:undefined reference to `filemap_fsnotify_fault' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox