From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DB2E6FE2F for ; Fri, 6 Sep 2024 16:31:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C12C26B0083; Fri, 6 Sep 2024 12:31:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC11B6B0088; Fri, 6 Sep 2024 12:31:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB0006B008C; Fri, 6 Sep 2024 12:31:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D9206B0083 for ; Fri, 6 Sep 2024 12:31:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DB1C120BB5 for ; Fri, 6 Sep 2024 16:31:46 +0000 (UTC) X-FDA: 82534854612.11.95C7E26 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id 90F3212002B for ; Fri, 6 Sep 2024 16:31:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i+7JWFja; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725640224; a=rsa-sha256; cv=none; b=ZmsQO+Koi/mJ+ZKzjBDBRG59ZP3IlOozcnSesKAFPuE/uxwtLoQcJ0RbVATuVB3vcntTAb LqhX+aFtrv3E2RdZzXyntl3RZSvpmJ6zi0CPLWU3FmlHHb7Xl9k94m2mDHb4aVukyCz/xM fFVnLSeRiqN7dVwRb9ShJxWyYVUDPlM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i+7JWFja; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725640224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=zI+rPpinl9+b1MnykPqOQW0OImNY24p8U7dNXBGF5w8=; b=zTbdYQx2kAcHrjXxyUnP8r0ZAEsILKTxo0+Mso5IS+zsu9qBcP4f3TpdGCjOA4k7IrLxFu Zd2zqOf7lB2i1Un3oRey5AVGtbwGbrvT5wdAtDF2+cIOPkiI0hODYvt2a68kFGlADVBojn g2hFpfzh59lNAp1Z6KBjwgmscgacvVc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8C51FA4515D; Fri, 6 Sep 2024 16:31:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FF82C4CEC6; Fri, 6 Sep 2024 16:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725640303; bh=P42yeXkNnTmRaVvRlLuHDgj7xNa3QrbZEA882GWSS2o=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=i+7JWFjaAN3R9CBGzFdd2W6vVxQ3srhGcCZIyFR/Xb+pgzX8SsfRn/mLVLolb68Jv EZwkziMJgXvQ58fSMOnv5sFlVc6Jt4nZUxB9XTm/GyWGXVtrDcAgaKisH2qoUekd3j OFeWCYFD2zOn53NzR+8MTMb+Jmh5/Uxp+tbto3s/uYB+K5ape/tiNKz47La3njq1xo a1cPe2RYAqh6GR6EUq5fC6Hzj7SmyIFJp7+JjwzecAgjj9t4OasIZqP0oWJe/zSNLX JFrLg/hHPQLAqwiJqu1ufdZDMYHJBsBaj6O5LSSh1MvYMyhmx8BPjs6BecDE2ZtbI2 R4zQ9cfNiCcqQ== From: SeongJae Park To: Anna-Maria Behnsen Cc: SeongJae Park , Frederic Weisbecker , Thomas Gleixner , Jonathan Corbet , linux-kernel@vger.kernel.org, Len Brown , "Rafael J. Wysocki" , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 08/15] mm/damon/core: Use generic upper bound recommondation for usleep_range() Date: Fri, 6 Sep 2024 09:31:41 -0700 Message-Id: <20240906163141.31088-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240904-devel-anna-maria-b4-timers-flseep-v1-8-e98760256370@linutronix.de> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 90F3212002B X-Stat-Signature: bjh17wtxj398qdfdwfcu6sydwe7saf7s X-Rspam-User: X-HE-Tag: 1725640304-138754 X-HE-Meta: U2FsdGVkX18s05IGSqSQAkVj7a9UCE3T965OOZC4IsVLwk+PfmgBd3KptlWD7Mp/aSlW9e6PMGJikOgjEPxlEbGlgnxyn7JCVHmC5hEcQ6aWE9wwozyRMRuNXE0hY/ZDz7yhFukVnpq9fvLDSRrQ4pg9lNYaBWTnP0f5pCXmB8aP9IAqE+8mRdvavKKH5J/NIzzKtFtwj+N87N6ugXB0V7TS1Z8+uaCHscVTklFgl7ISPICDb/v5b41VgHB1x4v7LjNVoFjxMF1dsvk3NlrvQ2nfEn87c8e1dsF53NyUtJZ2N/nHpe+1j2M0ltMBCHe/iSKU0mdNfRmREadnWi7K8p0fT/3mJfPSscmpskhUrxp3Ds9erPJDWF+d/GZdVgLKoxiDL3FMObRnnUl0Z3gcWtcOghl3U4rEYjALk6mR2JwGjwikAalVPCIrCTBXZAEMb1+00zbi5GpvevcN2LjfPHgcbIs2/XdVQMBfvOUaKOMKxzhJE4X1sXd/k79o0ishWDzpgWqFiAV9AhDqetMCrXWdfRYVYqzI9CqsVrYY2LjDeI2JCc66cXaMeM5plq5XMTjYcy9GJQs69BC0h8OR+y+3LJCFZ96dwaid/wz4rt5B0Nb9+By9GrgVaL7157YZJrehAOhoMEwKVKGqUlfT8DT11YZsR9ZWtDciIZ92EQiunhTmSTb1I9yvtJHyzxGtpoPR8vbqfvn8J7OQ43qM6JG7biqDJDf2HUKO7chm/8+i16A9RxRrRJHbn4/aihslqSDEBaKiicdzHWeGXG2gvRHKVPfygjhcnEGAiLxj2ytFK5sA2YiRTA1HrdYhE40ho7FQDIj4kwZVz+KE26HQw4wtzw+lwDEYc3S+HH389fOIQQyHbFW24SC9DEoKjNnW3Xs9bYhLdw8lEujv4tU6LfWm5jHGHUXU8WG9R8HTRu7amYu063fjWL6QUN1lihh5ztUd8sPhs0WnM8lBAA3 2k6Dezn4 UpGTOLqxnupGu/YVmY6+Q/0Vq5XgNWUJYx03XqsEuY3grOVH+J1ktf4n+rM9UviAhCBtUHerMQ2NJFn0sO/0vfDghbXKOJSOJegS/t1fPRyKM3PIX0vZY6SbEjPMVyNvrg3hsXpK8PpIkoLoTur/B6Kh7syNJIs4JX3T1tUTfOcwg7bM5LpRkkerABclPgBgq1zvZ3KpLrgszaY/4xh6nooFcVYbmbKoaUxEZrVbmByqaT+EaEGBBvMD70W362GDQRnzBqs1BjXAwHRj35q6T/XYOHN6ecqLrxWFRUoP7fGtTNPJ9ED5Ohaa5cvcCUMVB/58QuHdQXfruwOm1KKe01FKkVR1DdOuUDSrtbKvSPFXRQfM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 04 Sep 2024 15:04:58 +0200 Anna-Maria Behnsen wrote: > The upper bound for usleep_range_idle() was taken from the outdated > documentation. As a recommondation for the upper bound of usleep_range() > depends on HZ configuration it is not possible to hard code it. > > Use the define "USLEEP_RANGE_UPPER_BOUND" instead. > > Cc: SeongJae Park > Cc: Andrew Morton > Cc: damon@lists.linux.dev > Cc: linux-mm@kvack.org > Signed-off-by: Anna-Maria Behnsen Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 94fe2f1f9b0e..4b971871da75 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1883,8 +1883,7 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme) > > static void kdamond_usleep(unsigned long usecs) > { > - /* See Documentation/timers/timers-howto.rst for the thresholds */ > - if (usecs > 20 * USEC_PER_MSEC) > + if (usecs >= USLEEP_RANGE_UPPER_BOUND) > schedule_timeout_idle(usecs_to_jiffies(usecs)); > else > usleep_range_idle(usecs, usecs + 1); > > -- > 2.39.2 > >