From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D75CD5BB8 for ; Thu, 5 Sep 2024 19:31:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7C56B0083; Thu, 5 Sep 2024 15:31:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 998626B008C; Thu, 5 Sep 2024 15:31:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8600D6B0092; Thu, 5 Sep 2024 15:31:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 683296B0083 for ; Thu, 5 Sep 2024 15:31:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 09A841C4D0F for ; Thu, 5 Sep 2024 19:31:02 +0000 (UTC) X-FDA: 82531677564.23.4BDE141 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) by imf20.hostedemail.com (Postfix) with ESMTP id 1F4081C0002 for ; Thu, 5 Sep 2024 19:30:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b="zKu/H4dJ"; spf=none (imf20.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.161.42) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725564563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XWzsnrKOmtVghAOq6+Gelxt9/1OrdoNtOgO3/1pVemw=; b=x4lNELXFxK8icSFZ9JEfinAbjJDe6PbO8TML9z2YUfgRlYLyfm0wDW8a9WY9JVkDs2RvQV pwFTZELeCRLMjJAYuPAeE9blYbH/ubT+CtLh00GF48D1+VSjX/N7D83qgzOa7+Q81utM0a IbJysBE3dxPfKkXYEiPRFTnnYkvxllI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725564563; a=rsa-sha256; cv=none; b=D2bSpJ+kDgdoj6AXDqc3k5asjb11Q0ggvglxD2rJSLSGqad91mZQuci0SKSujoPPrs4FUS ayT2lwKJ6y7fIZJyRmDKAlBdV4PiiA77AtHeuuWA3tuXi1eEHRWhOsePDsFRbscg/SIRpZ Dr0buUVMMWpD41lSBblBzofw9kNQDxE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b="zKu/H4dJ"; spf=none (imf20.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.161.42) smtp.mailfrom=josef@toxicpanda.com; dmarc=none Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5df9542f3d8so790110eaf.0 for ; Thu, 05 Sep 2024 12:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1725564659; x=1726169459; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XWzsnrKOmtVghAOq6+Gelxt9/1OrdoNtOgO3/1pVemw=; b=zKu/H4dJlkRB8/RnRZW5WjFZg/uM4DeBzD4rA6eLogMv2f1B1dP6MFldoRz++ytWie 74pdiE24DIb6lQG8qpGU08TK69SVBYqbSdPeHhG0k0cNoxLzpUUkm2MD1z7RxezusVEW gAKUCRlzpWF9ucBqV1GPupGGUW/wIcSVyrTwgOxGEBNYGLZWS1gIelytGRzdC52rt9Jg 9rUgAeBuVEWazhiX+GBGsI42ncR8JlXZ/urQNsCnPV8MwHfVoGv+E2O+EjKaCn8tAGqX Xjicfkwm2oM8CEQttJ8ct2l8MbBGQUmJGYTj4y8G707TeGV+fEZg08zlNwEBfzpaTf6T vS/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725564659; x=1726169459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XWzsnrKOmtVghAOq6+Gelxt9/1OrdoNtOgO3/1pVemw=; b=eIM19OmDavEKsRCm1ESIQnGXCof7P+FWQhJMs9bgmsYZnL5Za3pp6b23w3ftzjRebU hqUUQTJ3GpFepgy1DXezbXt29x2mAOi8KUCEP2ZWlU426T5vR1AgBhMOudrXNZteGl7y kOEY0lrYuQE31+2fHxEFKh6zUrErUSf2O26I8dC/ds7rMzOJKBMyjJr8dkGdW6tBWPT6 LYs/0me7jz2LW1iaoplpjVnxTaXG6GUphSpxM0zl0Ms6QEH5pfn0BoQj6xuSQpvScqN2 4Un3DGGsVy/feaUbMaScG0/K1fiTALnhsoPnNPCstYdF5aK5c7SUf3Xk4czJse+tkz+5 0Okg== X-Forwarded-Encrypted: i=1; AJvYcCVFXsZ/j1LFS+p9ftl/uswAalXWqSy1LelwsWEEKesduChPDlvSg/908eGLJBzFAjvIFcl8FaVrFw==@kvack.org X-Gm-Message-State: AOJu0YxARhwJ5r9xj1N71gUGITw5Zfk8l4dLpBv6+qwWV6pfIlC1kkZt YIcXVUlEBoYIFJRIxGoR2mNBYxomOCwIOgZcRS4Brqa+f05HF3UvRrss+AHKnnY= X-Google-Smtp-Source: AGHT+IFXdd+03g78Al1lMAeKqgNUOu/nJpHoXFDkr25DBgvdfGzY+Xz0bdnePSiuP1u3rPhxKsaK6A== X-Received: by 2002:a05:6870:6111:b0:277:f301:40ce with SMTP id 586e51a60fabf-27b82e6745bmr338204fac.20.1725564659009; Thu, 05 Sep 2024 12:30:59 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a98efeb945sm100782485a.98.2024.09.05.12.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 12:30:58 -0700 (PDT) Date: Thu, 5 Sep 2024 15:30:57 -0400 From: Josef Bacik To: Amir Goldstein Cc: jack@suse.cz, kernel-team@fb.com, linux-fsdevel@vger.kernel.org, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 00/18] fanotify: add pre-content hooks Message-ID: <20240905193057.GB3710628@perftesting> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 1F4081C0002 X-Stat-Signature: 8qwu4ab5ouiian7ordrgntpc7khq4tcb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725564659-498375 X-HE-Meta: U2FsdGVkX19fW/8mTvHsQHryLtYIdiqObsX6CyE1CCfqpCJZiX2rY8ZSFEPi962uQBDJU60Hn1C/3woHWlDX3JdR8FBqDS+WhuU0D5HIwoFq9W+Sx7d/MPJt4XuEd4RnYz736h03J9MipO0g4R+Axfv/MzhBOSyNZMG0EMcMkR4UDl6xlY5bjJNg4+HwYrN3nw49HmLkO3CC7hOySzfTAoFMoB9DdmzwOlu+We7lSVI9AvXmjqtIZVKmbGBK1q+YaTMeBVV1MmaJX5hh9VxBpjFm8FUHqfmqGl+xHGX6t4O0YZhX1r4+nMDPSGNSpEWcfE+dh6Tz4Ec2MjGB9Sqvi6j9YeAfQyiITaX6C0kq7/3wN0Ipq/FcMRSRoPe42dPLncHfXMoPYWcVj9sji9fIdo3ubC2Y2dDoYlhqP7hNQ3v+HA9/BVYhZi7CHwDoO/8GZRKukNsapZCaTSzT7nSIba6bplYSdbhPDQ5m6f3Ehp28tswzHQKS+6TfB37APssm23qgR0e0mOG7QTWZhGNDoG/NZHEwmCwpSOaX1AKz2VyM90Tuoox/YylRJfzyC5PJStQheqQgeDMJEncdtPPXL4+4vyz0HIjOl0oSJ++wV3XPVxIe4CKhUE1Zx9Hz4G+HIqFXDpdCe38PUETcP3tqbnZe1FQoF0gpZi5PYQvw0Emx2aFu76Q2YYos/t38XlRbpiat6pB5ehZOWoqbvX0maxik4XX0PnZGFUCw9EFvpmk3f9Rmi84v1wTSzE/BTxXF22zLTNMWg7reYqC3CSo/5bveAADLmAYBVeEkloHWVklFPvVr5bWXhLoKW6pynU/dSyI0G/TuQtqmU3qgaitEHJwESBbPn+ztLF7msZGculP/BoP499IR3feMZB0Ll6fHrQoR2d7BahMY+dsZW5DNY2qzkrigmvEo20Dc8eKOsQh9KUrWe/601JTIG2y1nXHxroCV1TDk6yRr3jwxcHE dMPBzCwL mT63GYcD/ZTo5vkqRVZ3sEsUmvAYCtjAuVrb5VOaYaDzUsqvC1FhqQH9koVEZxKsLX8rUjyHazx8WxJUeytKCug5+q+WQ6qpk08M1EntiGHviIfvgjAOPm24l/U0j98BE43S7cfM7xV7e9Qi51mUyZwn2HNSXufAgOUz/IjgzkqsYvSjZ8Kf1DSor5OpJeFiolW+FYGPLVMHgA7jzeiBNbHjHXnLdtfxhnJh1CSh/i+MG2Y28IeAaKhFdLRVriILn9I6own/A73m6AgWIONOHyVBPV0snlj3SH4DeX21lXs1SM5ZIHb+e8+iX/l+Ui5XsRqABUkc/rC+1HjLp+tIUbNE0pUGLIlgDkre4Unqffaavw36CgZUPe6PduJFScxq+x5fmsxSwGk3NYpLC95YcePScmJMECdXkAHMLxeAC2b70G0sDm+g6ojDuR0QADeGhD6dH8GV3E34nWNg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.350946, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 10:33:07AM +0200, Amir Goldstein wrote: > On Wed, Sep 4, 2024 at 10:29 PM Josef Bacik wrote: > > > > v4: https://lore.kernel.org/linux-fsdevel/cover.1723670362.git.josef@toxicpanda.com/ > > v3: https://lore.kernel.org/linux-fsdevel/cover.1723228772.git.josef@toxicpanda.com/ > > v2: https://lore.kernel.org/linux-fsdevel/cover.1723144881.git.josef@toxicpanda.com/ > > v1: https://lore.kernel.org/linux-fsdevel/cover.1721931241.git.josef@toxicpanda.com/ > > > > v4->v5: > > - Cleaned up the various "I'll fix it on commit" notes that Jan made since I had > > to respin the series anyway. > > - Renamed the filemap pagefault helper for fsnotify per Christians suggestion. > > - Added a FS_ALLOW_HSM flag per Jan's comments, based on Amir's rough sketch. > > - Added a patch to disable btrfs defrag on pre-content watched files. > > - Added a patch to turn on FS_ALLOW_HSM for all the file systems that I tested. > > My only nits are about different ordering of the FS_ALLOW_HSM patches > I guess as the merge window is closing in, Jan could do these trivial > reorders on commit, based on his preference (?). > > > - Added two fstests (which will be posted separately) to validate everything, > > re-validated the series with btrfs, xfs, ext4, and bcachefs to make sure I > > didn't break anything. > > Very cool! > > Thanks again for the "productization" of my patches :) Thanks for doing all the heavy lifting in the first place! Glad we can move on to other things from here, Josef