From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A94CE7A9F for ; Thu, 5 Sep 2024 21:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228536B0085; Thu, 5 Sep 2024 17:22:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D88E6B008C; Thu, 5 Sep 2024 17:22:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C7346B0093; Thu, 5 Sep 2024 17:22:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E4C0E6B0085 for ; Thu, 5 Sep 2024 17:22:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 573DEA9110 for ; Thu, 5 Sep 2024 21:22:24 +0000 (UTC) X-FDA: 82531958208.30.DFC77C5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 919D9C001E for ; Thu, 5 Sep 2024 21:22:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yu75ecSn; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725571246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G43ZblqcIap/xJ+WWfqe9db4PuxMc92l9YOF3tpzXX8=; b=4JaQEVeDv8FOFJ1E5YIYm+3Vy0WxSvOORcRe9+CNprYDK8WPAAdp90d6P+EtlRKiriRjKU Szo6zmIdhD9+MD4wWuiQ2sZmlyadneE2JRRvpkbT8OeuBkihIr8eLwFcrjk/WzMW6OB52K KeLacJBIHQNlFstgvU1mUF13goxB3Qo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725571246; a=rsa-sha256; cv=none; b=vqI2gSYyaltsBTAucPeJphd+kLMucN0ehVSw4PfDIbYm6j+5xUh0Kk+eCzFOwq6NcZ/s6U NDhK5f7WtgnWbODce2Gs469ntnZ2Fx5iYvp+CgtOOQg0n4AVYV2YKIoRYodwF7g3zBoYJ8 2IXwrqb6IPaykkhUZbdBUcYl0U/pVm8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yu75ecSn; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 218825C58AE; Thu, 5 Sep 2024 21:22:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB5D6C4CEC3; Thu, 5 Sep 2024 21:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725571341; bh=35+rbCTS0v4jRIIZob1qp95Mxqaaa5dUxQDMzEaSLO4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yu75ecSn8OPOSeRomyMimNPAqqR2n92JVElp0CvhV5p7QsEJT+t2CHpcJFWFsfsFR yLY+AzhiKv6UD83cp7bo68IFNV8MEQEVBY/ECOgNpfj3d+fC+7cMtyx/HdGzpp9a9X PIOlZYJRqUpNROZCg/p/Npk5/+oOOyUZb1GqGnN4= Date: Thu, 5 Sep 2024 14:22:20 -0700 From: Andrew Morton To: Andy Shevchenko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] mm/page_alloc: Mark has_unaccepted_memory() with __maybe_unused Message-Id: <20240905142220.49d93337a0abce5690e515d9@linux-foundation.org> In-Reply-To: <20240905171553.275054-1-andriy.shevchenko@linux.intel.com> References: <20240905171553.275054-1-andriy.shevchenko@linux.intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 919D9C001E X-Stat-Signature: 837fs1z1aokodrhekuiegksei7ko677r X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725571342-714732 X-HE-Meta: U2FsdGVkX186YkaUZfzn02VIR6DEp2w9rxCUakGrSgi5idnKIhuWbXKEPqE/MSpM4DjTUnTcRmaGsmFEtn1UVEcbnFNUsK1gayLP34KK97XfQw1lcbWJL3z7+rgioRiU+gR0vPTvFUlg0YoQTmYUaGwowcnlKgBYwT3TZ9nLXJK2ArYLweA5zxQ0We6Ds8yLIcKO2LmEF+kYyKa3+OeZUl9AKirB+IQodqMjJdbzloIXDwDBv50w54KNplQhEnZfMq6ETjy/KAyVyzhjJRmBlDAMXJSUnFLEDy+f6oJHHUzuWJLg4FfzUhrHha35gClBUqtX+4RqEHtVaz0OaLc66R450FOU0l9/4ZZXsoB+Tf5KCtuNMqg+1mLOkc1L4y2l1izCg8enptVivmf0Y94toJCwt6Uw8j6pdMbghBjMFg/ejktC1DbzEjal+kjwrplGxuKWR10hYtm07yjD+O4qqt91KWXwddGSyLIF0nis6XOnJQlW4c/Hrw6P6kcr+qxrUxwvVHn6Lc0Fz3LzmGHlV5b8DLeMVGK/hdf8/Orca5U+WfflOFtrjR8HeXLyrD5RBG+izKSjGNzHlsbGOWF6XLtq+G4vQv22Xh+egpK1VL7zzho1FqpPSzDAGnJZYA33N9NMaQQzTxf5OPMcNLcHDQiQgA2yx8VNKbMoBN8i5yaJx679vIKAaUcefgj9uFV9ikSq3rvI7C8ckopGPsgmngPIYfL+mNoCtYrD5a2o3nznSUWaVtOnEKsfJ0RXMApxDXaj/QqRR1qfN0o3jUl9BuKsPWumUdFJMSLxIFLkHES5EChlesvoOYBJcdEHLPWFTlPbXM3oWMSNh3dNEyBYNfxT2rKhCFBpERryPMShIKCt7xlU/zErx+q4GtkDkx2ukeAKSks6Y1kykfCGwPqxKC8szGK64kki0J4UP305s808HroPtEIcR9SYLGqxMPFM38yYcOmnUDoRl+W/Wo1 yzBlw6F5 gsjnN/at97mDGcV9l0eptsmMxjHnjtWcLtmHD8pDKfMJOf1A4UTbBEzjs8++uXPL35PHggdzlyj43Hg1mzSpEkq/R0NnF1cTEEQRS7FpJfRBMjltqRjtAkn8PRJfuJ/UHY/D3wWG9vGhfuuJa3MoTYKeXdG8N6kazsTNiT2/uTdZJD2SKAjIo1KbYg+LLs186fYVSEpwi14Sogl/BtLjapuzeS2zSaZDFpzSZkxa7Z8rPnTvXunIA99+lQ+wmfAwEL0kVuC/j0b/JBic1NRmPzQ1EV8KR5oQSGYxUdssYWg0vkSNFG+gdlJtOgFb6xgChht25 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 5 Sep 2024 20:15:53 +0300 Andy Shevchenko wrote: > When has_unaccepted_memory() is unused, it prevents kernel builds > with clang, `make W=1` and CONFIG_WERROR=y: > > mm/page_alloc.c:7036:20: error: unused function 'has_unaccepted_memory' [-Werror,-Wunused-function] > 7036 | static inline bool has_unaccepted_memory(void) > | ^~~~~~~~~~~~~~~~~~~~~ > > Fix this by marking it with __maybe_unused (all cases for the sake of > symmetry). > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for W=1 build"). > has_unaccepted_memory() has no callers if CONFIG_UNACCEPTED_MEMORY=n. Can't we do this better thing? --- a/mm/page_alloc.c~a +++ a/mm/page_alloc.c @@ -288,7 +288,6 @@ EXPORT_SYMBOL(nr_online_nodes); static bool page_contains_unaccepted(struct page *page, unsigned int order); static void accept_page(struct page *page, unsigned int order); static bool cond_accept_memory(struct zone *zone, unsigned int order); -static inline bool has_unaccepted_memory(void); static bool __free_unaccepted(struct page *page); int page_group_by_mobility_disabled __read_mostly; @@ -6963,6 +6962,11 @@ static bool try_to_accept_memory_one(str return true; } +static inline bool has_unaccepted_memory(void) +{ + return static_branch_unlikely(&zones_with_unaccepted_pages); +} + static bool cond_accept_memory(struct zone *zone, unsigned int order) { long to_accept; @@ -6990,11 +6994,6 @@ static bool cond_accept_memory(struct zo return ret; } -static inline bool has_unaccepted_memory(void) -{ - return static_branch_unlikely(&zones_with_unaccepted_pages); -} - static bool __free_unaccepted(struct page *page) { struct zone *zone = page_zone(page); @@ -7032,11 +7031,6 @@ static bool cond_accept_memory(struct zo { return false; } - -static inline bool has_unaccepted_memory(void) -{ - return false; -} static bool __free_unaccepted(struct page *page) { _