From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5290ECD5BA6 for ; Thu, 5 Sep 2024 10:36:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCF716B00E2; Thu, 5 Sep 2024 06:36:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D166B00EC; Thu, 5 Sep 2024 06:36:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1EFA6B00E8; Thu, 5 Sep 2024 06:36:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A4E906B0471 for ; Thu, 5 Sep 2024 06:36:41 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2842A1A0AD4 for ; Thu, 5 Sep 2024 10:36:41 +0000 (UTC) X-FDA: 82530331002.14.E9AB15A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id DE0ED8001D for ; Thu, 5 Sep 2024 10:36:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Zagojlb0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7FfrRaLJ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Zagojlb0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7FfrRaLJ; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725532501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RrQ0eAQTSx7Dllj1ZbCTVu1ER+Z69NqSE9+1bil57/I=; b=QWVvSNm1qwf5IB16U1mu3/Yks205cxPaCpu2ZkuKkYP/lZZpPd+x/VbLda/B40R/uJ4FJc Etb/w0W1Ma1LerVl6kyfL25gekfPchat252zaE5syOHs5UTgqpEPPCAoNivObxAwyNbIJo L8xu1slqNaZy+RuNBfPSyiascR2F4DI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725532501; a=rsa-sha256; cv=none; b=6khSwlJ46+GOyt9pup3YlwkXkir/lRXPU9Ah5/K8bgCaYvWGx0s6YSsrOoxI0PWdk5DvPE OtvRPEZNr58o0mxeIGAs9xRapFFp5br40rAzlRjaH37bQAEA+9a8Rj3ovU0OMsOMaPxdyH YDd0iwHdXnNC+qWrSmNJEfHYaaW07qk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Zagojlb0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7FfrRaLJ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Zagojlb0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7FfrRaLJ; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5EE991F811; Thu, 5 Sep 2024 10:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725532597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrQ0eAQTSx7Dllj1ZbCTVu1ER+Z69NqSE9+1bil57/I=; b=Zagojlb0zmOSGJriBxxrS+96q1e3kE+rv1+FU1j/ouhm7jOrCVpFUuQ5FSU22TBKSwqWwY CTtrysg/NWbIEMCAFu+Qw6Scdpi+6HPf5TZzgdILHFryKMMUb917dN/hm9sJDMxSZFbrdz S98FAUW9qnD7l7i5NG5OLJDcN1CQLcI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725532597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrQ0eAQTSx7Dllj1ZbCTVu1ER+Z69NqSE9+1bil57/I=; b=7FfrRaLJZuzdNayTP8lgi8DRLk7W+0tiG8Qlohu3IhqEgNYN/VDaiX7PhcGP92rJByJUMl 0HwJKuZIo39LfiAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725532597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrQ0eAQTSx7Dllj1ZbCTVu1ER+Z69NqSE9+1bil57/I=; b=Zagojlb0zmOSGJriBxxrS+96q1e3kE+rv1+FU1j/ouhm7jOrCVpFUuQ5FSU22TBKSwqWwY CTtrysg/NWbIEMCAFu+Qw6Scdpi+6HPf5TZzgdILHFryKMMUb917dN/hm9sJDMxSZFbrdz S98FAUW9qnD7l7i5NG5OLJDcN1CQLcI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725532597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrQ0eAQTSx7Dllj1ZbCTVu1ER+Z69NqSE9+1bil57/I=; b=7FfrRaLJZuzdNayTP8lgi8DRLk7W+0tiG8Qlohu3IhqEgNYN/VDaiX7PhcGP92rJByJUMl 0HwJKuZIo39LfiAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 521DE139D2; Thu, 5 Sep 2024 10:36:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +bEJFLWJ2WbHTgAAD6G6ig (envelope-from ); Thu, 05 Sep 2024 10:36:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 05F53A0968; Thu, 5 Sep 2024 12:36:21 +0200 (CEST) Date: Thu, 5 Sep 2024 12:36:21 +0200 From: Jan Kara To: Amir Goldstein Cc: Josef Bacik , jack@suse.cz, kernel-team@fb.com, linux-fsdevel@vger.kernel.org, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 18/18] fs: enable pre-content events on supported file systems Message-ID: <20240905103621.abnoeibagmxyu5pp@quack3> References: <33151057684a62a89b45466d53671c6232c34a68.1725481503.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: d8ixfx5ycthqnedzn9fsztfi1xz14bgi X-Rspamd-Queue-Id: DE0ED8001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725532598-968550 X-HE-Meta: U2FsdGVkX1+P6opNe4nKSlVinwzJIvdRNAzsjSTxknYXeTDB2WPmNj9enIAHlbj59Dbf6Ng+Jx+RrVr+QJC/I5Dzs0CrCIPZDA7Ia7Q+TyanjayWcz8dcIqzPF9oJey/4G61rygHLFR8vpm4Kn9QUymE9bv6gUpMTca6yy9o2u21Azp7GHwD+Mkkwz2j6eP8qjBNue5wrOrUhMD3790a0pAQCBzE7ON6KmK+SZ1Pj2mDqRjv2RB0NzO9Fnex/MZO5gk+Xj6NMaidwlZxCagliwXCmnDW3frp0Q9yfg+OIMeyu8F9tDv3USYCxBmncVNwbclFI7E5fOkEboH3J0GWv0OLfzNe78fnfilKddLnRWK76Kz6c4qMjbgxBL3s7ZsHSoo18F089jnpClqn+oOsyirQxN5JruNJzpT6Xe5/7k8bL4kBxcybYw2yKG1w3ZorVo0j+n4YwRPj/XDIDFgVUsqf38S+pymjpPSXizq1hPohr0sRZMgNd2XcyPsTL3NzlymaFqDl0bvOJc1Mp+e3q9+2s2DB7DLQO/M07X0puQ1rKW10mzwsUPfzN8EKB97+We/kkdn9ssZHr5DbcJhorA7BMCfdmzco/h6VKulAMa7j7K5zjt8ZraRdxhxsUe90WVHPUXDnyOJMAhIEkIc2QgwjFrxh9LoiFk9dunkl1CW33bCGc/rW/nVGkeJf3MztUWOAIsuEmGAiz2glnW8Lm/ImS+Thzy5TFE3OMhj1PP8rjJbPEV+Jx3TUxXAFy59k4AKhaI+7ZjtTv41HBnRQXZom3x8sCsdVkmrAqOnKgcrLEGNf4basBt/7WXYdVFV7BhdsyGUj+7lUrq3mU8Y2FU1/vdWzoIIbwYqDjCKnuAPQAnCTPzw8Ntos3IOMIw35wW1xyly+yIcBT7zcZi4uvOzkkFjEoOk7RwilLvy/OhN+dPoW8gN6QHBAWZOxvKr04SvbryRLMOdAynFzZ2J Nqe/sj0Y eu4jUDfWZ7dcyBtqpDueLf57tNSinVJ8ORnegAQqW2HPa0Ry+V7OGwF9tci8DS4eoJGHVfYGcDN9Q6qGhNkjC1OnjAD6/dkXn5r3862HJM8/GCx7j+JdAQ2ZqjK6qB6b5ZrKYf8VEm6piENXZHXmXnD/cGKI3uO1k4q21P0KMz6MktCMoJ21lsKoHkwNC22geQFUi33NJQ7KNU5G6tBcVNTikoTBtDNrkeQTrRjGwhaMLl2veNa0AuHhkKi2yNa13AZd6+P3zL5SmUZ7h49WwveCr13W9GoLC+IlD1fB1ylc2cWOHCNFvM92D99VWUV+O5tDP3DFf45va7idTAruQCGL5YPdSlc/fQ4gfVPAwOhXMCDUxZrQaLMpLflaSAALbzjPW9Fi13IQ3FQj/GZzhYbapnZGDcCUXcAC1aC7TqAVEygs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 05-09-24 10:27:52, Amir Goldstein wrote: > On Wed, Sep 4, 2024 at 10:29 PM Josef Bacik wrote: > > > > Now that all the code has been added for pre-content events, and the > > various file systems that need the page fault hooks for fsnotify have > > been updated, add FS_ALLOW_HSM to the currently tested file systems. > > > > Signed-off-by: Josef Bacik > > I would not be devastated if this patch remains as is, > but I think it would be nicer to: > 1. Move it before the fs specific patches > 2. Set the HSM flag only on ext* > 3. Add the HSM flag in other fs specific patches I agree that doing this inside the patch where we tweak its functions to properly support HSM would be more natural. And then only ext4 will remain here. I guess I'll do this on commit. Honza > > Thanks, > Amir. > > > --- > > fs/bcachefs/fs.c | 2 +- > > fs/btrfs/super.c | 3 ++- > > fs/ext4/super.c | 6 +++--- > > fs/xfs/xfs_super.c | 2 +- > > 4 files changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c > > index 3a5f49affa0a..f889a105643b 100644 > > --- a/fs/bcachefs/fs.c > > +++ b/fs/bcachefs/fs.c > > @@ -2124,7 +2124,7 @@ static struct file_system_type bcache_fs_type = { > > .name = "bcachefs", > > .init_fs_context = bch2_init_fs_context, > > .kill_sb = bch2_kill_sb, > > - .fs_flags = FS_REQUIRES_DEV, > > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_HSM, > > }; > > > > MODULE_ALIAS_FS("bcachefs"); > > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > > index 0eda8c21d861..201ed90a6083 100644 > > --- a/fs/btrfs/super.c > > +++ b/fs/btrfs/super.c > > @@ -2193,7 +2193,8 @@ static struct file_system_type btrfs_fs_type = { > > .init_fs_context = btrfs_init_fs_context, > > .parameters = btrfs_fs_parameters, > > .kill_sb = btrfs_kill_super, > > - .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | FS_ALLOW_IDMAP, > > + .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | > > + FS_ALLOW_IDMAP | FS_ALLOW_HSM, > > }; > > > > MODULE_ALIAS_FS("btrfs"); > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > > index e72145c4ae5a..a042216fb370 100644 > > --- a/fs/ext4/super.c > > +++ b/fs/ext4/super.c > > @@ -137,7 +137,7 @@ static struct file_system_type ext2_fs_type = { > > .init_fs_context = ext4_init_fs_context, > > .parameters = ext4_param_specs, > > .kill_sb = ext4_kill_sb, > > - .fs_flags = FS_REQUIRES_DEV, > > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_HSM, > > }; > > MODULE_ALIAS_FS("ext2"); > > MODULE_ALIAS("ext2"); > > @@ -153,7 +153,7 @@ static struct file_system_type ext3_fs_type = { > > .init_fs_context = ext4_init_fs_context, > > .parameters = ext4_param_specs, > > .kill_sb = ext4_kill_sb, > > - .fs_flags = FS_REQUIRES_DEV, > > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_HSM, > > }; > > MODULE_ALIAS_FS("ext3"); > > MODULE_ALIAS("ext3"); > > @@ -7298,7 +7298,7 @@ static struct file_system_type ext4_fs_type = { > > .init_fs_context = ext4_init_fs_context, > > .parameters = ext4_param_specs, > > .kill_sb = ext4_kill_sb, > > - .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS_ALLOW_HSM, > > }; > > MODULE_ALIAS_FS("ext4"); > > > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index 27e9f749c4c7..04a6ec7bc2ae 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -2052,7 +2052,7 @@ static struct file_system_type xfs_fs_type = { > > .init_fs_context = xfs_init_fs_context, > > .parameters = xfs_fs_parameters, > > .kill_sb = xfs_kill_sb, > > - .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS_ALLOW_HSM, > > }; > > MODULE_ALIAS_FS("xfs"); > > > > -- > > 2.43.0 > > -- Jan Kara SUSE Labs, CR