From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39DACD4F4E for ; Thu, 5 Sep 2024 01:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B4186B0140; Wed, 4 Sep 2024 21:15:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 664DA6B0141; Wed, 4 Sep 2024 21:15:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52AE26B0142; Wed, 4 Sep 2024 21:15:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 322AE6B0140 for ; Wed, 4 Sep 2024 21:15:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D88E4C06F6 for ; Thu, 5 Sep 2024 01:15:46 +0000 (UTC) X-FDA: 82528917492.18.50826A2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id 291141C001D for ; Thu, 5 Sep 2024 01:15:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FM7LPDXG; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725498848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I0fJBspiT2ofXoPeXKdkCUe+AI4J+JN0uw9kK20aqSM=; b=VQZSJTkGz/PR2Ebtbrfa3np/I4TPXJBkyYzTgsYZQNv21jCPn1lkITPu0eIC9Crn+zJ1Be qyBv9e8CqsXlX2jL3M5uCVWEN/MZ9/CWKxUgyzT3qwZ6lIdHWtssWxjacKAGTn061/Y/co +rPN3x/G51iDfcZNOnALmngP/KT305w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725498848; a=rsa-sha256; cv=none; b=iU/qgFA/KVxzYYqOzoWyeHi5QPq7cmM+RKbmLmTJNz7uyA/b8SZbT5oNBMHYpnfqgTt9zU QEi+lOgPgZ2onLEjd6bsRR+wMlEOlNwiBGcN/7+b+CBG8Lk2o6AFDzRikFpQj5NTSi3Hxk wyLMs50rRKDFGSB7wCU6p9fF6Q+RZpI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FM7LPDXG; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2F570A40854; Thu, 5 Sep 2024 01:15:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD508C4CEC2; Thu, 5 Sep 2024 01:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725498944; bh=6fs2uhR2bK8qEvj+bOCFzAA4wSbevoeGQovZS7jGau4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FM7LPDXGo3+mIpdiRM7RMOVO+rQSob05rZyd1LmwtgUqeQkcdMIMmT3lNs766bu3i VMW/2e8PYfDx2scbOm8yh9p2w8ZgZnm2OYJSuMUWTkPDFby+RHbDM8ZiEbGxkDVAMp aFzOAL+fH+oE9WTvZnNoEMZPMiXBLNJt64grnTP0= Date: Wed, 4 Sep 2024 18:15:43 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: linux-mm@kvack.org, mhocko@kernel.org, rientjes@google.com, yosryahmed@google.com, hannes@cmpxchg.org, almasrymina@google.com, roman.gushchin@linux.dev, gthelen@google.com, dseo3@uci.edu, a.manzanares@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: introduce per-node proactive reclaim interface Message-Id: <20240904181543.02de2242490cf233c7879697@linux-foundation.org> In-Reply-To: References: <20240904162740.1043168-1-dave@stgolabs.net> <20240904131811.234e005307f249ef07670c20@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 291141C001D X-Stat-Signature: 9pqu4oepw7etff1mgugypeiz7x3rwow8 X-HE-Tag: 1725498945-770604 X-HE-Meta: U2FsdGVkX1/1ipQTJxvgfIhbrAZ0lPiATbAVaMGevubMDC1y/RptRMwZICSN4nbnHV36UKZ9sXlHH/Ret5JSHjolV9svjnDVusWfZxcoOcfuXYShT9koCjW4pxRbOwKWqqrXC/P3RQz9Zr8WO3pjgXIbNrcwQeKjAPnjeAzh/+76oguuj9/L//MaqO++9Cerhs2Gyc3UbUsDq8KZfxv67rkO73sTHmtVnS7/5qrsBiJDkAYlKK9t5olojFkoQIQZt4KaZv9SPHSWk4LmEUeohYx5sZNSCrFTX1iZ4ooIHG0EA68nI7oCtq42ScyomykVx8W1QonVgRUsVIsOWnF5+XIg06XDuYfC4ymZ0fiifN2ktjbmv3/32OJuJgj0kUHpEBF7leP4Vhi2NELiCCpYe6zigVetFWKYR7kx1UcnO7YqAgogj4kC4iWhJT/4yRmnvgWqCnWSDwUvGHNF5O374Dse9aRfFS4iiJNcNwTWsPcUFnyhN6k3Qpy6N+w/qO1fGJP0hHMCZ06fN7X6ief4LA3fttmQ6xA3mUE75wujwI9ODVRNqeXvWKYgyQGGLNPycDAYiyzZAeosrDAD3RrNaGihB1X8jnNl+DAhqZS+lKOo3M4ZqgalSi5nGOSj/HL2HbGJZITVfyRijnug27ahKZblV8B/SDkEisvhR/IXscamoed7SSqrDc4eJc1kW2iCcU8IwN9YMy40V5YPCGLqWMJHuVaicHOzEyExLDajDiOCWpjX0n6NNcnR3Zvt0PHDtdnYVtG81qX/1WQaI+iIlDH+FDJbx+Bi9tBsUPNuzEWnk0Wi0ZK0zR1O9MF+vLgIpTGwKBLlKJKHGZHfoWWRpfkgSbxm9Dgfczaf/XmdNBBmvpRk5TZ2ZpLbTm5ZQcZDwPHsciL5HduZqEUKjIZa/ugNoODNkYAAFvWrwV3qWzLeCWKm2Y3dNA5xoNuoghP2ekinf0y+boiJCWOof7P cc+fgcT7 BScI6lJcTMyLTRiDkCZjF4wu99bBad5HluWtYRtM0GqCwsDn5EmjkAR62VQO/gfSjKkQ3f0EMkYUB0mEOve0vPBzRnZpiQsASlkCwvw24lbJn6S2ifDY0302JfDdA0Tawm43kyb65j0DZ17ZqqdSmxP/lhIYzoW57yCc1H0N8UxQJwcK86rE9ypyFisLPIA8ZAu/c8rcwWAnGv5YQQXN3atdxs2yh54Rm9KkTp8E2we8ZG9n+YdDZFhY6q67n+ze90tc7zRA6RRsjIRa+0rPNzHyRJ907eALjbOf4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Sep 2024 18:08:05 -0700 Davidlohr Bueso wrote: > On Wed, 04 Sep 2024, Andrew Morton wrote:\n > >On Wed, 4 Sep 2024 09:27:40 -0700 Davidlohr Bueso wrote: > > > >> This adds support for allowing proactive reclaim in general on a > >> NUMA system. A per-node interface extends support for beyond a > >> memcg-specific interface, respecting the current semantics of > >> memory.reclaim: respecting aging LRU and not supporting > >> artificially triggering eviction on nodes belonging to non-bottom > >> tiers. > >> > >> This patch allows userspace to do: > >> > >> echo 512M swappiness=10 > /sys/devices/system/node/nodeX/reclaim > > > >One value per sysfs file is a rule. > > I wasn't aware of it as a rule - is this documented somewhere? Documentation/filesystems/sysfs.rst, line 62. Also lots of gregkh grumpygrams :) > I ask because I see some others are using space-separated parameters, ie: > > /sys/bus/usb/drivers/foo/new_id > > ... or colons. What would be acceptable? echo "512M:10" > ... ? Kinda cheating. But the rule gets violated a lot.