From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A367ECD4F30 for ; Wed, 4 Sep 2024 20:54:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A60D6B024A; Wed, 4 Sep 2024 16:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358176B024B; Wed, 4 Sep 2024 16:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CF316B024C; Wed, 4 Sep 2024 16:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EDE5A6B024A for ; Wed, 4 Sep 2024 16:54:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9C8248010A for ; Wed, 4 Sep 2024 20:54:26 +0000 (UTC) X-FDA: 82528258932.26.E6B9FE1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id D64B7140007 for ; Wed, 4 Sep 2024 20:54:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oNmV2tQy; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725483188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EsXa8DRFAqHgj1HCFKbciF+u+kfE7KIG02u9oZz9mzQ=; b=vJI/qWpuH9W1Gyd0ik00W5olf1Qtb/tRG1/Jrin4PkObJEriHozLJcgaBhOD4yOP40tTzs X1tm/SEMfxia+RkUwiMS1LsbgnRskphsTvQMeOSndKawpndWKCFdnRfiglf+BCPnLLkkei 6I/UQ111j2m8DwpGsFCYQLoCbhkfWyA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oNmV2tQy; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725483188; a=rsa-sha256; cv=none; b=ameBFtN9aK4TcV3GFDfJV6iN5x8zqGG77IIMStPuyvg5LODm/HKhgC/cW5RYVcmVUNsrro 7s+78dZ+gywDZEGKycA3ZKNT+3mdpMWiadD6lOrwtYOXp2ArUJPSMekQZVjPEiJCYjhR7T +d0S0CNK3ocwJmxkba2LRUlQkA8P0bA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5A5085C563D; Wed, 4 Sep 2024 20:54:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27778C4CEC2; Wed, 4 Sep 2024 20:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725483263; bh=040GexcYT44jTPJNYfx1jzfYTX/4SvAdtklX0xSmWrs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oNmV2tQyvfH7WEjo3Etn7jABxIOLpx5Ce2wSHH24herqPbMS4C2PvBoTIgaCGr/jU IPWyeMnxl72Ii3ax8XbTb/Te9+2JWGoj6LqXJYTJ5Yv6XoLC5RAaaphCJdEmtv/nEm TIvlAu6wSgCGe1pOA/95deT63QMWpnQKSaeW9qpk= Date: Wed, 4 Sep 2024 13:54:22 -0700 From: Andrew Morton To: Kefeng Wang Cc: Subject: Re: [PATCH] mm: migrate: remove unused includes Message-Id: <20240904135422.dfb9d92a998d7bb26baa5326@linux-foundation.org> In-Reply-To: <20240904095849.861620-1-wangkefeng.wang@huawei.com> References: <20240904095849.861620-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: z4s3mkfe8sfybk7hd1e8j8tgz7ucihzf X-Rspam-User: X-Rspamd-Queue-Id: D64B7140007 X-Rspamd-Server: rspam02 X-HE-Tag: 1725483264-475903 X-HE-Meta: U2FsdGVkX19Qqf+PrcGzxzoPV+CvbruRZ41XFq/szRGmrgtvs+ncOPak4q7dvb2dKzyFmm7Mmhas51PVmYUSfaUvkfc6pcJZ+wMKD2pI5+2HxUNWOXtpPmBqU2JpcuwXJCgXyYmkjFPmtjAtey4g2KtjP/RixOMDJINXVVdA/0nn8XkxAIPZufqEV0a9h0/1/7pnS+cpvxSlLDhAViwdpg6wv3Af+FP3cp2PseOSgyMfaRcniiWGgR5hKQbEFwwIUW4INi2LeDoFflt+Er6RLPRfshgELxKF6prcr3rLPq1Cw2ztH/4owqCDyczGAUdwdhndCJSOMMuXZJbWEVem736/ZTdBM1NNQM2DO3ZjDJlevQiXF1IMGvyneTyhEiQ9JjiCEEHVG0SEeTR42qE0XX98Y1UJYbDpMjdIpVULto/guFmi9J4f97TDP8PO/9ACa5J0af+MwyjXFw/CcKCQnnsgPKkyZ4lDd5MwnebMGF49lvJgjd4y+1jFcjU/oDozxUkfX+FYSQRQhs2JPMVUITCX4CKkCjr6pk5gishJehlsaM+7KfF4Sxo7Ke5keh2vFIQjTEQVcUeVbYacUaoI+AE58Hx13WQ+okFrUIda/mYhzNn9sZE/puoD8O1IKQg+GX6pF2jgVPMkjJ2mDCerXLmoFdJiO5SpKSXnuWTmsu4wM3A82rfCOz9B+eWqd+IClwFINSFlWeP+1eOpnUsVpdSS0/+b+q1VoAfL4T1HHwEP6qHHUAoFxfMuoQD8YVnP7/otXfe4EhNs7efPZvtw/OkfRgQMavhm8iV3ja6eDQ4YWyuMaarRv/8luql+T17cFpHeBnaCmC8+VBVj6MqlL58lobAvCySs5nP+qo2xvhaG7+hj0EvdQPTLHSmj1QRDMZ8ko01hELT9oZL9K+D+imvO5TwBV/mqyHTV7pP/z2/lWXuOZJCdbKNuJ0ASabhrOVYZzDmXDamUhWwibdl zm8/KGuo jOLlpVptkofS2/NBmEvFZmILmBp0Cunjsd0l1zf/gBihX8hSOl2GIsG2IZbOVbWzSn+mE4ffWi0piL8pOcEkKZT6wBMcTz5cx/J15WUeXrSI2d0F4EYv9sAIOkCVnbceLD1P1lsNRxGj3N3ARXffqHCII54yyvPsJ/Jx7dUqrbG+pG6pCAAHsPcEv/j9NGCyrdf3shnfsMTE9y6cayo1dITG7YCaFyHU8q6cGh1pHXpR4XuruNJDsIh5bwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Sep 2024 17:58:49 +0800 Kefeng Wang wrote: > Some includes are not need anymore, remove them. > Please define "not needed". Does migrate.c simply not refer to anything which these headers provide? Or does migrate.c already pick up these headers via nested includes? If the latter then that can be a problem - build breakage under rare configs, or as code generally evolves. Not a *big* problem - we detect and fix such things quickly, but I do think general good practice is to directly include whatever the .c file requires.