From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 803F2CD4F32 for ; Wed, 4 Sep 2024 20:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B40066B0322; Wed, 4 Sep 2024 16:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF02C6B0323; Wed, 4 Sep 2024 16:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96A056B0324; Wed, 4 Sep 2024 16:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 77B176B0322 for ; Wed, 4 Sep 2024 16:46:37 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2496CC14C8 for ; Wed, 4 Sep 2024 20:46:37 +0000 (UTC) X-FDA: 82528239234.29.C1DABF1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 73065140009 for ; Wed, 4 Sep 2024 20:46:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=G8TI0Z9i; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725482666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UqSkG4IN8ga9YPSfjd1r/NQtjY/7y3VE2954yywB5vA=; b=W8QpDoQ4SGbIzhZEGiBBrMdJg/dN+dC+6Q1UEm25f3/vNiFKz/Qu4nbUo2MHRToF9NUgtF NkuWMDwzrbbE5yq7M4WibTVaF5gt3C//7q2c/vi1PleI17lH2TGr3Qpe5+PVJTl+9UUTNw 3HU0rCDyIoL5ZAKBHGwUANj7gwIAG/A= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=G8TI0Z9i; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725482666; a=rsa-sha256; cv=none; b=uK97+K7qES+553YtpMGGusBBV0dHv6sMenG2f4mmtH7syaV8xKRX80sLou0rX51jp+MgyD RRtYqedVfqGSemeg5SiLO/GR1FXVHu7OGtWCeDSIFxpfRFV1hkgzeySUSkMVtrp3Pkpqkn sS7uri5NDKA+k8fGoKLcpFu1p0fqNzc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0EAB95C5896; Wed, 4 Sep 2024 20:46:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BB1AC4CEC5; Wed, 4 Sep 2024 20:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725482793; bh=jLJ6mKIo3HkW7nk29ShAZtA3mgb0x2uwBj+JNND4bB8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G8TI0Z9iyV7aD8ODKdg3+t6z2OhUN531PgCCXIxmXHyFN22XizUeEOuQtutODlpwF n5KzFrIeQ6Af/U89Fel5aEfbp4Kt2JTphVVrAp50l0GgY22ME7WFYrWl+PYD6FsH3+ te9O/fK6+6n1mZEnoVoN81t2rh/6VwqNC8SB8c7g= Date: Wed, 4 Sep 2024 13:46:31 -0700 From: Andrew Morton To: Ryan Roberts Cc: Baolin Wang , Hugh Dickins , "Matthew Wilcox (Oracle)" , David Hildenbrand , Barry Song , Lance Yang , Gavin Shan , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/2] mm: Tidy up shmem mTHP controls and stats Message-Id: <20240904134631.4dd7a0bde6439aad3a275002@linux-foundation.org> In-Reply-To: References: <20240808111849.651867-1-ryan.roberts@arm.com> <20240808111849.651867-3-ryan.roberts@arm.com> <747d1319-f746-4379-bf88-a0f6c3f558b4@linux.alibaba.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 73065140009 X-Stat-Signature: 6yk4wgh19adeu8b119zjnz8b9h7k91ay X-Rspam-User: X-HE-Tag: 1725482794-487875 X-HE-Meta: U2FsdGVkX19FBqpjaN+9wr9IFtzV81YFQG6a8R89GXL5D1RDgBtybD+kjMiFKTG/0LjB5Uq4xGijcnFzF7GfwYJgdh4wbfWUGCkC6QfaNilEkQWlf+tAVTuFDFyrfymZZNYllwDk9unmnjiLUoamEi93udS0G834FTRgmu9PB35aBlQ0YtmGxyGIlNn5AvzcoS9u44Monx0SY+QF9NyKE6U1UJuCr/yBw8yh33kkfR+ZPAQnU4Xzq5ca1zM/DY95bvHYesrjxfdvROCoiSQCLjlsfKLyxo7ovRlq0MwpKboi8wM0BI5fDNQjsPxRcgW7xjbiKaEn6qXf44CdH0wmWBAFtuOKehbEVGi3oHWZXkvU3BY8+XUszPmGZMRRs4CeuTV82dDd+DR6LPDdMG2KvFqocgW+HQbOuGfBsXN/NNwWT3slAEcZpoxuGqmhrvGy0Fwkl32fk9eQO76WfP4hYeHRlmP/XCquOc6UBZWW8omfTP8Z6dEQR1oTaLcBAhkC2pOjAUqJidHjJZ7AF0JSlZvg3xc4QXN9r3ZUZeK55ISc40Xbc2GkJpWBXki5s0EOeTREel/5pxcea+Jcf16G+xqt0gDnpOlihoyJp7rb2VCTs4vXuHOLw9vA9mhL+zIBP3wGlLZyzOiNgk1pteTSof69oUQPmLRZ0sQrR9u1T1SWspZBnrYKfrjJY9Sv2rINd4B/lotiExPWrCc3kGMNBJpDY9x4S1hWj2MPvQ5WOgljkHK3uyoWwU1+gZy6DFtYKRs2wwZD++8oPZWpDgeIDTrp4VxcyM8jqb9adq0P/n6U/tAgEjHxku/Zng0sawnrKaM9n2rEUxvVYbr01IXdlYYHFCOot26y6ZIMLfI3TbyE4oCzx6JdMtNM6NpYYmFwstTECH0WZHc//2gul2FNMExNbnFt3HdA5fBij/DKKddKQTQI4YEEKeMerPcUg7Puz3Wp0oXXZ08j4tgO3jr 8N90J0lI MoyGl0LZIHf426xv5/how6ZSW38G8QnT5Ag8yL1GwnO5Kpa7xdMxCygjd/oXPZsieZZ2lEMynBEGwEs6UyB7IYNJsiZ4W4gCYHwueoFrM0VI1VWJH9GKfmZMpgXwnsZeYQrdQBIRjv891WmsjLSUZNML5CVaSKq2kkSVNw/v0oYtrAKC76HAk8ERzaWXQvCJGvRjMkNrqeEW56EOA24sXFlaFGdhahv2/csPLhAKRCxjmSQjaMcDVDcLN+838tLc+t3h7RZhse1iXx7Y/X80VT29Rs4i9XNTc7c+obrkIsX5X1ONKJ6VrEMSRbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Sep 2024 11:47:29 +0100 Ryan Roberts wrote: > >> +static struct attribute *any_ctrl_attrs[] =3D { > >> +=A0=A0=A0 NULL, > >> +}; > >> + > >> +static const struct attribute_group any_ctrl_attr_grp =3D { > >> +=A0=A0=A0 .attrs =3D any_ctrl_attrs, > >> =A0 }; > >=20 > > I wonder why adding a NULL group? Was this review comment addressed? > > ... > > >> +=A0=A0=A0 &shmem_alloc_attr.attr, > >> +=A0=A0=A0 &shmem_fallback_attr.attr, > >> +=A0=A0=A0 &shmem_fallback_charge_attr.attr, > >> +#endif > >> +=A0=A0=A0 NULL, > >> +}; > >> + > >> +static struct attribute_group file_stats_attr_grp =3D { > >> +=A0=A0=A0 .name =3D "stats", > >> +=A0=A0=A0 .attrs =3D file_stats_attrs, > >> +}; > >> + > >> +static struct attribute *any_stats_attrs[] =3D { > >> +#ifdef CONFIG_SHMEM > >> +=A0=A0=A0 &swpout_attr.attr, > >> +=A0=A0=A0 &swpout_fallback_attr.attr, > >> +#endif > >=20 > > Sorry I did not point it out in early version. I think file pages and s= hmem can > > also be split, while 'split_deferred' is only for anonymous page. So I = think the > > any_stats_attrs should be: > > static struct attribute *any_stats_attrs[] =3D { > > #ifdef CONFIG_SHMEM > > =A0=A0=A0=A0&swpout_attr.attr, > > =A0=A0=A0=A0&swpout_fallback_attr.attr, > > #endif > > =A0=A0=A0=A0&split_attr.attr, > > =A0=A0=A0=A0&split_failed_attr.attr, > > =A0=A0=A0=A0NULL, > > }; >=20 > Could you please squash the following into this patch, which is already in > mm-unstable? I'm hoping this sufficient and I don't need to send a whole = new > revision since there are changes on top of this in mm-unstable, which mak= es > things tricky. I did that. Please send along a Signoff and a changelog?