From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04AF6CD37B4 for ; Wed, 4 Sep 2024 14:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 879696B00CA; Wed, 4 Sep 2024 10:33:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 828E46B00CB; Wed, 4 Sep 2024 10:33:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 719636B00D0; Wed, 4 Sep 2024 10:33:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 48F526B00CA for ; Wed, 4 Sep 2024 10:33:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E9E66AADF0 for ; Wed, 4 Sep 2024 14:33:11 +0000 (UTC) X-FDA: 82527298182.03.270C511 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 4983840019 for ; Wed, 4 Sep 2024 14:33:09 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=t7uwX438; spf=pass (imf12.hostedemail.com: domain of kuba@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725460313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MbCSY2X/2Xih1V7KmfsEIdHuRkTgxodv2Khzf2L6nbw=; b=plXpMbU6RvBbn7s7XzsfT/JixL+OiIJI6n2q1MIr926xvLQXE37VrMgvq8VVA61YM0eBVr FPAHX7fgW73GCkM1dtcw5XojIhObzBhErWa13oZnVLVJdx4LAw8oMOFiExqUM7s4iwPcko AtyyK5kaU1dpzNMoMvL/ImDKz/q5N6Y= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=t7uwX438; spf=pass (imf12.hostedemail.com: domain of kuba@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725460313; a=rsa-sha256; cv=none; b=L41npoXqOz0HS4nW0AAfIMcndioRn83auQ9x8H5LaTp9cNuOXPgt/BEZExPXmIekXR6/TZ DQf+h9R++wVcVQ+R69w9w0Ck84Ois6AFv7cKePhBBmwyG8TUYWgxlsiZ9VIGzWqHJEXxKp EdQMqHt7cZuEJxI1KHk5cCcGwPYtZnk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A8FE4A4442E; Wed, 4 Sep 2024 14:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19DDDC4CEC3; Wed, 4 Sep 2024 14:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725460386; bh=VUbS/eWYRXe0dzCozXBddttHq2IEobNfmyTbrqxR/Os=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t7uwX43896GPIxki0muQXweDYB54v/1SPHpACh01PFqn72a+X36LUDDCdZUMHQMRa xpmI2grx6hD7TzrpAVWiGW0LokIBvYGbHyaf5kDUVWbkP6Lm02Kjk1PQAJNNngqNMq mdUUdJl1boptWdKFxnNw7N4pbCR4CDVYUua6GjD9cZA81RcZeWgRlXFfM7kSBpw1bD NwOGWdjFTYrCi5QZ9miLcwFtsymah2qN1sDb3ii7xXocDz5UBwonBeJ0y3j9gPz3Vy cdArN77dyvJ45QDL9tIKMCzUY6Crcbe9DdtvcEsXhQagGQfUOjWx0acyFy8t4m71uI Knx3nrcGGuj8Q== Date: Wed, 4 Sep 2024 07:33:05 -0700 From: Jakub Kicinski To: Hongbo Li Cc: Andy Shevchenko , Willem de Bruijn , , , , , , , , , Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Message-ID: <20240904073305.7578f81b@kernel.org> In-Reply-To: <56a4c8ec-2cc1-4078-b5d9-fb128be3efeb@huawei.com> References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> <20240831130741.768da6da@kernel.org> <66d5cc19d34c6_613882942a@willemb.c.googlers.com.notmuch> <9d844c72-bda6-4e28-b48c-63c4f8855ae7@huawei.com> <56a4c8ec-2cc1-4078-b5d9-fb128be3efeb@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: jp43rta661um63h4fcnyz16aq9ufk9p3 X-Rspam-User: X-Rspamd-Queue-Id: 4983840019 X-Rspamd-Server: rspam02 X-HE-Tag: 1725460389-684320 X-HE-Meta: U2FsdGVkX1+PPndi6vHyyi87oRo4VRmR4NofXPQnteV9j4EfyPw9meJNPFPxji5xJRy+Q+296+jEsBu0RWSsEvkfekbAnNF1rCltVmsxY6eMgSYg1/r6LuzkckAfSEnZNPwoxlTe+VpCcTqbRlk6X/W3X8qHiQ3hKV+N2KLr9RqKTg1m3qobS2t6rAhZc4etoTA3692FfJC5/8Ktf7NxR7AQ1O1rVLTzeFYYLcfMYAUbxxE+bvJ4MnkLwtc4aTWyBHvjvslSuKTr6wyH8dcXfFIEpLrFSxenpliBJ5k/fYpp0YU7F+FBVvBrVYg1Wb8RS0JLMX6awfgPv+OJI7bknAwb4kAHOuhINvSybk0iTHP7oCvj8Jb8Vkmo34jLjWQu0EM/wCE9flZ0UdHbQvPuBkmMq/qZZl3f5vmoPTxgaveN5v4zjciPWwM5YJ50JEgoFeeRqHsPYGKiEqGJRJJajvLIq/FxeX64vsIumuL/j0GhQ1UCsN/nracH2RJC0no1CvNu07y6FGr+JXekYlXkI6dkK8KzdKXjcms47P9yW5yDwZxjjiVP82Hszw54Y+0fBfWa4+x1fgsbld1cPqsU9NpG9PSnAZq4nnRCGzYLiOwY35JJlHYzKgRg6YtoHrPU8K3unCy6cJqOyWV7sGF3yYO1GXPtBK0Lq+6oYfzhTyJCNAPa0aVMWpUw6paQYkUFWkAvt4pZt6BRTyRYXsbTr1Uoyqyp+Pz7QOm+jvzFtFbgE8ir8gXW+S8CWsbDSdHe6Qcxx11PmPmFKRTSe8twtnQ4cA05BzALOmRULHR5WCKYFXZgIeOPEeXz28IFFq5gxdIoh5ThBusEqPdofqwxaytPq1zevbQ/4kF/8+BNsWmPiPMmP6wl4sBmgzwQQqLR+vLpq8rz5CdA/9+dAGYAwLC4R/RdJ47Da+upSm1fVA/whCLg5H0zXrRJr6TghGkg7/YDtnkznwdgawT6d3O HOUpwQTs pthEJb/+65KUBQyMZO9NqNZotHRWzCqhEm7K/pfqlb7YlnAzfKAIXL8cDCSuzmi6U8/OlcF3VORSUaEj6ZX1C9wynG36/k5VRJiY4EfRUSujm8ni1LX/nqM00BQkSDmDu+hjn30givHfi1O0dODeI8oMBfVpJ91DQTM6Mp3NagaIQOZ3M/MfT8wRZc5Mg4Yy58xsWBWTtkaEx6aN4ksOVjDhZniC3rKN/Bd30CYOPasl/aWJlX4qeZ2c0AMCvsbcLIM4wG+CoYZHoCnomhNga4pzNzaBFzqEHkn+qdciWmbqxfSbs5tC8z8hf4dRFEnKNmog0UTDKxz+yuOdYr8UzhyCJZ2qmC8GTjL7zGlEMWzVXE+zGjxRrRjv2XA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Sep 2024 10:27:18 +0800 Hongbo Li wrote: > However, with these modifications, I'm not sure whether Willem and Jakub > agree with the changes. If they don't agree, then I'll have to remove > this example in the next version. This and, to be clear, patch 4 as well. > In the future, we can guide other > developers to use these helpers directly instead of rewriting it themselves.