From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520C6CD4845 for ; Wed, 4 Sep 2024 03:13:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FE1E8D021B; Tue, 3 Sep 2024 23:13:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 586B68D018A; Tue, 3 Sep 2024 23:13:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4268D8D021B; Tue, 3 Sep 2024 23:13:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 247418D018A for ; Tue, 3 Sep 2024 23:13:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B42BB1A0CD7 for ; Wed, 4 Sep 2024 03:13:00 +0000 (UTC) X-FDA: 82525584120.21.2946FA5 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf30.hostedemail.com (Postfix) with ESMTP id C5C208001D for ; Wed, 4 Sep 2024 03:12:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OPFHLM9Y; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725419483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TVPWu9sUqLbHT5iyV7ZfxkiCdl2In90sWFTTzj0LOBA=; b=xj4GlnKRbCP1FOQX3BLQmj9g2bs0fBAN1vdcV50PuX1dKSLrAoLLCRMsLNm1zC5dfHPFQp 3qRD+pV33QCkf9kB40ECN8kYLD/YZZr8EJUFTs0fxAVxsJmWkv/x7UFWrc8opklVPhJGGZ 6JCQ9GnJ6Q7f4ge3y16WPAuQ0OPNp9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725419483; a=rsa-sha256; cv=none; b=tkRJgSJW1It/hnA5mD8xjiZSqPr7etiw9l6fR+UdT+gSnf+TqxOr9aXa+m7jN9rih3B5O3 lSeI1Sl1k1Jl3RfnviAc/fyYsQ+w7ewPX4VM5iWjN62LKnR0vJukV418ByxVr027wzuUU9 92/0hG3cITeSI7qqUhxAtZTdbSdKCDM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OPFHLM9Y; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7176645e440so197765b3a.1 for ; Tue, 03 Sep 2024 20:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725419577; x=1726024377; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TVPWu9sUqLbHT5iyV7ZfxkiCdl2In90sWFTTzj0LOBA=; b=OPFHLM9Y3rEn8UEpWEs0GCQWdeGlNDP2beWlh+ThUgTAJoDzcJCP8IC/7TpAUZMXbs 10EIOZ8Rgu9XUYJmjIxaMfbT3YsNj/DdI5e8ZJeI6hel40DFn999FkNAPO3O71OkouJA V5Qz+pwxeHt9m8XOAUDZHAiR2AIWDU/0e5C2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725419577; x=1726024377; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TVPWu9sUqLbHT5iyV7ZfxkiCdl2In90sWFTTzj0LOBA=; b=SxkSrrD7SusG7h2hDMB60aMLFS950BNvunyfRf8r9fkmItzsi2quVNOKgTyuMqpE4U fUqk5M/QJ00dQYrgOerYt44uQIdp91P2DKtpEcNsYTK59ZlJIadROXh11MS0MtZcYxgP 3Du5p5UmMqNPLVaw2rL8EtjbhJWv1z/N4aefTg1LMbE109yEUOHqskYjnGCRGm7tx1yO t0zRP4Ti2ILm/FIETySzuB3QJAT2pUNmNXjGVrnrppEQShcV/mSY06twM9qJkUCxCPcn jR8r2Sj9TAdH/JEIoG6AoZf0SQwpaz+gdandFX+3ntZOPVOadVKNc1hZ0fvLwCJ7z5mn Yfcg== X-Forwarded-Encrypted: i=1; AJvYcCWloJJMu/EaxvvwNmxz9+vO7OpTZQ7rSJfAAUGT0ksGLkXvwoUyRCen7VRMZ7Ea2l45pMYxBsvI5Q==@kvack.org X-Gm-Message-State: AOJu0YwNqaNAOhBRyH8BaqmQfrbwI9MOByL/vMd1PVU8Qb6QWOz0catn jdsKqgvXzqybKY1fQSg8GZAUXzGKiyUZJpBXXFPemwNfn+5koEb961wlURw9fw== X-Google-Smtp-Source: AGHT+IFvkHAwDXcuJE+SuxW74G8xVLUNQ0a7z7IakAQfJsKRjR1RkSpDa5RGzx9oZKjbHyQbyUU4Zw== X-Received: by 2002:a05:6a00:1895:b0:710:9d5e:1154 with SMTP id d2e1a72fcca58-7177a91f845mr1429191b3a.2.1725419577304; Tue, 03 Sep 2024 20:12:57 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:51ae:4bbd:c856:6cf0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-717785b9609sm569140b3a.215.2024.09.03.20.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 20:12:56 -0700 (PDT) Date: Wed, 4 Sep 2024 12:12:52 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Johannes Weiner , Sergey Senozhatsky , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Kconfig: fixup zsmalloc configuration Message-ID: <20240904031252.GB1602548@google.com> References: <20240903040143.1580705-1-senozhatsky@chromium.org> <20240903175528.GA1190078@cmpxchg.org> <20240903142847.f03362654cac51bf4617fe18@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903142847.f03362654cac51bf4617fe18@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C5C208001D X-Stat-Signature: jrpm68hbe4fdynu3w3etp1xtscx7ypcn X-HE-Tag: 1725419578-972073 X-HE-Meta: U2FsdGVkX1+qPwwqo/Hb0ZyKnZXbe8LgXBbkzzcPIppMLMdQgY4uq9MMq0PpRaV2LrzPHC3qYXkq0VMFcqSr44Wi3/cQKjSxrb8xj+D8Z5ZWMRfgnNtLVEXjGgVs5s3+B8Kmt4chs4Jgl2VPsj7hzNykZRNIE1yU0ZwerYcFUzcZWKzZLrd6blD3MsXVzHm8cIZIaqkUjf3+ZCrEYgS4fscmNhOOta5/ui8ahMFiHh/9nNR9tQvTZOkApyOe3nYc35DfXSs3t6Y+fcEQcxtusM4o3YsFG7WHeOVydM1MdgOrHTbSqBewryhP1AaHgtYq1gQ/KFx+tsr3s9Hs+sFdU6uawUaXLfHQ/9ZKHFBqSc7iZgemAuPcwZL8zPIKXVUFi2aQIvXV/f62Nrwpa88S44fB0tsBf7J1xh1m7oYrTKyWjRzKGBuRQITsKIZf6imA0cQDU9fq9xfupY3I2vrpEyuXlo5ljtv1b3gj33GCCsq7bYPwAGEJx41lCmwRrNfV3+bwOkKgqLMUbWtwCeIaZKJ5NnfUpMWDXn5AQd4BbhRpNxWYg7HRWRWPAjIGeBV6rFKZSuPOfitjLLrUIV60vJsQ5FucBMaoF2rNQtua6K9Uki3jK1jXqReeCOqzwennm1kpulNmcK8GA7DEpBWpMS99VHLQWwO3DMvxBfRQlNTqlRzMm+0/YJbHFwU1AYYAFWFcogfJ/89leU2ztEJYhzN3lYH/8C2HnPW7aw2SwD3eTorzd8bBkEQ67qDxKfkNl0uHeSCqyaP/MXVaFkHKVmcuSHTcFhXb7OPFCxmPg3CuXd52JJNwdOWHgFf1yztpOboUXZIQVVMb+oIk9lW9rKYO/USic3w43ixKTVu72cVUDyzHdCzuT+m8cXCYZ8MR/EvipNLNY4OINz/z0zovrRx8vFiZE/6kjOBjpeyPr5T2lMVoaorwc29FpNXcrfA7V2Dt+Ap8FSuwsw9Uvy9 SX1V1M7z E+PsOwctK6vsFQwBh9mBpPiQ3kdY/s+WU5Bm8ljw+TyrbBaadS2x3xjoumlw0fUfHbCadMhX7OiljEMMmCw2a/3T0963DSYWAF+ndhGDJipogBCciAAg0uxemAl/Agz1wxBsU6Vub6zOWYbzF6dveT5GSbbJZX9i0xc0PelU8B3fKsR+pC3lIHVruTlp8K9CVa9cNXfw7h8r7aM1Xzw24uoYwCpJHIYx1d0+h7eKpDuhx1MtMwphxjFDSsCgQPAh+ySDHUpUHpGIqM3xglwd9iMxN3+4yk0WI3LywvxIKvCFjFaKMgE9rkE0YaN428lKxjlVXV5zczeJnL5zxM3dy5Tx6LzvBDfFSZBauP3uyhe+lDS7H4JOBVx/siNXG3yKUsDFwa55vhLO9MsE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/09/03 14:28), Andrew Morton wrote: > On Tue, 3 Sep 2024 13:55:28 -0400 Johannes Weiner wrote: > > > On Tue, Sep 03, 2024 at 01:00:22PM +0900, Sergey Senozhatsky wrote: > > > zsmalloc is not exclusive to zswap. Commit aa3ba6d72ce0 > > > ("mm: Kconfig: fixup zsmalloc configuration") made CONFIG_ZSMALLOC > > > only visible when CONFIG_ZSWAP is selected, which makes it > > > impossible to menuconfig zsmalloc-specific features (stats, > > > chain-size, etc.) on systems that use ZRAM but don't have ZSWAP > > > enabled. > > > > > > Make zsmalloc depend on both ZRAM and ZSWAP. > > > > > > Fixes: Fixes: aa3ba6d72ce0 ("mm: Kconfig: fixup zsmalloc configuration") > > > > I can't find this commit upstream. > > > > It looks like this was actually broken by > > > > commit b3fbd58fcbb10725a1314688e03b1af6827c42f9 > > Author: Johannes Weiner > > Date: Thu May 19 14:08:53 2022 -0700 > > > > mm: Kconfig: simplify zswap configuration > > > > instead? > > Agree, I edited that into the changelog. My bad, I didn't pay attention to what checkpatch suggested as an edit. Thanks for spotting this Johannes and thanks for fixing this up Andrew!