From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E06CA0ED3 for ; Wed, 4 Sep 2024 09:45:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C32816B0365; Wed, 4 Sep 2024 05:45:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B93BE6B0367; Wed, 4 Sep 2024 05:45:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 998496B0366; Wed, 4 Sep 2024 05:45:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 74BCE6B0299 for ; Wed, 4 Sep 2024 05:45:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CA16140DE2 for ; Wed, 4 Sep 2024 09:45:29 +0000 (UTC) X-FDA: 82526573178.28.22F233E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id 8963A10000A for ; Wed, 4 Sep 2024 09:45:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qn21v1/5"; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725443079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YjNJhOvbgihgKzyanfOxFVApYPq9Otnfo4m/bzsemEI=; b=GLlWcstquFS+rwPN9uC5MvPobsX/sbzSDXQ35/GgdnsKeIyOEz/qG0VQ7IHNIZCWXHpBO1 iG5Ir47VTH+6sb3bK07uukFvUG00BF6Haswx4+bTpRsvtIMD5sVqPd5a8lR0CY/fgh7xg6 5CCxQ8Ajw0kKA/S+aIBQWoz4CjfPmC0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qn21v1/5"; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725443079; a=rsa-sha256; cv=none; b=At4TI7uD1fUZlm46l9qWReTx9gjRaAkO5ZzhjdCUXrvLnYsauqGuN8I/4iDsZxfMa2aJSn IXlybm+NljzNdc8EiGJX60CKhmmlG2/hWpVLIEnm+/MDbgJOIySHb9ZgNS84qrtNJFefM6 I9D1R7xtkelwFzDu0etprc0Hr8T2m6Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B274CA4351B; Wed, 4 Sep 2024 09:45:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C73FEC4CEC2; Wed, 4 Sep 2024 09:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725443126; bh=sE3L7k91QpI1rNM6w5JFxo/0WUtl8HANuErXC/gqVEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qn21v1/5/Upjnc5tjWJTf1AL81Yumo5b4zIkQPcU7pH0aAoz2Vq589P4YLNTjtl0m 2Kqge+S+4rJl0xWDiyRuYUHZU/OosXZ+29HBmqsVaK5EEOf71v4MPeqCG/CKNgED4p dynLPzCKrq6CJsLlkAVha8JZV2Ik1y7U/+dLKf+Pevxed/WvzO9nbbCcAPtu1455w8 hh/BTcb4sVZaRTMLEsvZ+xXSlhIkj8hmIWT5baiebkiksGjhL3qJcNLuCG2SSyZjos mXbSb4sTWoZAlMjh9MAv3ShsJwd5oEHOpFWyDpj6uEKeqGDEezn1H4svIV1heXMuYg fUN6rS9SmQrUA== Date: Wed, 4 Sep 2024 11:45:22 +0200 From: Christian Brauner To: Mike Rapoport Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Message-ID: <20240904-storch-worin-32db25e60f32@brauner> References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 8963A10000A X-Stat-Signature: x46dauyxmqduw5jjy8nq1j95uqdgjc1q X-HE-Tag: 1725443127-637326 X-HE-Meta: U2FsdGVkX18patYgE6e1PcLU9nw5ftnZx6DGaYB4YEBwQ2hNIt8JaARtkBulP6QfsS7YQvwdkMTbzrnE6rZByvwLpk3R94OXonYbLdqWPssNM+lSW4/u5Xs0PXYZ2KYz0FlLNZvgUShrjrgLeYg0rk8EwJn7LyY7YAGcncjtSyCBH0UCsAqS0/SWA8zFFvfVbeRbCKYdE7T9pNgnIGNW//DfnqdgUfGJgEjBe73RouYYmche4+bp9xuVI+QzjeTvSHwjukr7AlAz7KeXOYJd0vxwNl1SODCfL7SpDYvVbuFaHMYLxrI5PYy6o0wLM9MC3o+fU0pXQXe9K91sLKMIJVLKwT2K3z3WWUtCLiLZl7obvWQ+vcmtbAweCBmaed4BvIGhGDpHUmPKD+1ZMS5eztNh0Z9DN/96CK8EjF9MPqpyb5y6dnXEJt5BG1x9TTtuAyOuB+guD8sIXNNGnjgUo2Uxtjl6/aYto8YDZYiUbc6a/0/PXAvgIl7FAPZfC62PaLzyB7WjNGvgsnP/Od9LEUHA00vfO0f1lTq2qhnZU1IF4EPXIMQGcCmqrBHfl/kZMwYEdXWoLVqux3Eyl5mf+eSP0WgGBMNfN/HnoDqBZz+pSuJDGV7Tjc/4iFP5+DAntFxEmZK4Wzy0+tO4Cf0Sl30bgGdmz0CpmFNiUDIcGytvS2IBr+3uyg99JVxhZFe5kiPoUHXBFLw4rnABQHbaH6/ri/8cKFezpHjQTohakWcZBOJSvrpJ8GdOrqTKE6w27UBBjn5qNajS/EtrmXOLpCScOz0B4PjTMSKEhmumb9f5osugjUkNQBmdFgc/x8EiIq/VwuI6ve/TgtpNZOYPyL/htgiZ7TA+q6aiM2KDbEuEkuODSEXhQ3ZlcJx20CYW9YxtyPNU5jGkDZ32wroPFfSNhRWIYvl8ynvhQV9cD7nZyepH51zfDNLQD2/CzM1YaWMPRlqNsxIjdo4Z/9d lNls+oY8 IoXZ8F7/jlHMkgxU3W3Z6ZiL1JfIsy+eyrsPkK40epJ7bOXCr7BsOZ2sgWweaAKsAbLnAZvhCwzMSsNKbwcrWfa0Ao2BEt5t017NvMJ1mf+GL7we++k/bL+Zm0VpxGAaCLyqTnGaKxaf6KWbRxSdckGY8hSuNBJqR3vxxgRvKSx6GmK4faXQpqDra46jQD9b/wytyUUzunkmVBs/hw0blOL2zC3c58fA68IIzMGIWV6R/LQ757TtuWO/ngguJJbYowAyvQN0Rf2c6S01bcXUxbGyvKvwfr0OvRMcSM3elKiVCUy2iC4qgZAEdIWY03FcMwDFsbE8PN36mzKLAc0H+6d/n4Ql5DGTW6fvljKDDD5WRNQBoj+GZMeGNnryfGj918KX7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 08:14:24AM GMT, Mike Rapoport wrote: > On Tue, Sep 03, 2024 at 04:20:53PM +0200, Christian Brauner wrote: > > Use _Generic() to create a compatibility layer that type switches on the > > third argument to either call __kmem_cache_create() or > > __kmem_cache_create_args(). This can be kept in place until all callers > > have been ported to struct kmem_cache_args. > > > > Signed-off-by: Christian Brauner > > Reviewed-by: Mike Rapoport (Microsoft) > > > --- > > include/linux/slab.h | 13 ++++++++++--- > > mm/slab_common.c | 10 +++++----- > > 2 files changed, 15 insertions(+), 8 deletions(-) > > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index aced16a08700..4292d67094c3 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > > unsigned int object_size, > > struct kmem_cache_args *args, > > slab_flags_t flags); > > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > > - unsigned int align, slab_flags_t flags, > > - void (*ctor)(void *)); > > + > > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > > + unsigned int align, slab_flags_t flags, > > + void (*ctor)(void *)); > > As I said earlier, this can become _kmem_cache_create and > __kmem_cache_create_args can be __kmem_cache_create from the beginning. > > And as a followup cleanup both kmem_cache_create_usercopy() and > kmem_cache_create() can be made static inlines. Seems an ok suggestion to me. See the two patches I sent out now.