From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D15CD484D for ; Wed, 4 Sep 2024 14:44:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C53BE6B0125; Wed, 4 Sep 2024 10:44:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C036D6B0128; Wed, 4 Sep 2024 10:44:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACBCB6B0129; Wed, 4 Sep 2024 10:44:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8DE836B0125 for ; Wed, 4 Sep 2024 10:44:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0EFAB120543 for ; Wed, 4 Sep 2024 14:44:11 +0000 (UTC) X-FDA: 82527325902.03.F8016F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id C614DA0015 for ; Wed, 4 Sep 2024 14:44:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uwAqlyvI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725460970; a=rsa-sha256; cv=none; b=yxidgpJju3MY0KMU7A/MbRAjsjyX3C4deJ8NfKmgEnBn2uZxZuRdRM0+94cgN6OiL2y9Jv DYvGGQv74IP+HJSfjlUKcMRDYNfvcFfqu9YhjOxlqik3+nAFpSV42QCbnVt24vW3h8o02W QQm0COp9kVYTw586SzxpxMMIJc8aFlI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uwAqlyvI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725460970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7XpaxS65W4cJ2aN3wWCpJH7w0uQKa9Z7GquRcu7qRUQ=; b=bjZjegd2xCx2QY4IJSzG/wsJbZvrbcWREPDHFSl9S3WsDo6lAx+b/1+tN/eiLBtvKjAZ/0 It+kidpDURE7yNEspGg2AkHe6bzgCoeO1Dz7TfXtnCn/sqRz5ZZ0ywlhMuXb7jR6l5vtj8 BKfjfWCNU8ijZH3XkGYSQTtrGm31fS4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 563195C0FD1; Wed, 4 Sep 2024 14:44:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC36CC4CEC2; Wed, 4 Sep 2024 14:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725461047; bh=3h2/8kiGs8hQepiNOVw377i6agmyGFWtRxl9uQnfOXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uwAqlyvIn4eDqRM7LT+9spYpM65FWgAdjy8PXvfNTTu5OwqvCE2ADdFPDNe+0+8iP Uv6rEOBKP7z3RmymOrUed2d+kiMTO47uPSu4CkJQNu1ZHVduLlFGGWwxA1GJA5RXFc B2b8CyCO10IRKSrVzn84FbtfHB4obKFJvtI60ywgO1T4xcOWDax7UvJgUpV3dl2mI2 UaBx0YsdoKUWRqshw5x+Ox7iqHVZgaeuNO7pXgdZkSclHc6BYI368j48ajRPET56a0 YTyI/7pyWz3xJ1iGzHSbSsEY2uMICWexSJGfny4HR75qMPe2nEcu+sOrCLlB3pbP27 qPBfmNlm/sHPg== Date: Wed, 4 Sep 2024 16:44:03 +0200 From: Christian Brauner To: Vlastimil Babka Cc: Mike Rapoport , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Message-ID: <20240904-gegessen-kalziumreich-2817b07433b7@brauner> References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> <20240904-storch-worin-32db25e60f32@brauner> <23eb55c3-0a8c-404b-b787-9f21c2739c4e@suse.cz> <20240904-absuchen-gockel-8246820867b4@brauner> <24717bab-7d5d-4ed1-a17d-65d4676e22a9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24717bab-7d5d-4ed1-a17d-65d4676e22a9@suse.cz> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C614DA0015 X-Stat-Signature: ytyeupgq7sm7p4auuqqwmajo118ja4d8 X-Rspam-User: X-HE-Tag: 1725461048-974309 X-HE-Meta: U2FsdGVkX1+uVT7NA8HpZuk1TtafjM1j3y+gAWToxQcmzk2BhyCIpTwCA1MpYnBo8RVcguCxmZxsO++V4FKPUQFL3sVS2ICEsmU0Bi9+OUY5waEQLOftlwj1pxOyd7NgzLE+rsf/cDNN7cKD9x6sjFn7GKX1yDZancwWPYI1Wd9f0UohuzHY9DVqtYtqoVYNWJ9Yrr54wrXyMFM/kjeFeU0VRpuf9eKpYqbBwIwG62kcTEvMnPgM3c8V7Ub0WCLG3+J2JDocTEy93Nb1wJ1aLz8CJFQ6Um8xD42P4G5CnrRKgsUgtTE7RrE28LFGroSohgPAJC86+Cz668834k/4ag1eBUMNHNeGlfA++wA1qElXnplS0gN8+WUfXX3+q50b3RP4FrBo1JGB8V2Czle2B1D1SkkFZCi789hdZ2W4uR/qrrFDBMOYkAh/1s/Ze8tgSCliR4Cp2fM40FTtpQ9vUcminLHn3vqmUZvUiF0MXHjvKcggnvgkHebPHq3AuKnBTHiOP+hRCcoZ/Fv6BNfqFQF3XRAwgzGUboc3eJFitpDfpIUS1wY6bCR/SANy6K44LdSJh1tImeippsx3RHphjwrDjIkTz1uDVUOyddink7ucJM2r1Ku03Yf4Res5lTBZ6bIZoFRXHJs2bz1vKj5u6QieK+CL4/gATv2C0gei2YKsCA+XpFZDsEwrOKVe22fP9uq6TooCK5fWE2pb/UZMMSBq1ap1XQiHj4zdgxsDGvDYC9gbNNyJCmzu2B/amtXE/v9+irf0yWKIeDtf+9i9lYJU2FedW3qByY3PdFrXtJOuhHOqFazE/vnB55Z5y+DkzRgpY1YTtwi8EXHv0HbZvmPpAzgyf1wHc3Ztz4KPxqjufL3lC9tbneZbbpD26uo1Y9WzJMj70MFWCAI3zsS3i5XEubOblcpXex2FyweOtqOUhskyX7HHel9nkzEXezP/9CUtaZRz4Io5PBJQoJN D4U25prf bV5r/uFsi6X9ai4nh+5eQikn8tMc3bVG3WeE9l+aTKLwYJpPWTGvDih38BCUtdUEP6nhq/f+q2/c9vKaduKCTq4s0bXkRjo1OlDy5kFrDk9gy5a99KTzZrqyDb/Qa5nsi6iO1FRKzQMHMws08AJmYWUpsNJbiF6HVSKCaRQepZ5oP0w48vDZF+iAjTSAPp21iWHG9Yz2NfaARTuHCrxr1PikBV1B3v7MAgUsxGlCD6nTH1i1hl5GU6mv2SgfiuDNWwRlcujfVOk4RuN7XeoZjv3swThMwBx1Kd4goiNLZcFOa8hwADNIPMu4oIlPJ2fGEG1qfIwS/i/cGzlUg24fexXAOcYux5Fff73ZEoYMVQyVYU7tQpPIylJXzJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 03:33:30PM GMT, Vlastimil Babka wrote: > On 9/4/24 13:38, Christian Brauner wrote: > > On Wed, Sep 04, 2024 at 12:50:28PM GMT, Vlastimil Babka wrote: > >> On 9/4/24 11:45, Christian Brauner wrote: > >> > On Wed, Sep 04, 2024 at 08:14:24AM GMT, Mike Rapoport wrote: > >> >> On Tue, Sep 03, 2024 at 04:20:53PM +0200, Christian Brauner wrote: > >> >> > Use _Generic() to create a compatibility layer that type switches on the > >> >> > third argument to either call __kmem_cache_create() or > >> >> > __kmem_cache_create_args(). This can be kept in place until all callers > >> >> > have been ported to struct kmem_cache_args. > >> >> > > >> >> > Signed-off-by: Christian Brauner > >> >> > >> >> Reviewed-by: Mike Rapoport (Microsoft) > >> >> > >> >> > --- > >> >> > include/linux/slab.h | 13 ++++++++++--- > >> >> > mm/slab_common.c | 10 +++++----- > >> >> > 2 files changed, 15 insertions(+), 8 deletions(-) > >> >> > > >> >> > diff --git a/include/linux/slab.h b/include/linux/slab.h > >> >> > index aced16a08700..4292d67094c3 100644 > >> >> > --- a/include/linux/slab.h > >> >> > +++ b/include/linux/slab.h > >> >> > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > >> >> > unsigned int object_size, > >> >> > struct kmem_cache_args *args, > >> >> > slab_flags_t flags); > >> >> > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > >> >> > - unsigned int align, slab_flags_t flags, > >> >> > - void (*ctor)(void *)); > >> >> > + > >> >> > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > >> >> > + unsigned int align, slab_flags_t flags, > >> >> > + void (*ctor)(void *)); > >> >> > >> >> As I said earlier, this can become _kmem_cache_create and > >> >> __kmem_cache_create_args can be __kmem_cache_create from the beginning. > >> > >> I didn't notice an answer to this suggestion? Even if it's just that you > >> don't think it's worth the rewrite, or it's not possible because X Y Z. > >> Thanks. > > > > I'm confused. I sent two patches as a reply to the thread plus the > > answer below and there's two patches in v3 that you can use or drop. > > Right, that's the part below. But the suggestion above, and also in Mike's > reply to 02/12 was AFAICS to rename __kmem_cache_create_args to > __kmem_cache_create (since patch 02) and here __kmem_cache_create to > _kmem_cache_create. It just seemed odd to see no reaction to that (did I > miss or not receive it?). Oh, I see. I read it as a expressing taste and so I didn't bother replying. And I really dislike single underscore function names so I would like to avoid it and it also seems more confusing to me.