From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA2BCA0ED3 for ; Wed, 4 Sep 2024 11:39:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01D116B02A7; Wed, 4 Sep 2024 07:39:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10AA6B0391; Wed, 4 Sep 2024 07:39:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB2756B0390; Wed, 4 Sep 2024 07:39:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B92706B02A7 for ; Wed, 4 Sep 2024 07:39:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 346FA8128B for ; Wed, 4 Sep 2024 11:39:05 +0000 (UTC) X-FDA: 82526859450.15.B067841 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 70AF94000D for ; Wed, 4 Sep 2024 11:39:03 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FEXC1Eiv; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725449847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/oYortDEWM6ZIGYOk3zqfP2E6rtRp+4nHkHDqdPPM74=; b=kwnSVW5UGUZgB7UGY6R8t8sew+3AzUZZCzcucFLh6DCk6co9WJXd9z1rsUNXB9RQwzvLnu wWQgJPU9etGjvprVGl26fBakRruHbd249HwSRfJxWGgd2drqRgIvfiT88IRXHYjla7qUVS 44thSiMLJgHThENtW2GMlvTUYiLCLVg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725449847; a=rsa-sha256; cv=none; b=NDHMC9FVEtrmmOeYfxOZI92boaDBEurCepWBcB3wnrq+gOAa8MUAHtoy7L+TgQ1YWcrEe+ SVukOn1D8jmv8DI030QJDphWjn4DcJfuvhAANshKXqp14MXEyYGscigvTy0PrlFVTLrnYk 9pXBExxpK8UE8bPEGzL9S9wp17wEpFM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FEXC1Eiv; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EA9025C56E7; Wed, 4 Sep 2024 11:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39423C4CEC2; Wed, 4 Sep 2024 11:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725449942; bh=+w0xFoTV0Lh4uapfvz5wp1iY4crS8ZjQkBVqDb/Sj5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FEXC1Eiv8SQnU2Vu7kYshplTkF4FdzhAl+YEhVvcaqm1UqSYNNn8VwmBBjvDCAUZF coVR0WmfSKTc9SDCfNtlDghkwaEGrlbDJ03DpMj8C+X3vXkoPG5bO8TeaA9ArYlpfM /UxiPQ9732dLzjoJTA+g1FRePlw22E/TxKCjqj7EsFylUXmcX5FnbE/Gktnw+8tSeA EGq6EjLBqK0PjAJMw3MBJI97WnDshAojp5cV4EBcS2OrwMre6KXx8oRcIvEQL4LEf2 XNkLzwBg6HgTGjIchWJhXP3VkrM95VGHXEN+kuySXEhqqFTa0h4pyXGCeQibei0D3N Sz/XfJi95VW1A== Date: Wed, 4 Sep 2024 13:38:57 +0200 From: Christian Brauner To: Vlastimil Babka Cc: Mike Rapoport , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Message-ID: <20240904-absuchen-gockel-8246820867b4@brauner> References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> <20240904-storch-worin-32db25e60f32@brauner> <23eb55c3-0a8c-404b-b787-9f21c2739c4e@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <23eb55c3-0a8c-404b-b787-9f21c2739c4e@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 70AF94000D X-Stat-Signature: 1g1i9y9f8irg68gz5uuswsnn6jso9crt X-HE-Tag: 1725449943-54372 X-HE-Meta: U2FsdGVkX1/mkwVE3vTK2WYzuMGf0QUFT+TJx2mvzQ9XYrVb5u+cywUVLr7kJ57YOtQMaiUEjy8hy4/v1sjN5WDAf49l7ZiJJHCFXL90yaZ78VLltE5u7ZTvFZoI5H+10UvtSVY2V5MkU5IhGIerbP2MxjxL3rEXGVJkauiqVEjpYc7f0KvJeL0vnS1kpgkq949fPQjxvKSf6LT1s6sk69DnjaeNegwoiTLskLFUg7kjnfHV6XYNI3GldGBWNBiWHn3EmN3V5he2mtqSwyZ1krUmL8Uv0beqQGmP4k7Kc2lSSHyTMygjWWISTQdhS3GRAod2az4cwU4ojwZ3JxCssg/6Gt899VvIwN1hG2hbgYqtEPgw2/EdXl/i8Mf9sB4dCg/M/hv2M0Fy99b/FfuVmaJ7qtaB2RhGTPYM0HzbT0W4GQwejmJy9GwWa/mvIuN6qq2s4QbN8kaB94tvy0eokmD+yjVrUlgJ+hF++wNGKEKJasjappy7xoTZZHVZhERI8QCDbWtS4ht5oN7cPFp1AYVWZguQxIDLL4LKiVtgf4uV17pv+mk8DpWf7ltbCkdZY1dtVHicRujT7RijhdUSTAoYWA0SwldZEixvMTNWTwmMNuPRrXMXP2Tjnv+T8cjmHYzsZ1Jgb4T7qyvA5jR7K6qU4HRL+FZ3pdcOKueoyYtLMBWQgmambES67hyFox70pnBP4Fn9uSzCRjwqwtFeeHQkufbp4jsZIJR/R2b8pXa50iXch1zkZrGdmCQfeAyHlWBbpXmYKuoyKPUWeaLWLXIALOnVFYJfnQr7wLM+Yp2qC5nUlJzY2EmvBjcPU/jXd5ifZWzVAlefdWg4+5D0jjjVOtT/wZmyJvT32sOx3R4EGaJzGbRp92TQU3VUV6T4yVE5sph0jJUUpmpyfQmO1AgOqrXKc/BqVNTdpHSAkHPa1O1UzNQo2FT4uTFcP0o4hLmc7nyR2Ahjktoj1fj am64xhKL eJI6LoAKwXsBc9mTun6TVr8g1b15/ZDjp/O+15VruQAfVv/fF4pC7g75ad86JgUJdbzAuxHxz/N/4jujA0leW+n1U2nLLV8Zcz9QjOqUBWQnAycN/ttIHE1kjrrTSwAaSxXcBeGEOOViaULo/M9ynrAKp07/iQElqAIHTq/C4bjbmtGqqVOHJB5n7zKgbiV432wpGhRy7LY+5kUz/tjdvaQ8pyA4P1iqL8JCLpXoc6f7hoPe2CFOTsnK8+F1D7Z73UvepEAMoC8YFtTpR4Mqytvo8eBAgu5kI7zg06gKTilXKOFiqAoLOng6LXeJIEDtD9T3Q34A+0lIYAxCf3CX/GBEbgWO80oE4nWceiRXKxttm/8BDXI+9Mpt43g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 12:50:28PM GMT, Vlastimil Babka wrote: > On 9/4/24 11:45, Christian Brauner wrote: > > On Wed, Sep 04, 2024 at 08:14:24AM GMT, Mike Rapoport wrote: > >> On Tue, Sep 03, 2024 at 04:20:53PM +0200, Christian Brauner wrote: > >> > Use _Generic() to create a compatibility layer that type switches on the > >> > third argument to either call __kmem_cache_create() or > >> > __kmem_cache_create_args(). This can be kept in place until all callers > >> > have been ported to struct kmem_cache_args. > >> > > >> > Signed-off-by: Christian Brauner > >> > >> Reviewed-by: Mike Rapoport (Microsoft) > >> > >> > --- > >> > include/linux/slab.h | 13 ++++++++++--- > >> > mm/slab_common.c | 10 +++++----- > >> > 2 files changed, 15 insertions(+), 8 deletions(-) > >> > > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h > >> > index aced16a08700..4292d67094c3 100644 > >> > --- a/include/linux/slab.h > >> > +++ b/include/linux/slab.h > >> > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > >> > unsigned int object_size, > >> > struct kmem_cache_args *args, > >> > slab_flags_t flags); > >> > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > >> > - unsigned int align, slab_flags_t flags, > >> > - void (*ctor)(void *)); > >> > + > >> > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > >> > + unsigned int align, slab_flags_t flags, > >> > + void (*ctor)(void *)); > >> > >> As I said earlier, this can become _kmem_cache_create and > >> __kmem_cache_create_args can be __kmem_cache_create from the beginning. > > I didn't notice an answer to this suggestion? Even if it's just that you > don't think it's worth the rewrite, or it's not possible because X Y Z. > Thanks. I'm confused. I sent two patches as a reply to the thread plus the answer below and there's two patches in v3 that you can use or drop. > > >> And as a followup cleanup both kmem_cache_create_usercopy() and > >> kmem_cache_create() can be made static inlines. > > > > Seems an ok suggestion to me. See the two patches I sent out now. >