From: Anthony Yznaga <anthony.yznaga@oracle.com>
To: akpm@linux-foundation.org, willy@infradead.org,
markhemm@googlemail.com, viro@zeniv.linux.org.uk,
david@redhat.com, khalid@kernel.org
Cc: anthony.yznaga@oracle.com, andreyknvl@gmail.com,
dave.hansen@intel.com, luto@kernel.org, brauner@kernel.org,
arnd@arndb.de, ebiederm@xmission.com, catalin.marinas@arm.com,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mhiramat@kernel.org, rostedt@goodmis.org,
vasily.averin@linux.dev, xhao@linux.alibaba.com, pcc@google.com,
neilb@suse.de, maz@kernel.org
Subject: [RFC PATCH v3 10/10] mshare: add MSHAREFS_CREATE_MAPPING
Date: Tue, 3 Sep 2024 16:22:41 -0700 [thread overview]
Message-ID: <20240903232241.43995-11-anthony.yznaga@oracle.com> (raw)
In-Reply-To: <20240903232241.43995-1-anthony.yznaga@oracle.com>
Add an ioctl for mapping objects within an mshare region. The
arguments are the same as mmap() although only shared anonymous
memory with some restrictions is supported initially.
Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
---
include/uapi/linux/msharefs.h | 9 +++++
mm/mshare.c | 71 +++++++++++++++++++++++++++++++++++
2 files changed, 80 insertions(+)
diff --git a/include/uapi/linux/msharefs.h b/include/uapi/linux/msharefs.h
index c7b509c7e093..fea0afdf000d 100644
--- a/include/uapi/linux/msharefs.h
+++ b/include/uapi/linux/msharefs.h
@@ -20,10 +20,19 @@
*/
#define MSHAREFS_GET_SIZE _IOR('x', 0, struct mshare_info)
#define MSHAREFS_SET_SIZE _IOW('x', 1, struct mshare_info)
+#define MSHAREFS_CREATE_MAPPING _IOW('x', 2, struct mshare_create)
struct mshare_info {
__u64 start;
__u64 size;
};
+struct mshare_create {
+ __u64 addr;
+ __u64 size;
+ __u64 offset;
+ __u32 prot;
+ __u32 flags;
+ __u32 fd;
+};
#endif
diff --git a/mm/mshare.c b/mm/mshare.c
index 8f47c8d6e6a4..7b89bf7f5ffc 100644
--- a/mm/mshare.c
+++ b/mm/mshare.c
@@ -16,6 +16,7 @@
#include <linux/fs.h>
#include <linux/fs_context.h>
+#include <linux/mman.h>
#include <linux/spinlock_types.h>
#include <uapi/linux/magic.h>
#include <uapi/linux/msharefs.h>
@@ -154,12 +155,65 @@ msharefs_set_size(struct mm_struct *mm, struct mshare_data *m_data,
return 0;
}
+static long
+msharefs_create_mapping(struct mm_struct *mm, struct mshare_data *m_data,
+ struct mshare_create *mcreate)
+{
+ unsigned long mshare_start, mshare_end;
+ unsigned long mapped_addr;
+ unsigned long populate = 0;
+ unsigned long addr = mcreate->addr;
+ unsigned long size = mcreate->size;
+ unsigned int fd = mcreate->fd;
+ int prot = mcreate->prot;
+ int flags = mcreate->flags;
+ vm_flags_t vm_flags;
+ int err = -EINVAL;
+
+ mshare_start = m_data->minfo.start;
+ mshare_end = mshare_start + m_data->minfo.size;
+
+ if ((addr < mshare_start) || (addr >= mshare_end) ||
+ (addr + size > mshare_end))
+ goto out;
+
+ /*
+ * XXX Keep things simple initially and only allow the mapping of
+ * anonymous shared memory at fixed addresses without unmapping.
+ */
+ if ((flags & (MAP_SHARED | MAP_FIXED)) != (MAP_SHARED | MAP_FIXED))
+ goto out;
+
+ if (fd != -1)
+ goto out;
+
+ flags |= MAP_FIXED_NOREPLACE;
+ vm_flags = VM_NOHUGEPAGE;
+
+ if (mmap_write_lock_killable(mm)) {
+ err = -EINTR;
+ goto out;
+ }
+
+ err = 0;
+ mapped_addr = __do_mmap(NULL, addr, size, prot, flags, vm_flags,
+ 0, &populate, NULL, mm);
+
+ if (IS_ERR_VALUE(mapped_addr))
+ err = (long)mapped_addr;
+
+ mmap_write_unlock(mm);
+out:
+ return err;
+}
+
static long
msharefs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
{
struct mshare_data *m_data = filp->private_data;
struct mm_struct *mm = m_data->mm;
struct mshare_info minfo;
+ struct mshare_create mcreate;
switch (cmd) {
case MSHAREFS_GET_SIZE:
@@ -188,6 +242,23 @@ msharefs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
return msharefs_set_size(mm, m_data, &minfo);
+ case MSHAREFS_CREATE_MAPPING:
+ if (copy_from_user(&mcreate, (struct mshare_create __user *)arg,
+ sizeof(mcreate)))
+ return -EFAULT;
+
+ /*
+ * validate mshare region
+ */
+ spin_lock(&m_data->m_lock);
+ if (m_data->minfo.start == 0) {
+ spin_unlock(&m_data->m_lock);
+ return -EINVAL;
+ }
+ spin_unlock(&m_data->m_lock);
+
+ return msharefs_create_mapping(mm, m_data, &mcreate);
+
default:
return -ENOTTY;
}
--
2.43.5
next prev parent reply other threads:[~2024-09-03 23:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 23:22 [RFC PATCH v3 00/10] Add support for shared PTEs across processes Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 01/10] mm: Add msharefs filesystem Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 02/10] mm/mshare: pre-populate msharefs with information file Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 03/10] mm/mshare: make msharefs writable and support directories Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 04/10] mm/mshare: allocate an mm_struct for msharefs files Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 05/10] mm/mshare: Add ioctl support Anthony Yznaga
2024-10-14 20:08 ` Jann Horn
2024-10-16 0:49 ` Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 06/10] mm/mshare: Add vm flag for shared PTEs Anthony Yznaga
2024-09-03 23:40 ` James Houghton
2024-09-03 23:58 ` Anthony Yznaga
2024-10-07 10:24 ` David Hildenbrand
2024-10-07 23:03 ` Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 07/10] mm/mshare: Add mmap support Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 08/10] mm/mshare: Add basic page table sharing support Anthony Yznaga
2024-10-07 8:41 ` Kirill A. Shutemov
2024-10-07 17:45 ` Anthony Yznaga
2024-09-03 23:22 ` [RFC PATCH v3 09/10] mm: create __do_mmap() to take an mm_struct * arg Anthony Yznaga
2024-10-07 8:44 ` Kirill A. Shutemov
2024-10-07 17:46 ` Anthony Yznaga
2024-09-03 23:22 ` Anthony Yznaga [this message]
2024-10-02 17:35 ` [RFC PATCH v3 00/10] Add support for shared PTEs across processes Dave Hansen
2024-10-02 19:30 ` Anthony Yznaga
2024-10-02 23:11 ` Dave Hansen
2024-10-03 0:24 ` Anthony Yznaga
2024-10-07 8:44 ` David Hildenbrand
2024-10-07 15:58 ` Dave Hansen
2024-10-07 16:27 ` David Hildenbrand
2024-10-07 16:45 ` Sean Christopherson
2024-10-08 1:37 ` Anthony Yznaga
2024-10-07 8:48 ` David Hildenbrand
2024-10-07 9:01 ` Kirill A. Shutemov
2024-10-07 19:23 ` Anthony Yznaga
2024-10-07 19:41 ` David Hildenbrand
2024-10-07 19:46 ` Anthony Yznaga
2024-10-14 20:07 ` Jann Horn
2024-10-16 0:59 ` Anthony Yznaga
2024-10-16 13:25 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903232241.43995-11-anthony.yznaga@oracle.com \
--to=anthony.yznaga@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=khalid@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=markhemm@googlemail.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=neilb@suse.de \
--cc=pcc@google.com \
--cc=rostedt@goodmis.org \
--cc=vasily.averin@linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox