From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1170BCD37AA for ; Tue, 3 Sep 2024 17:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 974B16B0083; Tue, 3 Sep 2024 13:55:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9242F8D018A; Tue, 3 Sep 2024 13:55:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EBAC6B0096; Tue, 3 Sep 2024 13:55:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 611BF6B0083 for ; Tue, 3 Sep 2024 13:55:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 08140160730 for ; Tue, 3 Sep 2024 17:55:34 +0000 (UTC) X-FDA: 82524179388.15.8D4FE79 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf25.hostedemail.com (Postfix) with ESMTP id EFAB9A0012 for ; Tue, 3 Sep 2024 17:55:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=rdora122; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725386062; a=rsa-sha256; cv=none; b=ZD8tuCIg/bRNAnjxPO09VSnB/O1Zax6x5YA1AXcJp8INcrHXbK07DE1eyethymdNjBC0oo oNHjmNBbv7kS4ZsCuBudJhuI3m0YjisXFyImfb41U9wxQUeL3eY/pAl1BOiX3oWMH20wvM EvVwvW3awpsUIOlo12whhnRga2ICECY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=rdora122; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725386062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N/Q1h4ajHNabaJYI3kmNs7vt5x1dUD7YjNa66CSW5iI=; b=yNw7n+6KOyAzi4DqPRhnK9srqBqbMuUjGNRbqM2CKpr4G+0NwmlukgyeVs7r+xf0cXvKJi uZKlVUhgDESPAmarHDNm4kd8TWBZLh2G6BqWUbMjFW9ttZaVXBdIMVrLTpEqXyfaraY3vL 1YGC/lgqHgY0WkLZGBJgFOW5ozMra7M= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7a8160a7239so286314385a.3 for ; Tue, 03 Sep 2024 10:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1725386131; x=1725990931; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N/Q1h4ajHNabaJYI3kmNs7vt5x1dUD7YjNa66CSW5iI=; b=rdora122KHNEybBnER4gTijm4akSADyGfHF3hKMCI0LXMqCMO6YNZL/cFFxBwONUCW StjGh4XDVeAVQj+wpBsGaFUb3TuAUCY0UlwFg2qAGaE6cuTLvXYqjq4Pbrygd09I2/lo JLaxOT50coBejnO0+ErdSfRif4YG86esmOfTuJgW3FZgrxN6fUNb7V49pBCJPSqLnW9t 7XpWYSuqhFewr59N/Zxag9m5wXQ6z8ZOrYfj1Z9BUpK/nzh5fd+XFn9p4wFzxuaXpdPA 1WFMNYIfdHnRy9j/WS7UPD8z6ZMHRL18YyK1ahcEgz9jNPOSAlpQpG0stRuqZwznKewi 3/RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725386131; x=1725990931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N/Q1h4ajHNabaJYI3kmNs7vt5x1dUD7YjNa66CSW5iI=; b=Z9ifYuQptRKAVL4x8PCkFaXXlsm4P2YYMmmaLT7ZBpYfEGsEMDHwc7Pmgg3obg0/lR i2O1KyPVvYrmoYI0L7Bpow5rgz7dN8ECV3iEy14T8x8CGvmuB+vCeERehQPIcIrH9ZWs UdOBnIblqtBWQi/W0opRUpAXgZxIk4GyX1/CBszaLVP4g9RvlLKt4hH1jR6Gb1ikH06d uMhKf2WML3q5KFZUYPB1v8dFx0/jRNb6nnrszz9FUF35lo/aAyXk4UENYxEh9BmGEE1J sV+Yy0sd9b+qD8cfhtVaGQhflGcqJrK8WaMTAE8J3KIPrl79Wfq7iQHL0k6r1knIJNEM tG0w== X-Forwarded-Encrypted: i=1; AJvYcCW9SsM4/BHDXvunCF8/88IunoG/Zw8LSdsc8sd3Kyzx7S49ts+EcvPlX6e7Du0+9YBAaks8hs83Tw==@kvack.org X-Gm-Message-State: AOJu0YxbXddT3tXkIfjKNxTNH3vzDZVURzRTbvDGm05JxcYomxWum+zH CTI7yqcvvZCTwC8/IPyqrRIHIScPgN2hmmZcOLp3lKcfrtL40ntTv8THgM9u/Es= X-Google-Smtp-Source: AGHT+IFgxYH4P9t/++E4OuacuCZCjGeccSamQH/800JhD0AraoieCe4tQyyQDrgXM82aAx9boW2//g== X-Received: by 2002:a05:620a:3909:b0:7a7:faf4:9aab with SMTP id af79cd13be357-7a804186b9amr2000159185a.4.1725386130760; Tue, 03 Sep 2024 10:55:30 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a806d60b35sm547183985a.118.2024.09.03.10.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 10:55:30 -0700 (PDT) Date: Tue, 3 Sep 2024 13:55:28 -0400 From: Johannes Weiner To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Kconfig: fixup zsmalloc configuration Message-ID: <20240903175528.GA1190078@cmpxchg.org> References: <20240903040143.1580705-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903040143.1580705-1-senozhatsky@chromium.org> X-Rspamd-Queue-Id: EFAB9A0012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wyb3agfyjuk6q5p4h64tdhr5brgieh63 X-HE-Tag: 1725386131-543905 X-HE-Meta: U2FsdGVkX1/Z+bqbe3+AxE+IJpTaGz4KwNETQg0LsnM4vinAdpZMjQIPVbtJ/P3RyXOjMnSex2l6baKADnW2UpjXjXOy/h7Xe/NbBVtVBiAaKhtWb745dkqw00qQZ99VfQdb3fuV2LKxKJBgKkp807HBZ2ZE1AZVvquFkStydZGpmoAfAgRreAetWuZ753pwlLFC+tLA55nryCPomYQoGzH2qUllcdSMhcL9p5oBoCaSzRSE9Jx6sG9ksbQCZFD7R0DuAeoODOIeI062A/9tcEAFaGMJkVGeS8yS+x3nyW60QOtj3O1T72RftyWWKVRtWVATbMyQl98fZ88O7P/clDYlFp2c689LMjk5v2x6AaTJKjyI3fe2q1UG6DVtp6y0/5aJ5PAfPA+tJRrRbfkI4ETvbdvG6kKG/JOZ9FihvXoD5QahXXz8xUTzuSdxZ2JCgF8N82joYHulRYhQ9kjAJLnPm4KDR4Bmg+picmdIl5Ak6z/2NZ7BOnm8FyJdEJDgJ5d305NHzI/W7doqrJLGJInXSDjHPKJIjSztbODED4Z4IAj8Nbs2ZQd/uWuC86ssgdcRsZqEJxwtzALRFeZivRDfh/TR0YT7VtmyhYz7w4W0ThG5nio5xMzQzO8oq6CBJZJCqE2HNZEFGaxiyCDgUGoZuUl4oX27digS/JOvQiQJuzC33s0VEmvpPuaDqLXlujEdte11aGedgjeUWvMxsuHl6VIIC/tNwA1wlpKmjXaCQtJ9ANNFtoqu3/9WNldvoKNn2YOFl+K8VRbgrX1GM78PDO9AXuik9uzQtHYjsX6/j473riNmhQ4VSdIuC+J5jBj8BtoRan8Y5dOvYx4gjVhMfpcYm0b20uMwNGEmbxCZRcwl+DPEGdd7CRh4jSHz1hqkTZz3CMK1PLgBdywJVeHL++r/jnXytplSHPhAKK7sjA9ihfMXvL3txkYswGIsxkO+mehp7J7zOil6xNE DVRclUfe 3qKyh7pdn/2U7ah89CWsg2O+Tcigbvll8p2EflzPnCfPFaKRlQEKQTxETzBD1KQ8sIsCT6mH76w1w4xp4i4/hTkq9eluYT4EzzN3EFy/fwms6fbBP9hhrhyIRLjxxamX2aXyZ8fY8LILlLDq6NHBgjvnZ3Nn8NxcJvkir+V29Ti242UMoYUpLW3OgQZrysX6HHW7XtHAmj0DI27cGH4+5pndPbLrQZuj8gjS9tBVq85h548Xca5omPYCKkP+0UcX3lDfjTppU9OPpvCTD+rFZ1p9LPW8Z/CBVisJG8I/gFOGWBFJzoW2bCaFteG/7zli8StajpJxw3TJCk+fB49CAqSbPPX2C1yH3c54BZJ1NyKtoa99RkBbhB6GOGmf9WhUjX3eusFKSumJ2PN/OqBmCiwmpjpvB1/Sd5mxa0qVbLp2duQCFdBFfmfmsM9b80aCQIH2ilDXvacka1QVMNPeSUezW1Y/G6vTak5ibdCqSHLeppe3aEt46wbjweA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 01:00:22PM +0900, Sergey Senozhatsky wrote: > zsmalloc is not exclusive to zswap. Commit aa3ba6d72ce0 > ("mm: Kconfig: fixup zsmalloc configuration") made CONFIG_ZSMALLOC > only visible when CONFIG_ZSWAP is selected, which makes it > impossible to menuconfig zsmalloc-specific features (stats, > chain-size, etc.) on systems that use ZRAM but don't have ZSWAP > enabled. > > Make zsmalloc depend on both ZRAM and ZSWAP. > > Fixes: Fixes: aa3ba6d72ce0 ("mm: Kconfig: fixup zsmalloc configuration") I can't find this commit upstream. It looks like this was actually broken by commit b3fbd58fcbb10725a1314688e03b1af6827c42f9 Author: Johannes Weiner Date: Thu May 19 14:08:53 2022 -0700 mm: Kconfig: simplify zswap configuration instead? The patch itself looks good to me. > Signed-off-by: Sergey Senozhatsky > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index b23913d4e47e..1aa282e35dc7 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -188,7 +188,7 @@ config Z3FOLD > > config ZSMALLOC > tristate > - prompt "N:1 compression allocator (zsmalloc)" if ZSWAP > + prompt "N:1 compression allocator (zsmalloc)" if (ZSWAP || ZRAM) > depends on MMU > help > zsmalloc is a slab-based memory allocator designed to store > -- > 2.46.0.469.g59c65b2a67-goog >