From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>, Theodore Ts'o <tytso@mit.edu>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [PATCH 5/9] vdso: Split linux/minmax.h
Date: Tue, 3 Sep 2024 16:14:33 +0100 [thread overview]
Message-ID: <20240903151437.1002990-6-vincenzo.frascino@arm.com> (raw)
In-Reply-To: <20240903151437.1002990-1-vincenzo.frascino@arm.com>
The VDSO implementation includes headers from outside of the
vdso/ namespace.
Split linux/minmax.h to make sure that the generic library
uses only the allowed namespace.
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
include/linux/minmax.h | 28 +---------------------------
include/vdso/minmax.h | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+), 27 deletions(-)
create mode 100644 include/vdso/minmax.h
diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index 98008dd92153..846e3fa65c96 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -6,6 +6,7 @@
#include <linux/compiler.h>
#include <linux/const.h>
#include <linux/types.h>
+#include <vdso/minmax.h>
/*
* min()/max()/clamp() macros must accomplish three things:
@@ -84,17 +85,6 @@
#define __types_ok3(x,y,z,ux,uy,uz) \
(__sign_use(x,ux) & __sign_use(y,uy) & __sign_use(z,uz))
-#define __cmp_op_min <
-#define __cmp_op_max >
-
-#define __cmp(op, x, y) ((x) __cmp_op_##op (y) ? (x) : (y))
-
-#define __cmp_once_unique(op, type, x, y, ux, uy) \
- ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
-
-#define __cmp_once(op, type, x, y) \
- __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
-
#define __careful_cmp_once(op, x, y, ux, uy) ({ \
__auto_type ux = (x); __auto_type uy = (y); \
BUILD_BUG_ON_MSG(!__types_ok(x,y,ux,uy), \
@@ -204,22 +194,6 @@
* Or not use min/max/clamp at all, of course.
*/
-/**
- * min_t - return minimum of two values, using the specified type
- * @type: data type to use
- * @x: first value
- * @y: second value
- */
-#define min_t(type, x, y) __cmp_once(min, type, x, y)
-
-/**
- * max_t - return maximum of two values, using the specified type
- * @type: data type to use
- * @x: first value
- * @y: second value
- */
-#define max_t(type, x, y) __cmp_once(max, type, x, y)
-
/*
* Do not check the array parameter using __must_be_array().
* In the following legit use-case where the "array" passed is a simple pointer,
diff --git a/include/vdso/minmax.h b/include/vdso/minmax.h
new file mode 100644
index 000000000000..26724f34c513
--- /dev/null
+++ b/include/vdso/minmax.h
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __VDSO_MINMAX_H
+#define __VDSO_MINMAX_H
+
+#ifndef __ASSEMBLY__
+
+#include <linux/compiler.h>
+
+#define __cmp_op_min <
+#define __cmp_op_max >
+
+#define __cmp(op, x, y) ((x) __cmp_op_##op (y) ? (x) : (y))
+
+#define __cmp_once_unique(op, type, x, y, ux, uy) \
+ ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
+
+#define __cmp_once(op, type, x, y) \
+ __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
+
+/**
+ * min_t - return minimum of two values, using the specified type
+ * @type: data type to use
+ * @x: first value
+ * @y: second value
+ */
+#define min_t(type, x, y) __cmp_once(min, type, x, y)
+
+/**
+ * max_t - return maximum of two values, using the specified type
+ * @type: data type to use
+ * @x: first value
+ * @y: second value
+ */
+#define max_t(type, x, y) __cmp_once(max, type, x, y)
+
+#endif /* !__ASSEMBLY__ */
+
+#endif /* __VDSO_MINMAX_H */
--
2.34.1
next prev parent reply other threads:[~2024-09-03 15:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 15:14 [PATCH 0/9] vdso: Use only headers from the vdso/ namespace Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 1/9] x86: vdso: Introduce asm/vdso/mman.h Vincenzo Frascino
2024-09-03 15:16 ` Jason A. Donenfeld
2024-09-03 15:23 ` Vincenzo Frascino
2024-09-04 16:56 ` Christophe Leroy
2024-09-06 10:55 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 2/9] vdso: Introduce vdso/mman.h Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Vincenzo Frascino
2024-09-04 14:52 ` Arnd Bergmann
2024-09-04 15:05 ` Christophe Leroy
2024-09-06 11:26 ` Vincenzo Frascino
2024-09-06 11:20 ` Vincenzo Frascino
2024-09-06 19:19 ` Arnd Bergmann
2024-09-06 18:40 ` Christophe Leroy
2024-09-08 20:48 ` Arnd Bergmann
2024-09-10 12:28 ` Christophe Leroy
2024-09-10 15:05 ` Arnd Bergmann
2024-09-04 17:14 ` Christophe Leroy
2024-09-03 15:14 ` [PATCH 4/9] vdso: Introduce vdso/page.h Vincenzo Frascino
2024-09-04 17:16 ` Christophe Leroy
2024-09-06 11:35 ` Vincenzo Frascino
2024-09-03 15:14 ` Vincenzo Frascino [this message]
2024-09-04 17:17 ` [PATCH 5/9] vdso: Split linux/minmax.h Christophe Leroy
2024-09-04 17:23 ` Arnd Bergmann
2024-09-06 11:41 ` Vincenzo Frascino
2024-09-08 19:58 ` David Laight
2024-09-03 15:14 ` [PATCH 6/9] vdso: Split linux/array_size.h Vincenzo Frascino
2024-09-04 17:18 ` Christophe Leroy
2024-09-06 11:42 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 7/9] x86: vdso: Modify asm/vdso/getrandom.h to include datapage Vincenzo Frascino
2024-09-04 17:19 ` Christophe Leroy
2024-09-06 11:48 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 8/9] vdso: Modify vdso/getrandom.h to include the asm header Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 9/9] vdso: Modify getrandom to include the correct namespace Vincenzo Frascino
2024-09-04 17:26 ` Christophe Leroy
2024-09-06 11:52 ` Vincenzo Frascino
2024-09-06 12:04 ` Christophe Leroy
2024-09-06 12:40 ` Vincenzo Frascino
2024-09-06 12:49 ` Christophe Leroy
2024-09-06 12:51 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903151437.1002990-6-vincenzo.frascino@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox