From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90996CD3440 for ; Tue, 3 Sep 2024 21:28:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 073C68D01E0; Tue, 3 Sep 2024 17:28:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 022C28D016E; Tue, 3 Sep 2024 17:28:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53F08D01E0; Tue, 3 Sep 2024 17:28:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C8C2E8D016E for ; Tue, 3 Sep 2024 17:28:52 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 51CB4160AA7 for ; Tue, 3 Sep 2024 21:28:52 +0000 (UTC) X-FDA: 82524716904.30.202DAA0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 9CA5A1C0025 for ; Tue, 3 Sep 2024 21:28:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iL8+8llt; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725398804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ul9p4of21tYIe26VhrAiyZDnfWQ16G7EakZG5sgMd1Y=; b=bTr5bMhOzPNFdqpjinpCf0IAxIK5633QptY4gTn0PZ3Wyk6Uwj1rx4dvePuzLxlckuD+0H 0b1/rirSe0uWc0ZMNtEN72x7/YXI3SIdx0EviDaZ4xEsX/PQFm3TAj7mWnMl1OSTsLnwNx /r3IBzP3lknAgYvjFfYRs11T01tbAag= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iL8+8llt; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725398804; a=rsa-sha256; cv=none; b=VKdQe/XMOQ0VsrYNYknyVkyoVSolfFVrYvV7h0P/yfkFQwg78nMeHvYmBsEi5fCcgbTpcn t0qUd1Z7ryPNdZn1iPi8kqFsqmZ3mq/PcJru7nqi0t2w3aPWyp9cFQmk+DcBuuL/Eziyky F07cVch1nq/1HNSiI9Z7LmbLFc7113U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 915DA5C562B; Tue, 3 Sep 2024 21:28:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81160C4CEC4; Tue, 3 Sep 2024 21:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725398927; bh=oYo7owdrnfin/sBqd7d7aNhH03aPOu6TESP3vci0CV8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iL8+8lltBrR70/LOfusoFuTDL/SgxYToZjj4YnQ0nSTCGmQvEJ9MADo1o8uWFoedu 4s3UQx7qIYfRX0QlEPX5PMXg22xUo+CVxCiRChxgeu/UAcIGT7UogSGVic/yOl0Uv0 P+dAIyi2YjU5PuQS8CTFt2xLpbsFf4iA+fAPjasw= Date: Tue, 3 Sep 2024 14:28:47 -0700 From: Andrew Morton To: Johannes Weiner Cc: Sergey Senozhatsky , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Kconfig: fixup zsmalloc configuration Message-Id: <20240903142847.f03362654cac51bf4617fe18@linux-foundation.org> In-Reply-To: <20240903175528.GA1190078@cmpxchg.org> References: <20240903040143.1580705-1-senozhatsky@chromium.org> <20240903175528.GA1190078@cmpxchg.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9CA5A1C0025 X-Stat-Signature: st8pci43qcpkfffm1tugws1zptcwykb4 X-Rspam-User: X-HE-Tag: 1725398930-901124 X-HE-Meta: U2FsdGVkX18KwjzUj7Vs/j1pwiGL58cqf5V24KsUL5wPRhj3WST0AnOBEvKKT4A/0a9BnlIaY36AGqHkYwthVWvzli74FoG/3W5dO6zW/OgttVM4GElJMX8Jye+oHpwV79YpfSqYhkTI4H7X1dVNilw66udUmBtGf9Xx29/yMcsETIkbJO9h5yUKen9hyE+n7DbXKvhGHO1SnOJ8uE/wyp9rhvMFrUiC6V3csE9Bgm7QUUR+ExWpsDPNO7f8/GiPY5lV6szOqFlrrdRqCmXdXLeCM1D0kIHkOll95Ni0xUuacPrxIb18PNV6XGo6EcHuKdrVcv182+JCR3nbxJUPNKUBI3r9AO+Ax3Pbhsk2vGU9hlCgouSp2FVbJt384JOiCNS7q+DRK9EGHKPsQO2YMlNbaokf+cGalFTOgcHcmN3CSHzAYXjI9wz87aOADSk2AvVH4H/t2EbmNfCDPD++XaCmyyIj3SZijkYOTwhSkjEsU+sv2STRZrrHC24F87X4sNsIdppUOZp65siHWCzz6yy0YUxlwQXFK/tIJ2IwCkc8cDGW/OQxkZOb+kOY7w+oWfPtxynr2bRC7bNbVE9S29d1B/UQ2ZQkGcnRtduktrqRcpuEhpZkugq2Rt+m68Y5yDaSHO3P11Fu8lqQDqqWymvx5e5gY8KWPvOlox6BUQHfCmPRf2pal2DlEWqU5VFWCqB4Ax5eeoByQeT1JW1gbPEkxQ+ocV1TvQaXYg2h6KvJY2B6Mi3iiPfPFoKK40Tczk4MIQMyfZ03hkUbmock0+TyJobCHlPA4QSvW5tAP6qwwitKUIJz1Ph1QVsYcsrBL+XEWLgcM03oIRD0PdJ1UPkhSBSkktZdkOtl7B1/GTuWQU633TcgWPjxBx0MQVgvLRcW0TSl1cbKH+Xd0e73Y/WfCt/c6FDaEZ4bLOaxd6Y7uPR+TR/zc9lXPQgLAfR0NGrG2rnNtirR/yOx6pI jcXff0Us yNldspGyAk8/1UfSF6euWgprNQ8RxtbsIARTY6pjO8uODGGSAvMP21kuPxE84jc4EZr26i2MJ2mvLSdoBP+XAQbPmtkg2hKbpqykWnQza0yMIRrX7u40T2+vdGGKYX4I26hp/iQcQnCxIYtfQijAR9rXuDV36Nv2yO/fFDcTPRDaKY9Pm6CQETd6rGMs51Kd+otkIRFTKZ+xGFDPmb3TFgyyVAyiXyzflkMIixp+iQkhF5MKL+EnjiPGOcttfgCO1PyXFSV5iX/bAfX0IATQxNek5KafgSd3Pt10rf9sFsRrXDP9yICwTR2fb3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 3 Sep 2024 13:55:28 -0400 Johannes Weiner wrote: > On Tue, Sep 03, 2024 at 01:00:22PM +0900, Sergey Senozhatsky wrote: > > zsmalloc is not exclusive to zswap. Commit aa3ba6d72ce0 > > ("mm: Kconfig: fixup zsmalloc configuration") made CONFIG_ZSMALLOC > > only visible when CONFIG_ZSWAP is selected, which makes it > > impossible to menuconfig zsmalloc-specific features (stats, > > chain-size, etc.) on systems that use ZRAM but don't have ZSWAP > > enabled. > > > > Make zsmalloc depend on both ZRAM and ZSWAP. > > > > Fixes: Fixes: aa3ba6d72ce0 ("mm: Kconfig: fixup zsmalloc configuration") > > I can't find this commit upstream. > > It looks like this was actually broken by > > commit b3fbd58fcbb10725a1314688e03b1af6827c42f9 > Author: Johannes Weiner > Date: Thu May 19 14:08:53 2022 -0700 > > mm: Kconfig: simplify zswap configuration > > instead? Agree, I edited that into the changelog.