From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6407CD37AC for ; Tue, 3 Sep 2024 20:08:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F1E8D01DC; Tue, 3 Sep 2024 16:08:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7DD8D016E; Tue, 3 Sep 2024 16:08:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5428A8D01DC; Tue, 3 Sep 2024 16:08:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2869D8D016E for ; Tue, 3 Sep 2024 16:08:04 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C5CAB120975 for ; Tue, 3 Sep 2024 20:08:03 +0000 (UTC) X-FDA: 82524513246.13.E6357B5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 03201160008 for ; Tue, 3 Sep 2024 20:08:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tdypDXlu; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725394003; a=rsa-sha256; cv=none; b=fOUEydq0AGW6cqpPBIERPUJCLPLQcfuSRHaNGj0LGXeDQr6lKj6gsogGzFcDVjrplYMq73 pzhaKDHvAcZuPPTmdq/noia6zPebvHyVDUvQakrRCfsyF1GdQAkGPM3sQ5Azbzq/QeydR1 avf4/ZycXLchwSjCxuXK6TvVAyuRy3M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tdypDXlu; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725394003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f/9Xm3mle2go8JFa2gSRlk7I+rzhRtpMMHyTA8T1dog=; b=65dZeT90wB2ALYYRjsyI+h4S3fSIeTS1QahFpEOgk+aBBaeZgRJnMwC9elG1YItnLSg46e PUV8MZiV71sOfbkxHRKzKnRc897BJWD16yqogMLaadEnrOX9bYFYU9Mwv9xmqXEFYN/0t5 8lUVOb8TXXoqw0uazEqfS8PgWDeGFiU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 85246A43E28; Tue, 3 Sep 2024 20:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 621B1C4CEC4; Tue, 3 Sep 2024 20:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725394079; bh=fQAFo9M1O4RDOc+KfzpdXU0fZMbaXUrNjpO0iTtsDXk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tdypDXlugF8gxU6YXJwTUXcQlu15769ykVcnFmgPEgfDlq9YK2vr57n/hw17ICRBE 24X0Gy7eQNu155hon6k4beqTF8q82Kpkis4P3GWE91cALUSA9B7ZpvkzU4YMBfLzFC y+8WHiOvstLLt6e6tGRlZHBrBCdiKI6aOHnkiDDQ= Date: Tue, 3 Sep 2024 13:07:57 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Kairui Song , hanchuanhua@oppo.com, Usama Arif , linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, hch@infradead.org Subject: Re: [PATCH v7 2/2] mm: support large folios swap-in for sync io devices Message-Id: <20240903130757.f584c73f356c03617a2c8804@linux-foundation.org> In-Reply-To: References: <20240821074541.516249-1-hanchuanhua@oppo.com> <20240821074541.516249-3-hanchuanhua@oppo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 03201160008 X-Stat-Signature: rxexgj7j65yxa169ukawhcohmkmenfkq X-Rspam-User: X-HE-Tag: 1725394080-812250 X-HE-Meta: U2FsdGVkX1+BgY8vE0uG30YxAV0KaCZAnpertHvVo8GBH/NUAk17uS3h9XHLlBp7pycwa+c+we9kap6ejVNGhkykR8ZGB8QG5JFXCWSh0Jp6arrfOPge5jh8n7p3kgmCjsOAInOZt3rYbfc6PtWO9kZW/zRJWSP+BKakI3wVZ3t9qCCrR99G3D5cDvU9jXcxnPI6KCRYhkasLxLFROG39QDtqiuZvKIgwBu0DL0SSaE0UtupYjrF6grYFLSlK2exrkNdCP38+uVVNNTlcWA1psIETx+qnrDDVQVnWsCXaDP1aQmacN2faBinaly3RTYOZB6JK6tVnqxa/pVjf3xdRwIDWk+W9NLSwzTBziI3+tRWy8g9RkwkuzTkB72ZhvDqhUVG97o34XZ/81fnH10J4ew53w38bFXvHdCS8S60fGLyf+PDhxKoCSqPXopLPrA9eIkynWPTlkQB2qq9ypfadDACsOymGA1350lvOR6kt/O4wotpuiRCzoWuHyncV918BfLkTyWAKEQDSk0N8IC5/R1ypTMCLt+ibHAVS3dNFtUGjjwI+fdbGETRQDMRDecFy/Ot9zg3DXy60CjOsD3eEFj1wkeGFt9p8wC6XR5jYPC+a/OinZm51KSYXt8Wh1BPT2VT5XK4rmzUzOlWevVYLnyyJvMiMgENywl46CbHf+cAGg2X08gpuwJ0hi5nj5HMNRD3uSdnzptb4ljpfQTOfizLqJZslAnC3vD+D1IMWecr4MkSukBg1JKYUYx+o1JYW2cwB0dW67vS/J/UVqg+XALPGqW224wgVu6Wz61SGsPUuCNRvo+lCDD0OPpdP6164zW0Ssh3A3xHPdJz+Yyoji3osWjK7SBM+I81GUyeRo+fAljJtWLwVW/3Tg3Ir0ztisC7OzCemXwltbriXL3cn1FKkNdJ6HGcdZiO0aJ32YeT6uUK3V2tQNwDxl2kXORv9KWbotxZWxKJA7TazyP wv5K7pVs yBBF91q41DnCh6XlG8UAPUC8hKi0kgmzW+9KWeCs5U7xplhVNYERl3f3Bdl5P/j963tUMKvX66YMbLgmQice1mmyuYJiYTGKQ2ClgC7Z4TpDX3L418v0GLUUhIygXIDWI5pYv/FDYT4f4dohkIkEtpjtAEn8YO2WJK4gM3C2/Uefhm/WnTxVaAy+xX4I3p+c18zQyPojbf59MnK3YGn51+RgdkbEZNHRLJns8FPI1VFF9WI1LA+YcGs7nnTX4hgltqpBXvG2JUXt7UT1US1E6leJ1flY/Ux+qOC9YBPfOGnpRw5/x3ueaTbNZlnOiK+mRLZAa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 3 Sep 2024 11:38:37 -0700 Yosry Ahmed wrote: > > [ 39.157954] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000007 > > [ 39.158288] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001 > > [ 39.158634] R13: 0000000000002b9a R14: 0000000000000000 R15: 00007ffd619d5518 > > [ 39.158998] > > [ 39.159226] ---[ end trace 0000000000000000 ]--- > > > > After reverting this or Usama's "mm: store zero pages to be swapped > > out in a bitmap", the problem is gone. I think these two patches may > > have some conflict that needs to be resolved. > > Yup. I saw this conflict coming and specifically asked for this > warning to be added in Usama's patch to catch it [1]. It served its > purpose. > > Usama's patch does not handle large folio swapin, because at the time > it was written we didn't have it. We expected Usama's series to land > sooner than this one, so the warning was to make sure that this series > handles large folio swapin in the zeromap code. Now that they are both > in mm-unstable, we are gonna have to figure this out. > > I suspect Usama's patches are closer to land so it's better to handle > this in this series, but I will leave it up to Usama and > Chuanhua/Barry to figure this out :) > > [1]https://lore.kernel.org/lkml/CAJD7tkbpXjg00CRSrXU_pbaHwEaW1b3k8AQgu8y2PAh7EkTOug@mail.gmail.com/ Thanks. To unbreak -next I'll drop the two-patch series "mm: Ignite large folios swap-in support" for now. btw, next time can we please call it "enable large folios swap-in support"? "ignite" doesn't make much sense here.