From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025F8CD13CF for ; Tue, 3 Sep 2024 11:42:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 738FA8D0160; Tue, 3 Sep 2024 07:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C3268D015F; Tue, 3 Sep 2024 07:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5896B8D0160; Tue, 3 Sep 2024 07:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3AC3F8D015F for ; Tue, 3 Sep 2024 07:42:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B259B140CE2 for ; Tue, 3 Sep 2024 11:41:59 +0000 (UTC) X-FDA: 82523237958.22.C7B989D Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf10.hostedemail.com (Postfix) with ESMTP id C36FBC0003 for ; Tue, 3 Sep 2024 11:41:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=gKOAHiKu; spf=pass (imf10.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725363622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iPRB6Gjttbol0VPss5oDVUKbvsURabvFSdzfOBAOXLU=; b=QAIil+L76MN4XuUw8r7k+XIxpbJrItdNuQ9rrFM8oQ2SvlWznzixa81ohdHPhY5fr3S8ps RARw+sxFbgwDDrIq3Cn8+Q3rlQRvKSb7L8P0reT9bcJn+ytcg8nFzS8R3eQgeWSAj0GyII AGV8m3fFw8kN8KZn13RcWjC/f8n62hU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725363622; a=rsa-sha256; cv=none; b=0SqbFLV4OgDQUsHkrflB06odlx+FEuVSdVR02iN7PWWC7r8dt62p2tZNecd2kxxHAnUwhi rK0ET9jIxO04i5siK4+xTpIUVbah3vyycsKDVuHjTAJQL/L7mHk8DjrBTulY6IVkoV4HGF y3F4eYBePpr6eH6xLqYyzt/EKqflqI0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=gKOAHiKu; spf=pass (imf10.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu Received: from cwcc.thunk.org (pool-173-48-102-194.bstnma.fios.verizon.net [173.48.102.194]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 483BfYcr027588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Sep 2024 07:41:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1725363697; bh=iPRB6Gjttbol0VPss5oDVUKbvsURabvFSdzfOBAOXLU=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=gKOAHiKukciM+tUHrN97FNg0iXtWFrqusqNTFuReprnTbms3cz90E20lbdF37oP8U 7CT6koE9sbMCV3f8g6Qbaqtzcd7kLTQWFA9D7ZRKDrkXAGLQ4LdwQUlPHHGmaYsYEN pqFXmP3GubHDmDbKllEt5g3ro+SGet4fsDTn2jNrPd0im83A+cr+/LE5Vd6eUWWd98 dzJI4rZOFlIEuJncqq/5UKbTzWQw89O49UWBQ1SwkDr7Jz8PaRRCepDKDlDjLwfsrz Nms759MQBFA/mn50xfBuUCtzZdXZMG6SMT/RT4hM+uTlEw+X9C8GQhcyyejwncQzYO J/qr5fgrWF6KQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 81CD915C02C4; Tue, 03 Sep 2024 07:41:34 -0400 (EDT) Date: Tue, 3 Sep 2024 07:41:34 -0400 From: "Theodore Ts'o" To: =?iso-8859-1?Q?Andr=E9?= Almeida Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig Subject: Re: [PATCH v2 4/8] unicode: Recreate utf8_parse_version() Message-ID: <20240903114134.GD1002375@mit.edu> References: <20240902225511.757831-1-andrealmeid@igalia.com> <20240902225511.757831-5-andrealmeid@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240902225511.757831-5-andrealmeid@igalia.com> X-Stat-Signature: 54ppxftc7n6jmju9yh3uzixwee5n88xm X-Rspamd-Queue-Id: C36FBC0003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725363717-578823 X-HE-Meta: U2FsdGVkX1+Xd78hzz18RgQp9N1nhmapVLZ7fSDEcpqlHvfwMo16+92LrjejFF6WMlzx+lXSqUErWHpnc17xba9tinyEeYQAL68/dj/7thOwzJVYVwLD8CJ9UDYETpj9OqFNuQ9H59is6xY2gPgsyjk2OUnqhvyR8dJlea9cB/AJfHGqbltwBE3PTKeRVcrzBIE+KdJSi5EzVj2s66RPZ4DzPVLwv+4jvYR/XgVQImmyZKXajq4PL+HdsDJqFl4fHYlPR+eZwypiDITIdn8KwEj7by0v858/GwJkNz482rZUNN/FWS24Dm1hHxzsA9hSQjzyDvzxgad6XVGx53NOlweYi2I2Vtf6FMnbMXVbX5XY+3/KF8VA78Nl8oAHboBQ1plLlBDhXVG3duWO5Nc3jI520appG00lNJbjzYtPTZ3QKP4QWXtu3LzCSJj4L5wnAVsObkQUXfDgcuLUft4jNjUMRXsip40/RksjOkZeS1ht2Nz6rXriYLkaB5fk1MrjmaGE+FLvQI+u1h5qyc2AV0E73qN7kFZLp3cjYrdfRVUZtEKgDc2mIwJFHoASth/kWkTY76ww0M53zob6YgrfK6VEybJTUmF+Lx7XODHq3PjrE61iHZ8AumCrsBg2sskEUJPlK9MlxvuJUhAZZefh/rGSA+HipJbG3fBnLRqhiYytJ9jO9IibD/4UZ3RQuO0uWcVFUz0sUggUZaI6WTuKnsQNeLtzEMPQ4HVXqG7ZMoB2Q9Nl7lPypzE+C27Q6VfBWcUOzsbqLXV96I3eLqdgQ2OMLV8ZIgIKA8fB7xCuYWCfrdcTqmtHo7XLbGND8xn8OSWKgJ8BpEjZUxLJiLVpjSxYJXSpusxIwQz5zhNAEtS892iN8gU/96K2Kf2ZLaTuyE9eua/I3BD53YDBKJbh1pYsH65vL4hO9ELlhYrUrT+VXKQmBVtXZN/sjqMFxgc5S6/aAR7z7rbYK3+HUOg c0cPi1zh BeRpLr9FBuJ3ehlcdqGm89Zuqh1vGQdGROqWGbc5CuUVBo8ZJo3TQhPvh9r0kP00AaaANvqlB7TEy72oPGtB/yLJXlTXPXXLCMBkZktxQyprrJ6hQNXxBggXg4IHX4EqMTftceuxzInTvhPKsrvZgBJ7WqJncQ+DH4NVHwwVEw3avWwaIBqB8vBvbSn5kn+SdfzO3d9cHTXaPYqtdRbqUo1WfJFsl+fc6hTGm73g+ZiJVAxNpxyz72t7JVhjbkG98PMBiKFuYmCqaMa39cZ2NilPIgEk8oDGMK+cE06z/pODcAyX+7SxAFHP9Z+s1SeXD5HzFK6uF6ih/+B9WbWL8SFyUhEzLjDRpxsVB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 07:55:06PM -0300, André Almeida wrote: > All filesystems that currently support UTF-8 casefold can fetch the > UTF-8 version from the filesystem metadata stored on disk. They can get > the data stored and directly match it to a integer, so they can skip the > string parsing step, which motivated the removal of this function in the > first place. > > However, for tmpfs, the only way to tell the kernel which UTF-8 version > we are about to use is via mount options, using a string. Re-introduce > utf8_parse_version() to be used by tmpfs. > > This version differs from the original by skipping the intermediate step > of copying the version string to an auxiliary string before calling > match_token(). This versions calls match_token() in the argument string. > > utf8_parse_version() was created by 9d53690f0d4 ("unicode: implement > higher level API for string handling") and later removed by 49bd03cc7e9 > ("unicode: pass a UNICODE_AGE() tripple to utf8_load"). > > Signed-off-by: André Almeida Reviewed-by: Theodore Ts'o