From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD59CD342C for ; Tue, 3 Sep 2024 07:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9B08D0144; Tue, 3 Sep 2024 03:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6894D8D013C; Tue, 3 Sep 2024 03:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 550C08D0144; Tue, 3 Sep 2024 03:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 384238D013C for ; Tue, 3 Sep 2024 03:53:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD60716095D for ; Tue, 3 Sep 2024 07:53:49 +0000 (UTC) X-FDA: 82522662978.15.BD4F4D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 38781C0018 for ; Tue, 3 Sep 2024 07:53:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JNkzqV9+; spf=pass (imf10.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725349934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FFhrK62gmpsfLyDLwMWsRjC90q/mVY90ffZt9ZfkTg4=; b=4+mwioA9Z5viOp3zXlpTj4Qkk/Or2KSekeGfZPml8JNkGLt9DeYcbgzfc8dYICjd7pMe5u xoWV/b2p+o6N/SBW7AtCZWh2qrFVg1deeC/sTZUnflISN/1GewK3Ge/igkjYBK76t8tdr6 cndMIDMv3WmvFBjgPdOjvLZZrFlASis= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725349934; a=rsa-sha256; cv=none; b=tCBfgRZVg9OHcg26JTPwPH0+LAQpSHXlJuE22F+cVOl6pwCybtPc21ExGVHejJe157d+4e QAeGAMK4HOGCv+Ftrrd7SfX4FfTFAfek0j9aY17ah/mp5vm/sfd7ClxeJHXVii8HwdeOFF JpKiAHIeoEf0jX2UCsy0S4cKJFy9898= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JNkzqV9+; spf=pass (imf10.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D671F5C5676; Tue, 3 Sep 2024 07:53:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50385C4CEC9; Tue, 3 Sep 2024 07:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725350027; bh=wi97ztJZt4//LuOM70DFndgCCb8iG8N6VoALz1a2qLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JNkzqV9+zSHQFCYe21kFf+c9yLni+bwTAn8iPnvdizzzOF7w4Q38VVSrF20V3RFwu AI3ozPaYrQQKnJ1fGGmQIqLAJy0KTTETiyrv3Y5c7Wkh037WDXf3ul6XqgPgenHelx m09aPF0rW0HuzqE20/ISZ+LK3KlwUtvJjZ17stiaa6FWHGumRYSrUIjbqRa7G0LT8n uAuOQHXh/F8QGSPChaRctR7SxMwUB62Wdh1lqJh8EIbmmAVVHzpT+QghOlYSd3dFYQ ZEyCqRVIuv5Z2NlOZ9WWVH0bo0RFMrPPE37/vh2WbeiFyQc0vQlLzAPJqenRJcwKXG ZCk5TpV81ah1Q== Date: Tue, 3 Sep 2024 09:53:41 +0200 From: Christian Brauner To: "Pankaj Raghav (Samsung)" Cc: Matthew Wilcox , sfr@canb.auug.org.au, akpm@linux-foundation.org, linux-next@vger.kernel.org, mcgrof@kernel.org, ziy@nvidia.com, da.gomez@samsung.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Pankaj Raghav , Sven Schnelle Subject: Re: [PATCH] mm: don't convert the page to folio before splitting in split_huge_page() Message-ID: <20240903-eidesstattlich-ununterbrochen-bdda2e9eba98@brauner> References: <20240902124931.506061-2-kernel@pankajraghav.com> <20240902-wovor-knurren-01ba56e0460e@brauner> <20240902144841.gfk4bakvtz6bxdqx@quentin> <20240902-leiblich-aufsehen-841e42a5a09d@brauner> <20240902193520.hvtjrnyqmosnkfff@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240902193520.hvtjrnyqmosnkfff@quentin> X-Rspamd-Queue-Id: 38781C0018 X-Stat-Signature: yj8utsma5d4x4ftsona81s1cp616uene X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725350028-218755 X-HE-Meta: U2FsdGVkX18Ass5e5tZvTWNZr1wvK1MSVjNYjS5JCvRI1p2vay0Tahmma6O8Trc95+mhWqk3oOCIIVzt2WBLaPTUOkyAwgBbpUIl8V3P2tjX2FFjqSTnC16Jt4/iEoqMpVc4HSdANEQ/pSsee1+UbS9V/7cgQH4RjGj5XTcb/MPyqunybG4VoZ4oN4ETBT5SXlfYHPcrNWU27sOyND7LVKnBz4HYtPxOk9h8gzOY9tICm/N9IlcaxWo6kV7/i4VueGf2aBZvHroas+NEYhAy8u1lI4PbKEkD4QS72hvm+eBP6Wza+ZHnQGSYce/8P3af+1d28GwYnYqXKLTkTjLuJljWzdDi6iUe1/IpRdu7sjNKtDHROVJa5Y32WsvWEp1IaCnZacoHgSf0fJiEuScDIywrw3jJWMpYRvG/JYeVSEqNXgcos9uES2ylz5EhH84fz/BctQfqe0C6l+Tq91ku452nvze46WpZwTGz3DmcGV0Y6RhSXjfTDA3giTniBDRUkIplWayMocRhxuie+39KOhr/1o2WZNlSeL5QroVRRnVffaZH4LiBDcL8/lIhoKyLrTWuDiR26PmCFOuz+P9yqTeIhemf1uDyRvO7fT8Z0sF+MlPR04wYg1nmc6oFhscbG37GDi1+zv9jnHTl5CnBwIMONi/n5ZH7jIWTlGAwODlTq3Sd/EJzun2CrC2MDU84QoNJGowKZ6ogC2gU7ZeSQkfwqcGJNXjHNErolp1vhNEUF/COkOGYlV78cmfBmoybplCJarUJV9amdJZcKedwhaMzlqZBwkh9cf94dEX1wFiPhDEh8sb7USyb/BO2G/1hCulv+eeY6yJ+ZI9J+FoUzPsz5Bcv7cM+RZZNObgOZTY7G3EexSQwRFFSAt+i9kj+hZDcvDUDNu4ukf3xQnVq9D7Pd7VRFtUtShoIS4eOo5hcWtk7y88KGHl/jrDROJcA7gU+4EAqr0sy9XYrpS9 U/1Ptbwh 8hvJF4DXmc5+x9jQI8853O8gIyeXOkQ/h8JXNNCznsRIAFC4i71EqZW446mUxNi5eiEfYIPEc1XzAgMQ22+RfQYv5AlZtoNUNnswA0PV1pM3AZcYvbt8J1wh2tIcOb9EwC1CXTe3JEc+FkFtpcHaILrOC0f9iHS38Vw5ZMCFJ9W6xUVj0Rlm2hGMPXjhIA2D94ldOltjo5oXsYCv1j40WbWQPf+e52M4SXuKgS0u6d6yjSbz+A37+YovJ1yKXxSdGwic3xYX/kDs/qWMOROXfGqwPRlhhPNBIYfz+AYZwdPvu8TipnAOfPTFb7RjLqCcEDapYjezDkhm8PYQEgCmm/f5FCuL91pYkM145jTaki5K8uAzGVZ1291V47Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 07:35:20PM GMT, Pankaj Raghav (Samsung) wrote: > > > > > This should be folded into the patch that is broken, not be a separate > > > > > fix commit, otherwise it introduces a bisection hazard which are to be > > > > > avoided when possible. > > > > > > > > Patch folded into "mm: split a folio in minimum folio order chunks" > > > > with the Link to this patch. Please double-check. > > > Thanks a lot! > > > > > > I still don't see it upstream[1]. Maybe it is yet to be pushed? > > > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/commit/?h=vfs.blocksize&id=fd031210c9ceb399db1dea001c6a5e98f3b4e2e7 > > > > Pushed now. > > I can see it now. Thanks Christian. :) > > This patch has a merge conflict in linux-next. It should be a trivial > merge but let me know if you want me to send a patch for it. No need, Linus will usually just sort those out.