From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B142CD13CF for ; Mon, 2 Sep 2024 19:35:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3A7B8D010E; Mon, 2 Sep 2024 15:35:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE9D88D00EF; Mon, 2 Sep 2024 15:35:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB1A28D010E; Mon, 2 Sep 2024 15:35:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A50A78D00EF for ; Mon, 2 Sep 2024 15:35:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 56D8FAB25B for ; Mon, 2 Sep 2024 19:35:35 +0000 (UTC) X-FDA: 82520802630.16.F8B26A6 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf03.hostedemail.com (Postfix) with ESMTP id 31D3620006 for ; Mon, 2 Sep 2024 19:35:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=puhyG2Pr; spf=pass (imf03.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725305710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gO3Xd6rwjK4x7+adB4VWglk+6KjE/LV8zfZQ+BMmR84=; b=tnf5ERNYaoe/IinXV2xT/GvKhnAG3qUB13wb7BVei77O+ywkZDlarJMu6XypTeGIbomUAQ YfjcjNhLziKdIQVGbJ0cw5q7ybvfnAU9hTOi0mqur23Ola7eUxZl4MsC7BdKVqMw7aVuYC zHmHQVK8KHhJvCqjB/Ca9ulYJtKI8Fw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=puhyG2Pr; spf=pass (imf03.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725305710; a=rsa-sha256; cv=none; b=a+tf1El0xwTpW67YGPPcpiu71eVduvJWEhC+1CIYI+TLB2kc4dfUeKkZfM4oFOS+gAhUxt Oqos7JyMmqWgsBma32jpu7so62RToATe3Qsmws1YZkrRMUv4SLx7cWkDM98zEOxpva3JgI vBTsdxPezRRREc14o/E1xO+Lt2jJ6c8= Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4WyJrH5FTWz9syQ; Mon, 2 Sep 2024 21:35:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1725305727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gO3Xd6rwjK4x7+adB4VWglk+6KjE/LV8zfZQ+BMmR84=; b=puhyG2PrXMBDQdcrvvJhraVRl5MFi7F61jTEMstUgKQkfnuT09pAFDZ88PjJ6SU0mLZtdj WoO9xd4HJD4+XOJcpAAWqbiuP2maaoBmLaeSkQzLR3V/tlgWu2Sb4o76hMJa3naJx5fhUU gYmVrdJlEHHTfhf8fhzJhp0W6wOJgNkVFxuiiStZnLepPpOdBXDD5qf+544STMRUv0nLMX vmFcn3wQFTO5YAem6dWhE/PAeg5ie99XLuvDXZVKhC6jPjl3sS3NqU3GWhH5zWqxUe1pa2 adQFwCmrFScUh406kRJxYdxaUui27zoDUJtJR8tP0PLLgt4GE1k5efFaPUVuVA== Date: Mon, 2 Sep 2024 19:35:20 +0000 From: "Pankaj Raghav (Samsung)" To: Christian Brauner Cc: Matthew Wilcox , sfr@canb.auug.org.au, akpm@linux-foundation.org, linux-next@vger.kernel.org, mcgrof@kernel.org, ziy@nvidia.com, da.gomez@samsung.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Pankaj Raghav , Sven Schnelle Subject: Re: [PATCH] mm: don't convert the page to folio before splitting in split_huge_page() Message-ID: <20240902193520.hvtjrnyqmosnkfff@quentin> References: <20240902124931.506061-2-kernel@pankajraghav.com> <20240902-wovor-knurren-01ba56e0460e@brauner> <20240902144841.gfk4bakvtz6bxdqx@quentin> <20240902-leiblich-aufsehen-841e42a5a09d@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240902-leiblich-aufsehen-841e42a5a09d@brauner> X-Rspam-User: X-Stat-Signature: f94sdz9u1oik7sjsocrodhdkz7mzgy74 X-Rspamd-Queue-Id: 31D3620006 X-Rspamd-Server: rspam11 X-HE-Tag: 1725305732-140942 X-HE-Meta: U2FsdGVkX19kGLZSq25QAAMot+K6ZhN2ALiGuO6sIRmZ0ZGwPQyzxGN/6WNJfn/7IiXWA3vbS+xivCUkoErGiDn/P+bCPu72M9f8ROuiWo6JISGW9tYWaEd/P199bttv4PFcgZpznM4LkX7eVoXEIpRwVU01bP3TOhBRloIWZB/N9d9MJCzUeUtgNvUkIkzUMR6EuLi6VPn84j/IrdDXLrdWBuc8WnLJpgoRnplhKnHn9NpW+Lu5tn85WWEYQaAZvJsNKyoIeSC4nVnsSSkNT4xTVC0ipVcLRlLJxUz+unYAnQz++KLEDex85Vemee4ksNlCpIlmqnJZ0A0tWj0yY0CwIaJXuC0pGbNdnHbKst2122eahDdjmNQw39Z/eTO5FLAQ4hcZWrq2sba5sCjrVWKajxAt9TauqYjGXNqAQ1QzZp54Gfy8aurDoS3vFiNSP5G13GCG009A/qTW1nRybMd+NLui5leRPdXJ3WI10+qb+PkaZBrhst6EQZqxKtBd0ErGwkJgVEA3k9mciTNvU33y7fFhO3THq2NWJVHEWHSgy4T9hxp479adJujsjkjWL85pvEzTDw1b6+qmrxNQe6AQac5k7PeCzay91E446PIVsxSxK4LyuPegr/WKN15pIoRlQ2sU3vN6+tAAqAY3gbXH5M2PxQLXLbeGsbrysC94l90MnKLESpMBbeO2gDkqe7rbcjuySbPsROLATA3oGmrJ17i2eVX2TZWt3VJ0M3SUMGCw1OIj/yLtYxcmU7MR7wru4Z5Mht1scn8xQRbhqOR8JSWoDuKpQ6uVxFbHHLhjDWMKmFEtTU24WV/178a/MdHFZv9xXbFzr1UX2K4cvQV30HbV7rQDxpk1ylA5+/+3XORgdVtFkkyxo5XRqNlLfm6OEXJXlyl8torn3gdQss8nWPAcxCy23jWzPpa5QTvnDiNdlAUvmfj1U3DlvZtM7xWH7Z/PLFbiYGOR83v vdWYSRP5 5KQ2QOLzNOOKV3uPLOeETKbgszjrXhKyw4joxWt1uzS2X/MSQGnFRz+U4+tIjhehXCXwJAnJaGZaTUUsDAdWCYc4ONj0WhgVci/mOwuDE24bZsq2o/5thphQZ60VJs/LqDtmt4TFh8WcXkWhgLZihqrRpG7aaEQV26BTpHgjqlGCwQhyHC28+HILGNGiDHlZ1YREQTGf+6fRjOwpyQegqq1SJ3/3BJurbm71rlKjzSndRbyNwKpCJuC0qQjXATxSyPSBjO8hn/yYsbX2w89YCTGaH9lZg+Xhv69Qh8qoYmrGjxB9++w+AuuTVmGAmJxq8NsvIYIhgmR/BFUkeENnrDUeTkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > > This should be folded into the patch that is broken, not be a separate > > > > fix commit, otherwise it introduces a bisection hazard which are to be > > > > avoided when possible. > > > > > > Patch folded into "mm: split a folio in minimum folio order chunks" > > > with the Link to this patch. Please double-check. > > Thanks a lot! > > > > I still don't see it upstream[1]. Maybe it is yet to be pushed? > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/commit/?h=vfs.blocksize&id=fd031210c9ceb399db1dea001c6a5e98f3b4e2e7 > > Pushed now. I can see it now. Thanks Christian. :) This patch has a merge conflict in linux-next. It should be a trivial merge but let me know if you want me to send a patch for it.