From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079E5CA0ED3 for ; Mon, 2 Sep 2024 11:04:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D6AD8D00BD; Mon, 2 Sep 2024 07:04:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 886358D0098; Mon, 2 Sep 2024 07:04:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 727DF8D00BD; Mon, 2 Sep 2024 07:04:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 502078D0098 for ; Mon, 2 Sep 2024 07:04:49 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0859781C55 for ; Mon, 2 Sep 2024 11:04:49 +0000 (UTC) X-FDA: 82519515498.26.632DA9A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 854671C0019 for ; Mon, 2 Sep 2024 11:04:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hI6RQIWC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fzhotnCT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="SB/dkSu3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kwxmk9pL; dmarc=none; spf=pass (imf18.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725274982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LrwrQnk3AUWu3toRtwqVBHqDGPavhHbdLcu1XMq0qOs=; b=tV3GZh7EuIfDG7uHSgzRUbGeYresdPxaOD4qKCpqDC3aG9yTLUoOXyrsGOpA5JbAWn2BDE lZIBvR9jniCvEif+XOZbJy7CEuFWqTaCaN/+y5RJqN4+83xMXiHIiOqnW/4z5Cj6jfpidK 4I6HozZhFG3XOjfARbDsOK53Uu/kHFk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725274982; a=rsa-sha256; cv=none; b=Y1y8Zgzj7PeuybWJz/P7ctWzO2dKIsdvFaawMXcopOwViDveFeflxF/YvsMahIevJKha5z aNkacPsppPyxDADFePMDP/+2r9KKcfSLZCT9An7gcbHXUXeat9qEoicy0w3bDK+0VDhR6p i5yAm8a75IFG9KBT9gLaQr423r0PbrU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hI6RQIWC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fzhotnCT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="SB/dkSu3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kwxmk9pL; dmarc=none; spf=pass (imf18.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7D31D1FBA6; Mon, 2 Sep 2024 11:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725275084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LrwrQnk3AUWu3toRtwqVBHqDGPavhHbdLcu1XMq0qOs=; b=hI6RQIWCMmhPKWpe6o9I9QXZIyKLX6nWwWERaF7rK0FX8gm7K4+VUeqm/gFHwJBmh8ZpTC N116j6rdT4K+BTuz7Z9A53qZSjmFH15sKy5bgWIRjmG8sLatsYFBzdpdNRTgSVXvMUO/4z lVrGKOkxI+zsCsPmoMXcvFGzHJGHLcM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725275084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LrwrQnk3AUWu3toRtwqVBHqDGPavhHbdLcu1XMq0qOs=; b=fzhotnCTLWLF4CazDLISpd0l0merMT3jIRmD475OHBF3W/wb4SdZkLUwSiLaH5yoZB77A7 hV9pNWjqdDeRMhAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725275083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LrwrQnk3AUWu3toRtwqVBHqDGPavhHbdLcu1XMq0qOs=; b=SB/dkSu3SP2u2hBSzXm6S9gz7Spy5gi22kJpDyJ52c71E7p6DO8AlWmq6zyQ0pVQ9G9Uhn 2pFLu2+HoeeP/nKHNnsHmIDGpO6u4B5XSwKuLfQknyqk7TByYid/m80rz/ABTvePGVGXJ2 WaiGtSCgxKRWIag/SHT6W4usWrRFiAo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725275083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LrwrQnk3AUWu3toRtwqVBHqDGPavhHbdLcu1XMq0qOs=; b=Kwxmk9pLByDZhraqS548Om7S4OJTeE0qbNRB5Q+QkqOnXvG1vuRf3Ro2cc3zr2feQ9z2yX AdMOesNtHuAjMwBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6D4B113A7C; Mon, 2 Sep 2024 11:04:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HruoGsub1WYKcwAAD6G6ig (envelope-from ); Mon, 02 Sep 2024 11:04:43 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 1FCC7A0965; Mon, 2 Sep 2024 13:04:28 +0200 (CEST) Date: Mon, 2 Sep 2024 13:04:28 +0200 From: Jan Kara To: Kees Cook Cc: Kaixiong Yu , akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH -next 12/15] fs: dcache: move the sysctl into its own file Message-ID: <20240902110428.os726rhlt6y5i4ak@quack3> References: <20240826120449.1666461-1-yukaixiong@huawei.com> <20240826120449.1666461-13-yukaixiong@huawei.com> <202408261253.D155EA0@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202408261253.D155EA0@keescook> X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 854671C0019 X-Stat-Signature: zmj4k664jcifwgr9tsqwe3bp1t3ji6es X-Rspam-User: X-HE-Tag: 1725275086-86729 X-HE-Meta: U2FsdGVkX19AGlPSyHHnNrN1CP+YX5VQQa+AYkwr73tNGL31bE77CKGslwm5fmrkipY/zlBf8ZowH+PyZNcEFtWcQeLVc17ief+C3BOMvb+tBoNerN1AyqMhfUyrubc2/+zABiAeNlvtWNdwJthm3QTAkDjBlPQNDOAQ2iotohSeWSfbI0xUvgnbvX8WCwicuryOe7wBDWvvXOXVwP5P2YjjP4h0QM6KRcB1rWgGMLQiqhDZ7dxyMk/hBHk3gw8QL9PeeVTk/Tt1TxSalkQiZWcSAtpwodl9QhmITn0OYuDhdSrNV3fUY11d9V0FfYAqb1Jolf3RJw+CZErNExMhKTKLcqlnX0zM0+FOoIAiu721ID+D6iIh7JJCy2/D/EMwwV5ZfoDsXI7I5KUjKbYtO0QUyAGO63Fy7T8i3yR2iWabhhSMPTQRtMrdlzdHgEfKebKZYqAP9sibkFGwAe8mtKoUbxaPdXm1cJjvvPoS7gES+zIdSwRwXYnZpjPWyUpbGxN7XTL4qxCMGlSxTMovyhl/+qZaThmW99xyUBIiokbKz6c2VBrcALlyE6gZCSYdMbrqhWmRwQ0sakTzpWT9GL6rpugF5KludV8Vr2j3mygiLUicfXM1PmZety/dpyDlzM59ISQjszRSvBIZ9R4RLV5sw0dg3RkzDjBzqhwXwTy/+pAnlR2WbgdxImtCi3rv/+yzwDHzTokGSNkPDC5w5PWlIt7vmrz1+nqYz6oogbzEsWEAJAKvG2XyE2JM9VH0n6t0XBuxN+nxpsdc44ilRNwI80mH8mKXrLZbb8rPlx+y3Syl5oQCgsOLoRpiCSy0jiKwCIHok19DTXYp/QPtIao2vGC+enpte5Br29RrZ01XB9KTr2EGJiHRCMSJh7dyIgauKSzyDp0bSMkrWJAnU3I2g9R1u0eVo1ARcEzUt7tm5iRHFs3WoFaV5J+oVWDIAD6+ICYX+ukHj/vDM9L indIN7sQ Mb2PF6aTImAplO3954bXzjucxmbajxmuyiSrxdaM8sOUFftENWaYdZe+Ro/Wn8J/P7QyaXqYRcRg2L3ELXn+ofIUj57fhbOSPQ3Evl+fSNRXD5uFM9aaqcKBsheOtboX/Dd+XBRc/uz/Dpa3GEfk3hiVVZPIc2U+fkIAmtxw2ixf3tICCl/r/Z87zsQIpDZ+z9Uuo1C5Wcd9YvPDzgmbSb3QEgL8lzkT5ixrXkSRr6HEgLZ/3QkQa5SzqVM3k7Ew+qFdokrDQKw22vw4OdTGpZoG9s5XN7chGqUyJe6l85IdWgOZJW/wPHUnBgZt1s/5t/G1AjCann4WbE57b0UZMZ9RLqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 26-08-24 12:56:00, Kees Cook wrote: > On Mon, Aug 26, 2024 at 08:04:46PM +0800, Kaixiong Yu wrote: > > The sysctl_vfs_cache_pressure belongs to fs/dcache.c, move it to > > its own file from kernel/sysctl.c. As a part of fs/dcache.c cleaning, > > sysctl_vfs_cache_pressure is changed to a static variable, and export > > vfs_pressure_ratio with EXPORT_SYMBOL_GPL to be used by other files. > > And move the unneeded include(linux/dcache.h). > > > > Signed-off-by: Kaixiong Yu > > --- > > fs/dcache.c | 21 +++++++++++++++++++-- > > include/linux/dcache.h | 7 +------ > > kernel/sysctl.c | 9 --------- > > 3 files changed, 20 insertions(+), 17 deletions(-) > > > > diff --git a/fs/dcache.c b/fs/dcache.c > > index 1af75fa68638..8717d5026cda 100644 > > --- a/fs/dcache.c > > +++ b/fs/dcache.c > > @@ -73,8 +73,13 @@ > > * If no ancestor relationship: > > * arbitrary, since it's serialized on rename_lock > > */ > > -int sysctl_vfs_cache_pressure __read_mostly = 100; > > -EXPORT_SYMBOL_GPL(sysctl_vfs_cache_pressure); > > +static int sysctl_vfs_cache_pressure __read_mostly = 100; > > + > > +unsigned long vfs_pressure_ratio(unsigned long val) > > +{ > > + return mult_frac(val, sysctl_vfs_cache_pressure, 100); > > +} > > +EXPORT_SYMBOL_GPL(vfs_pressure_ratio); > > This was a static inline, but AFAICT it's only called through > alloc_super() which is hardly "fast path". If this series gets another > version it may be worth calling out this inline->out-of-line change in > the commit log. > > I don't think it's a blocker, but I'm not a VFS maintainer. :) It's actually called from about 7 shrinkers of filesystem objects. They get called relatively frequently during memory reclaim but I don't think a function call is *that* expensive to matter in this case. Feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR