From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC8ECA0ED3 for ; Mon, 2 Sep 2024 16:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 700CB8D00F5; Mon, 2 Sep 2024 12:11:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1038D00EF; Mon, 2 Sep 2024 12:11:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 579848D00F5; Mon, 2 Sep 2024 12:11:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F1C28D00EF for ; Mon, 2 Sep 2024 12:11:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 63441120247 for ; Mon, 2 Sep 2024 16:11:05 +0000 (UTC) X-FDA: 82520287290.25.29DB57D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id B2811100006 for ; Mon, 2 Sep 2024 16:11:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BMhHnx7x; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725293440; a=rsa-sha256; cv=none; b=yj4kzqApSUE9YlkESC5fDpZTR0GGUBoZKwD3m+mSwBuyk6lL+nUAIGy2QohK+vdHAKs/vp gHxKmUDdb+E47WnHCEyWEq9u7gf5uIIT1gDZiPGD82nEKRs/RD7/dcxMrDENOSZL3+Kssx XOgEos58bMY5h7r+CKA0YBX5XiUdY+s= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BMhHnx7x; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725293440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/gmtzTSdrspcL/HxG+o4bsix8DKubc7zVjSogf0OndA=; b=IhXMLLBWyHyXllsqcBpC1bnvlQvIEopA7Ys1VeWX/xBUX1SkFbH/Dyaj2LGl1eg/7E8kHL WmHK6Z8HGysISbVnwrSgMFQUOY43HmN/cGq3lJwo0N2l0tYHZuPoZW5okCnTNuin3Kocoa tPXSig4GpEkdAopRT63/RsRnNr6HEyI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 470B65C589C; Mon, 2 Sep 2024 16:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC042C4CEC7; Mon, 2 Sep 2024 16:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725293462; bh=YF7BiudXlR2XGJ2GK/rIdAsgWsAxRRE5v7AiFUk78a4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BMhHnx7x8b8kq0VOMRBNCVJjDrnqSNZSJ9GR+NXIwyjxvYtqNyEKBdYw6at50Jxeh yWlu4mW2x/lQS/UV1PPQDnXdzGw9i9fJB9pXKlOMunIu5ZrZSILfOIw4eh6xH0Atpz qRINOxktkivRZAn4rEdUJkf7USoMhaPocuwjTEbMnrF9hbwydPN/jKuzrC51bovn7J bK38o52sLSVNZa/SfIGWOB/6yPhLCwWBgF/PiK3d2X1ee5dCrQ2qAZoUQGSJPJVRB2 rSYOrgM6eTpNPP4NijB1oM/FJ6C4imoszscZargiEfZmmVl9eAuaMIJCKK6jW6tG/X zcOMgywRmQg9A== Date: Mon, 2 Sep 2024 09:11:00 -0700 From: Jakub Kicinski To: Gal Pressman Cc: Hongbo Li , kees@kernel.org, andy@kernel.org, willemdebruijn.kernel@gmail.com, jasowang@redhat.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Message-ID: <20240902091100.1fa07b84@kernel.org> In-Reply-To: <3360d021-6290-4d6a-9d83-cd4c2d47fd0d@nvidia.com> References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> <20240831130741.768da6da@kernel.org> <3360d021-6290-4d6a-9d83-cd4c2d47fd0d@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B2811100006 X-Rspamd-Server: rspam01 X-Stat-Signature: yog3qzefungcqnzmy7jia9yxamh6uhu4 X-HE-Tag: 1725293463-699795 X-HE-Meta: U2FsdGVkX18bTGCD233lP5cNOGnR9Kn+rJsSTJ7TIqUGwWsas8fbKK+MTnR61ZMnRz0fsK6X63uASBvbjqdf5wK5zDHoQrWist5aNaSW6Ga/O4+E3A3zhz7EEjVGDAfLGQfTlyVjHBrJA9XgxWjkQKkJvq7vR9Dj99bxt9jQy5dY2ty4aSj6N1y5sfK8/ftIdbP08ZKCNgAkCzlpOjv1OSSpubc4A7HsAbxYsuA5IThGJMnffRham5NubHIpaq0K2Xjc4DLCyBZLQi+kXMQI2xYZgbp1taTc01a81PMScDExBFQs/7cd4WAxOCPlAoaeCJNV1iPkffwuRibRDRNrfbcjw9/3e4M8Gx5OQHaIYja8wtA5lEDxXdokXtbX1ShJ0GxjsGwHs4dIlsmuaLYF/90xZJu8ATUnequFeCQUnAtZiLzrzIBClrlLQTVMD4AvYxQodHxs21kfVLdfMNfQAJe41NhMBIydRwXdprjwryAZdjOVZQwgxFy8ERmS+r4J4QUif2hAi9fZetgRrBKYo7zdJfvm+NUndVRv3rBIGfaNuojyBn7cjL+pkahHXRRBqrjf7m5GfWdFnlndpaOfjMTLQD053KD5H4mVugNeEPwCyDxFI9zCdyLnDADkSGhbT6eAlWTasKnyb9Vo0itOvrOYIPHuV5pZfn/LmyinuFKsEHyvqxiEIZqsoeiqNJ8fhvFBfd3tc5NbWzPES682t7L7awisXKXgQwV+XHnhexxXEogj7Ac+/MMWVgVAQ1lbCoFxekIQ3SgcMLhJlmIe1eMul3y0v6HRkhnoCKOfMxJ8l+dMrZoB5XbdSDl7Fc+AK5WrmVy+GHaJr5ht/jmFJLaqan9iXF4pKX5fqifCYqi2TeRLbn7kzAgRMQS+MoVubmMmFQAn7S59XKbYn4dz5Cara7PxkuGO0oNcOFWuArx34niG+mxu5hMJktFcUsQDcCBmcewu9mUg2MrNmxa kZMxQEn7 Tf5TDKINY4NF2yiYFXyAxQbAsULTNcpLduIXih+QR5NULo6+A0pVz2gofhpjsO8iyX8ku9yYc0HUE3wjv/ufhmWlZrmNC/ocFY3MgpMupG2cDKGMJ+h/ZQHANsdLM9CD1aNor2RFWpHpKQeAXYiILUtoN1ezv+buQ06SPkT3hj+4T1qh4nDEtHFpv+1fHhESz8ftDI3fQYbKSbH2eo+qOgwRledL5oHSEnN1Osyl5HJWISmwcdlg+dI11dxhrLLFhZOilxJaQtCa08GzjqBc/5tUjjRWmlcJwFeOVR0vcfhKUwOcdkL0LCrJIQHUeKVVPaMZprfiL1hgju5462SAQzW49nk3hjj8fpkEDLbKUJiUc5tVkvMFGcGhdeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Sep 2024 09:10:33 +0300 Gal Pressman wrote: > > You don't explain the 'why'. How is this an improvement? > > nack on this and 2 similar networking changes you sent > > Are you against the concept of string_choices in general, or this > specific change? Willem verbalized my opinion better than I can. If a (driver|subsystem) maintainer likes string_choices that's perfectly fine, but IMHO they are not worth converting to, and not something we should suggest during review.