linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Matthew Wilcox <willy@infradead.org>,
	 "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Cc: sfr@canb.auug.org.au, akpm@linux-foundation.org,
	 linux-next@vger.kernel.org, mcgrof@kernel.org, ziy@nvidia.com,
	da.gomez@samsung.com,  linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Pankaj Raghav <p.raghav@samsung.com>,
	 Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH] mm: don't convert the page to folio before splitting in split_huge_page()
Date: Mon, 2 Sep 2024 16:21:09 +0200	[thread overview]
Message-ID: <20240902-wovor-knurren-01ba56e0460e@brauner> (raw)
In-Reply-To: <ZtXFBTgLz3YFHk9T@casper.infradead.org>

On Mon, Sep 02, 2024 at 03:00:37PM GMT, Matthew Wilcox wrote:
> On Mon, Sep 02, 2024 at 02:49:32PM +0200, Pankaj Raghav (Samsung) wrote:
> > From: Pankaj Raghav <p.raghav@samsung.com>
> > 
> > Sven reported that a commit from bs > ps series was breaking the ksm ltp
> > test[1].
> > 
> > split_huge_page() takes precisely a page that is locked, and it also
> > expects the folio that contains that page to be locked after that
> > huge page has been split. The changes introduced converted the page to
> > folio, and passed the head page to be split, which might not be locked,
> > resulting in a kernel panic.
> > 
> > This commit fixes it by always passing the correct page to be split from
> > split_huge_page() with the appropriate minimum order for splitting.
> 
> This should be folded into the patch that is broken, not be a separate
> fix commit, otherwise it introduces a bisection hazard which are to be
> avoided when possible.

Patch folded into "mm: split a folio in minimum folio order chunks"
with the Link to this patch. Please double-check.


  reply	other threads:[~2024-09-02 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 12:49 Pankaj Raghav (Samsung)
2024-09-02 13:35 ` David Hildenbrand
2024-09-02 14:00 ` Matthew Wilcox
2024-09-02 14:21   ` Christian Brauner [this message]
2024-09-02 14:48     ` Pankaj Raghav (Samsung)
2024-09-02 19:08       ` Christian Brauner
2024-09-02 19:35         ` Pankaj Raghav (Samsung)
2024-09-03  7:53           ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240902-wovor-knurren-01ba56e0460e@brauner \
    --to=brauner@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=da.gomez@samsung.com \
    --cc=kernel@pankajraghav.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=sfr@canb.auug.org.au \
    --cc=svens@linux.ibm.com \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox