From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3859BCA101E for ; Mon, 2 Sep 2024 02:12:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB4518D0064; Sun, 1 Sep 2024 22:12:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEC888D0052; Sun, 1 Sep 2024 22:12:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98DEB8D0064; Sun, 1 Sep 2024 22:12:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 733EB8D0052 for ; Sun, 1 Sep 2024 22:12:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D74C5C1802 for ; Mon, 2 Sep 2024 02:12:56 +0000 (UTC) X-FDA: 82518175152.12.52D25D9 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 2E28F16000D for ; Mon, 2 Sep 2024 02:12:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iHXcd6l2; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725243099; a=rsa-sha256; cv=none; b=Jo2nBzrbb68rSwzxFxyJrReJdZww0+trQK21xckbr4lImjYgLHRGoCLbQ0qmSshnmlNxUE AdhqUyZqzj1CR22Fxsx40TKMEXRwIIHKS7xau8MXtXdGvrrHO172E4eP1aaGTNz7+B2AjI vybNw3rOuMombpRX+IQnjkqe4SvXLco= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iHXcd6l2; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725243099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N0MuQ26ft7tY1xe5lIEiwWHx4zrAyO8OOu1V56C5goo=; b=b41bgPjbxAtUz2DuOZSIiYcEmNWyiQkmbTT95TUCfqhasxGw5s2bZNCC6GFBBuEQuwuuLN 1SKuzERQKKFt44KlVgOfohLBspWOSYfTXAygZeVQXBFXjgGik3W+gTFCcRE/JsVlmivYa4 Z/CaL3Vvu9hrSQbIyDUbT5Tto5vC2M0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3A4D2A41635; Mon, 2 Sep 2024 02:12:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A93D4C4CEC3; Mon, 2 Sep 2024 02:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725243174; bh=TGkTZJhTwl5mY2becvoVQ6aOd92XQ3M+sfi0H2VFSX8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iHXcd6l2JAT0E6e187ejYsjH9c55zsCkSzkkBdqnmSHpmkHG3qSbkq45mH99N9BF2 AIgneUjjvDFEphAHQnT/3yNh6DezE1rqnIKTS1pKl41yT6N9bpCQlBG2qeUKFTLNoA 5BftfcNFHqeQlnfj+azClHiKKeYMZcTHd6DDbbaY= Date: Sun, 1 Sep 2024 19:12:53 -0700 From: Andrew Morton To: kaiyang2@cs.cmu.edu Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, mhocko@kernel.org, nehagholkar@meta.com, abhishekd@meta.com, hannes@cmpxchg.org, weixugc@google.com, rientjes@google.com Subject: Re: [PATCH v4] mm,memcg: provide per-cgroup counters for NUMA balancing operations Message-Id: <20240901191253.404e7a1824fe7ef1933882e3@linux-foundation.org> In-Reply-To: <20240814235122.252309-1-kaiyang2@cs.cmu.edu> References: <20240814235122.252309-1-kaiyang2@cs.cmu.edu> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2E28F16000D X-Stat-Signature: 15uiteu19w7b5y546n7id5t86yurxd9f X-Rspam-User: X-HE-Tag: 1725243175-743339 X-HE-Meta: U2FsdGVkX199jbmOCNDjjn6WTrd0CtURYuHnuA+6Q7kSmTyZmtsNYXCrNbfkjlrBR6mue4fDKuE8n4YcY6dQj9aUVnnmzZlN72kQCbzji6XvYXKn0rHhAZNOj8oCQRDWnDufO0Ejw4xrBMjRB54qQKdLOVKnuEHE/EliOYqRFAfpcuoFNnCigrRVbXoqHL4e4rJF9Bnlngrw3z4RVyxX0V8TpF33jF8yAe8YGFrY59rJsNJKzhUNLkMOafceAkULHug+CROm+0T3z39bekGulg75u2xn+COBm2XbsFyO1+OBdQG1EL0tAQWt2kv82hQDQ3VEqXG1BQ+TYxhNbSSXIboMWLonaMfP3dX59d5TChoymwgqRZH7QgdaLtzS+POHQQX8cRJh9FOXUM9ypRENoDYohDGbYBdSrTzhU/Ek6JgSHNTMsTyIO5G4uNAnaRjAHcYb1QBtyDFfT5CZIvQpMlMGukV6UX58TAURZOHDKY6AmY00UJ9EYqJ+80uU6UGxBV1EbYIzpEm5o/idO7DbEBRSm3+xxx99J+DRpI2xcS5R8z/KQeY0F0qjgI9/IC+dEwTd6JAbPETOlLKpmgl81KXlocln37sVvdlAfanu4EeWguAEFPD1IYwWcJF1WFGiyp5802f2LJoK5GdFog7bEZqGnUMy2/HhbnMoIJJHiYc0lSJeWCR4I04QXo5w4iNX3WTDpZE4LedxZaqeQ/7Du29l1NkEhz56tXLPhtS3TjMxgFoagqHxbb3EAcd4sTzLVksYP4zsG6MimI+PO/PK+J7oMEBiHBv8NTkbO/oYttxijk3CPbWuZa3RUwpTg3zg2SflmKiNRT9oPxNeOMsPvi/iby0DKXmxqU4EWZx/76xDJdpOfkUJ+csjY3lQMzb5YXUNGW1aDOgmFQ9jb401+p7ww87U0zkZ1BCzaJErlEo4ptNJw9p+wNS4hcipKyXbBVBHwM3osqoTtjL1GuZ kQbiEPRS WyrYW9zb9wa0t3J3hJy7L4sH9v3QY6sOqaEaIXegn8nkVG/p8/6gaK3hiF9R0cTCzFQWNZi4msOM6QF+T7K8bgPZkvl0CyX2AaKrmvKFk8JTysLZeCi2z9WXQ4ihjmV7cPoVhMOqEaksLqCVUqmrDTs1Eww44nYFh6C++7dis84iX26ByEUoF3b9NsrQXGti4jT78nGvw6vRv1Ao2obQsPA2j8nN0h+xCGGOW1XHeciMD/jFi2kgX9yotnaOTTsSWdsj5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 Aug 2024 23:51:22 +0000 kaiyang2@cs.cmu.edu wrote: > From: Kaiyang Zhao > > The ability to observe the demotion and promotion decisions made by the > kernel on a per-cgroup basis is important for monitoring and tuning > containerized workloads on machines equipped with tiered memory. > > Different containers in the system may experience drastically different > memory tiering actions that cannot be distinguished from the global > counters alone. > > For example, a container running a workload that has a much hotter > memory accesses will likely see more promotions and fewer demotions, > potentially depriving a colocated container of top tier memory to such > an extent that its performance degrades unacceptably. > > For another example, some containers may exhibit longer periods between > data reuse, causing much more numa_hint_faults than numa_pages_migrated. > In this case, tuning hot_threshold_ms may be appropriate, but the signal > can easily be lost if only global counters are available. > > In the long term, we hope to introduce per-cgroup control of promotion > and demotion actions to implement memory placement policies in tiering. > > This patch set adds seven counters to memory.stat in a cgroup: > numa_pages_migrated, numa_pte_updates, numa_hint_faults, pgdemote_kswapd, > pgdemote_khugepaged, pgdemote_direct and pgpromote_success. pgdemote_* > and pgpromote_success are also available in memory.numa_stat. > > count_memcg_events_mm() is added to count multiple event occurrences at > once, and get_mem_cgroup_from_folio() is added because we need to get a > reference to the memcg of a folio before it's migrated to track > numa_pages_migrated. The accounting of PGDEMOTE_* is moved to > shrink_inactive_list() before being changed to per-cgroup. There appears to have been little reviewer interest in this one?