From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98172C54FC6 for ; Sun, 1 Sep 2024 16:33:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1377A8D004F; Sun, 1 Sep 2024 12:33:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C17A8D002D; Sun, 1 Sep 2024 12:33:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA3108D004F; Sun, 1 Sep 2024 12:33:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C85448D002D for ; Sun, 1 Sep 2024 12:33:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 771D416160D for ; Sun, 1 Sep 2024 16:33:08 +0000 (UTC) X-FDA: 82516714056.23.C772A32 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id A9A22180006 for ; Sun, 1 Sep 2024 16:33:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=uBovR2h7; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725208364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e6r0ITCLpW7ptnWXsuVezvMxdPKd+rYOgt2kxIFPM7g=; b=QgCXgaTQG0ikT/6vedc++ADX0QDDZJJXIO/acwztFgIWTd7UnwFPk+rAkfB6Id30IEMkNK 2qqdJbl3ehKSida9ku+YBrZ3EG4Xuc2C7L6obBBKqApJ53JNoIlLeC3B0lMIZ7A+z9v7y+ OPTYE2GHCAJbf3fvkiUg6RpVQFuTG/w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=uBovR2h7; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725208364; a=rsa-sha256; cv=none; b=aqUlmY2MPX9/E+nIAGmHS6j3B6l+a8ZjO+4Q7I/EszH4DS5oa0h+uhqAz4CkKKeIvOtZ3d iSGh/ouL/CxtUYXF8Ffaw+JajqAWMwLI1mNJRARoS64v68oXJfIgjvYdrbMqiByAeAtV9N tLqW22nWqKCA1CuwdULxCPDsL3wEPkE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7C1535C46FE; Sun, 1 Sep 2024 16:33:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19A19C4CEC9; Sun, 1 Sep 2024 16:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725208385; bh=oMm9PBHYo4bF6r1c1EIdWZn1Vu/P8ue46SnQKcPFL3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uBovR2h7eTc61ch1Qu4mYBjE96/qLoE3/ezQLNe25KQ8U6k+1FAmeRyHXlmDMw28z On+E5ABS/fZiYqo/oBUsD64HzPq3WE0DmjC6Xa0O8CRkrx4ChLkXmqPD7V/XTz7UsL QOYo8kkpVLtgYl3MJpd4PUIObDiFs9RHmmiK6zoM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Howells , "Matthew Wilcox (Oracle)" , Pankaj Raghav , Jeff Layton , Marc Dionne , linux-afs@lists.infradead.org, netfs@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christian Brauner , Sasha Levin Subject: [PATCH 6.10 067/149] netfs: Fix netfs_release_folio() to say no if folio dirty Date: Sun, 1 Sep 2024 18:16:18 +0200 Message-ID: <20240901160819.986674115@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160817.461957599@linuxfoundation.org> References: <20240901160817.461957599@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 9tch1hfnb551r3u71uzjcbak79mxmwwk X-Rspamd-Queue-Id: A9A22180006 X-Rspamd-Server: rspam11 X-HE-Tag: 1725208386-325297 X-HE-Meta: U2FsdGVkX1+1hj+9DWbQ9RYXc1PgGj4spXDwgYORFXVWZ1l7IkKCRNxJ/WVcRzk4xszwyOF/dFCX9dsqBXKLNAkVF7vk2WBw4vNHe1Vl7T/3ZMXJEtYqgvEFxhnVLOJ8wczvgTqq3yHwwQQ3XJ/rkKo6wP7aGlR4tnhGfvO+2xg9siDIMLrQWGvhvJilb+OWgwrdz0faCJTWDsj7jb8xCj9cH3pBJ/eS246D5j80NlRED5LnKlRGS/SUVDilmUUvbXkCMlbeyU2nYMvhgF++hfA3DqqpgUOIx44s7hhGXmcKls2YDetDgnNmwoRfeD3fxVSzPWwYIFsc7OuAGPhA4GCyzNRAGx1vLp4gufplavWQFkEhUyHpV6uzaX4pn2awcIsavEG3TKeapkDl1lzj7S1LuYBHEK/QM1obSasFuhf3JLa5HWNJxXKu00RD/OYw6XJORCBDS+M1EwHlz64HJ8ivWrK/9XdxKYyhgxiduOiZxSR/9j6TLkaMMazjKmO8u/rxNFos5Abhm4C0cS/XcZuPUPbohzEFPheoR510n9nuDCjbcRAkHZTZPceWtSaxZvxh0EzowgtAUAqzlfJgenpiea5Tz6IZDxMngxhYbN1syN9Ivasi1U6WGPc7lkFUw1w80pQ6QA6nQ9Q/Ugm8CkAs/8zOjGWr0jk0hhDXbB07rLWo61uw7uPio6I8xc+RLrcNO3NO5SYDyslqfKgrEfPMW+JWWigvMN3ehQRmLQYinKwdGvuG9OPLBYyrL9IpuOG2DEjb197dW74poTTrtqNqtt9YlZd+XgpZecdXYP45BQ6QgUluz6RL20U3g1ozmlHmGGjPh7hzzG/WnCYpjfVr73/8bOHmIa1CG0sPYBthTp9dY7yjT1JJgy2v026ggeBptdxh5Rv+L7jupnEKHDGDYZFsmYtiQX1O5VbvnrNtbi6xE2VXjXWhEAzznNrDza8vW5FMWE1r6M4CK5G mgZabaAU Pc46FRg4E4NK2WVAFxMgu738QK4pcjdYLgrnfvmuR1ZTxge+y8I+yQ7WEk2lEuLvsv34c5GMp2f0Hl9QYq8Hf05r4RMEuP6RSV6gEBIIzGuw8E5wn2sf07tvoBBOCpcEooPVbKZGTcfjHUx7/9wGf+Ze50khZIBhj/01SmPxMXIXTGRGnTBU3iH/2BzcVDJES1fR5aR66CQ2GO14GR7O/YURBtGh6/b7nI1xvTtE4vNzTSN8ILIrZ2fkHYUuSzv4Wk4XGWlc8GlLlE13iEE2sTsdbnX3ZJLrlDYt88j0wF/JMVQf+tVcMaCfUYRxirgGJQ0HpZKZAE//E/IhQgRyqVf0SxZe6vTfOJo1dXZfEg109pNJ1KlVvmddz4GX0+fjJFRx/Fp9spsXtevvZWKoAnMpuDfAO0/e08v8tUlbs6z1HxKuyzk4mIDJfZCmGSJ8EhkPvGjexPWWrIZ30NnddjzoNNmcoUe0Vm5EtnUo7GgM0AU53tyV7crTAFgmFX4OX8xrTdY2VfNdcDNXDtR1At7fq6/7/5bttb4udvTpTS5LLn+OqFeMEjQPpezFsST/j1DOx7STKP8k7CD54IbfMV5pcPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Howells [ Upstream commit 7dfc8f0c6144c290dbeb01835a67e81b34dda8cd ] Fix netfs_release_folio() to say no (ie. return false) if the folio is dirty (analogous with iomap's behaviour). Without this, it will say yes to the release of a dirty page by split_huge_page_to_list_to_order(), which will result in the loss of untruncated data in the folio. Without this, the generic/075 and generic/112 xfstests (both fsx-based tests) fail with minimum folio size patches applied[1]. Fixes: c1ec4d7c2e13 ("netfs: Provide invalidate_folio and release_folio calls") Signed-off-by: David Howells Link: https://lore.kernel.org/r/20240815090849.972355-1-kernel@pankajraghav.com/ [1] Link: https://lore.kernel.org/r/20240823200819.532106-4-dhowells@redhat.com cc: Matthew Wilcox (Oracle) cc: Pankaj Raghav cc: Jeff Layton cc: Marc Dionne cc: linux-afs@lists.infradead.org cc: netfs@lists.linux.dev cc: linux-mm@kvack.org cc: linux-fsdevel@vger.kernel.org Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/netfs/misc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/netfs/misc.c b/fs/netfs/misc.c index 607a1972f4563..21acf4b092a46 100644 --- a/fs/netfs/misc.c +++ b/fs/netfs/misc.c @@ -161,6 +161,9 @@ bool netfs_release_folio(struct folio *folio, gfp_t gfp) struct netfs_inode *ctx = netfs_inode(folio_inode(folio)); unsigned long long end; + if (folio_test_dirty(folio)) + return false; + end = folio_pos(folio) + folio_size(folio); if (end > ctx->zero_point) ctx->zero_point = end; -- 2.43.0