From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBAD5C54FC6 for ; Sun, 1 Sep 2024 22:40:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21D638D0057; Sun, 1 Sep 2024 18:40:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CD698D002D; Sun, 1 Sep 2024 18:40:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BC468D0057; Sun, 1 Sep 2024 18:40:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E30058D002D for ; Sun, 1 Sep 2024 18:40:29 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8CFE21C6541 for ; Sun, 1 Sep 2024 22:40:29 +0000 (UTC) X-FDA: 82517639778.07.DDBEBB5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id C3B5D40011 for ; Sun, 1 Sep 2024 22:40:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MyPWQScQ; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725230359; a=rsa-sha256; cv=none; b=Q+eRswKwoIQgRfeWKgz/sSeW1NKVUXOwV3T9HUSeX4Ci1Ydaz+5SlMVGAiQFGKfT9PepiF 9WoOuo+PfL9zTyu9RNLLG2oi9rm0PkOBz2jemMKqaeq0dzmU8kJkB7v7dM5sl3ZeXjupJ4 mU70/pNxoYngM/w0yGD6vGyPyzQXTps= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MyPWQScQ; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725230359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DkU2g2HqY/uroMJaOSsWSLyTQh11cR/pcX3099F8GRE=; b=CGWIqjuk0NrmbR21zGUmQo1Ae7/zqDcUb4DBQ1sK2cvemwkgaJ/xXMsF5TlJuEBQYE3S5o CUVqTH0m1JMUUBV4+lIZjcYR6vaAtc+/6TSiDVEVPLvino7PueiQBbHm+wrCMXaxrFbuyo 7DsABgRk8rctmXC6SbgxLtjn7UIXTjw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 50C2E5C56D4; Sun, 1 Sep 2024 22:40:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2509FC4CEC3; Sun, 1 Sep 2024 22:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725230426; bh=cBK8ifRIkWx9LTf3ePvAC1yp3D3Rig4E4eLktnCzD6c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MyPWQScQ09ooZoZlVyqX5nBhbQcSGuqwJxphQsd85Iaap9QtTufkGGhKwGEoVpVvu fJro5iLbyA6o9itsnAgCjdS2AiOtoi6p+0FuNForCnWmcVWL9j0mrG+DI8UFMR43ud +kilG3PWLJnzoEQQrCJB07gFkg2HMQiUQAvXJl9s= Date: Sun, 1 Sep 2024 15:40:25 -0700 From: Andrew Morton To: Kairui Song Cc: Jingxiang Zeng , Jingxiang Zeng , linux-mm@kvack.org, Yu Zhao , Wei Xu , "T . J . Mercier" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: wake up flushers conditionally to avoid cgroup OOM Message-Id: <20240901154025.bbe4a99e228b36d50c1c91a6@linux-foundation.org> In-Reply-To: References: <20240829102543.189453-1-jingxiangzeng.cas@gmail.com> <20240830173813.c53769f62bf72116266f42ca@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C3B5D40011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: taam9mobmxi6gkxow4hnubqnmrph6zn6 X-HE-Tag: 1725230427-582411 X-HE-Meta: U2FsdGVkX19pcxdZS6AoTNbYERrkv0sxrIpCUwvvT8INsnnrEs3pT1hzsTT08IbYpaCEJmlY8jOX9eWFFcOyT1/FZzOrhppnTz44OeeDKNDUUjasRivu73mYcmdsKMRuv8xHGipaMxRYPFClqeKpYe/YePjnZLcrWVmcr91IIXvxqfGvZ6Ard6ANELcRElw6+7aNqmXpiXdaDrfyggMXxAOjy/nH8q35+D93gbT5yebIT/Z+9UooZ50Zv+CFTyiTVBjMLLAdjrqpfB7sMGRsGWcOIIUpbKf5tBwgShg++xfim8g0i4yFobHsXbuaiFY1h0Z2/2R/59Hr27qFtOhrBQiApeWESmKpm7nUC0g/CjGB0X2K88uH35u8Gekkrj3R0tUWLHAP5UmV3ZI42EtDWRohfVxJkebPqGK2PfadsL/nqmaFZxFUvnvERuvpewNus1wKifLRki4OlEB9hwDiKP1hT4GGkC9sbBNFHcVOGOv4eA1jvz4aMBcam8m5OQGLERmJfltq3w4rCsfbndKd4JKF1Mw4E1dfyD6JBILyvGBgqexg/M4RkyMM67BPK9YtfEsSAkf74z+MQHSzOlJo230DEmuvDi4M/u+vgBdiLf3K7XwqCn7gbgwUk3aQkG5hE4POnc0bw0dTlxU9EwuJaoxwevrVYjWxpTVxh+BtDcrbnPR05TTCZ+GUIP4ntQFvVLd8vpn9J9WiRI2A3+/7C0vXAqzjPnRSALcNxzUJ4+BbUGS7hNK7VNMLty4Xz1U1B7+cL4R4tOpo78OK0MXlxKG+3aXYDgaiU3z2oW1YPLuOQGJvHgUNn7U3/yLwC0MwAR8w1fAbI/EkCzoGgVM6I6YmMtnIUJpfrEmR1rqQ1uC9D0W3LA3KqyBgyGEM0XJJ0pLmdlN7Ot7oXNkd4SkJbLX0hq7pVp0M9pnrvDoiSEmERrZWByg3rb+rKROhue1uef51eKWrPFDGNYqDDjl j6n7UG2X aapLqJuL8IWIjtukcc1IM/jvpr/rbZr1mISRXtPa/qw0ocjjRhQuIZyJYz0u270jcnvFkYjNICvp+gwJE0n+C7JOFSLZ3cKdChVGdCOaJib/VLoO24oNNk3Ck8bXRMxta49H9eL93YuiFP5tA1bYW++SnIc4J+5F9OhZQ6l3vwuHwZtJ4zLX3hb4D5/5IkNZoqYixNWCzCAkS7xdsaMQMGcRxeSY/Nx9gksE9IGwKwRrljJ30U/jtYTYGyIHdNtK48gXuDp0eusyvCWZiM9lIvseWAyzVJ35fUKcOSDDNkuBmqP1gPyB3im1GxDepd70eJD67jUGmTGERHUQc2bWq57ADkknhIomxJAbQCo4lO/iLBLI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Sep 2024 04:39:24 +0800 Kairui Song wrote: > > > MGLRU still suffers OOM issue on latest mm tree, so the test is done > > > with another fix merged [1]. > > > > > > Link: https://lore.kernel.org/linux-mm/CAOUHufYi9h0kz5uW3LHHS3ZrVwEq-kKp8S6N-MZUmErNAXoXmw@mail.gmail.com/ [1] > > > > This one is already queued for -stable. > > I didn't see this in -unstable or -stable though, is there any other > repo or branch I missed? Jingxiang is referring to this fix from Yu: > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index cfa839284b92..778bf5b7ef97 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4320,7 +4320,7 @@ static bool sort_folio(struct lruvec *lruvec, > struct folio *folio, struct scan_c > } > > /* ineligible */ > - if (zone > sc->reclaim_idx || skip_cma(folio, sc)) { > + if (!folio_test_lru(folio) || zone > sc->reclaim_idx || > skip_cma(folio, sc)) { > gen = folio_inc_gen(lruvec, folio, false); > list_move_tail(&folio->lru, &lrugen->folios[gen][type][zone]); > return true; I was mistaken. I don't believe we ever received a formal/usable version of the above and the mm-hotfixes-unstable commits Revert "mm: skip CMA pages when they are not available" and revert-mm-skip-cma-pages-when-they-are-not-available-update change this code significantly.