From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E559CCD3423 for ; Sat, 31 Aug 2024 20:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CC848D0035; Sat, 31 Aug 2024 16:07:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27C748D0022; Sat, 31 Aug 2024 16:07:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16C498D0035; Sat, 31 Aug 2024 16:07:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EC0C68D0022 for ; Sat, 31 Aug 2024 16:07:46 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C3A741062 for ; Sat, 31 Aug 2024 20:07:46 +0000 (UTC) X-FDA: 82513626132.29.3B5D008 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id B8D1320015 for ; Sat, 31 Aug 2024 20:07:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pakqoYzC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725134842; a=rsa-sha256; cv=none; b=lYqpL8Oe22yQGOlyNilAHKtTlJTha1kkMGfDhNmULi3pyeImg5tfGqckBWBTao1I2WsY6J ZtGHYx7HEGAtKKPflYQwGhguC40p2wPCSVZn/XQGQNaMxu45yo+Vkx1UZlgJoBqr4txd1+ LTmiTFQ3I7R8P8SyK2jVN2QerD9ZEOA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pakqoYzC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725134842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GBMHWQYc+vZoZVc7300yp/BeeipJEWCRRCeJXW/vvrU=; b=vBgowN2IePcbhc7JrtTArlkkBl6+frZPKuoPNmZkeX359Cu+MwMEkcWC4Q/VFQutVy7YPV UxvPaYB/lvy3l0wAJ2I5ertsVGLrjUZu51WwJXFubBx2HAossfkOJat2Sj0u4x0M4OrvH0 xeCjNCSN3Zui1+0BFvo/KfJ4Yk994Tk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0D8A95C1053; Sat, 31 Aug 2024 20:07:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45AAEC4CEC0; Sat, 31 Aug 2024 20:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725134862; bh=w61CWRjQ/tWD0Rt1f3CNPyjy/rWQFUKjrkO71Cn6AmY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pakqoYzC/OtKkNr2O7L/3vh8yC0azLcXaxWgxKDV2jxU2BiiSYmADJMWMG6GxLs40 QpnkCVyVKb8ME7bmLFppJ8xoGwM7uxWF7cSxaCIaaIFsdDl3PNLO3w3wf9UtzI1tLv ZJkqhSuJQkMjzLFC4vXXnVSOg3rCbUUzYzoa/jjTQpma2/73qfzrG7FruXNXvFKsuN s35BLcJT1lOLpzzJ6wcD+3p2HWy1PRtTFGqu0SSr2EvBKwlvQ44FzvXEJWhMsodJFq /HvTVsreWLW3zD3Rd82sIK+6+46i1l0AW2hcdiOo0secaRzc3cwe1dCnryceNoEZqo VBebEdHY5IBjA== Date: Sat, 31 Aug 2024 13:07:41 -0700 From: Jakub Kicinski To: Hongbo Li Cc: , , , , , , , , , , Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Message-ID: <20240831130741.768da6da@kernel.org> In-Reply-To: <20240831095840.4173362-3-lihongbo22@huawei.com> References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B8D1320015 X-Rspamd-Server: rspam01 X-Stat-Signature: 3seqy9fp47ymu5w6uugg9ur89s6xgt6z X-HE-Tag: 1725134864-601142 X-HE-Meta: U2FsdGVkX1/j6i5SDk9KLfDqJFEAzI2Mqb7WmVPVhTKi9p813eOaqzDJBXexHfeoFUobBfu2ARNvsFJZpuZ135ZvVnc4TfU+rhS+VWzvKRyopb+qhsDyrfm4/qdg2a8JjaVkO+Lxy9K4CdCG/BoYSeoIvi6faIExMK7kPhDOO8LKbBrNTFNGxlY0RVgGHT/lZG5TL94OFCjDPgWp9XE708ooBgaPAJM/9FodRnA5ENliiSwxAFAafHNvjcLIKG6dEiRdkHbqMy6lQXJoE+EKUzumQlG6Im4GWYir88tbw/ouEeKFOkl6mgl2XmZ30WFZdOLmqNKDGODK1oF183v38CLWzMmpSl4fd8F4lOjqUyrr101e1aN2iJJuALL9wsT/hX8WTe7YSU9WQ/0BECZUo/JuiUawUGtIgRTmqKmaT1whAiE9bK0uf3BoGYaV4Fr7t9u9nUXX6zDPM6wOOt1SFS3Y4ZsgMPZibF6S62Ws1/i4zq7IM+CGN8wxIdSTAPgENOXzs6BpccqTXKE7nv5GpODk/U0Wd8hEs9knxVnIPjYlU0z0mCvNrqXmh5BWEM2su4UB9zlw4t0SKn84jm3wu7WRNm1KMIw7AMR30+QnDY7H0JSYQc1+Nr4XM9RCJvyFRKQ2i1Mzq7HXYOc/549ypfzlpoWwuJA1PUr9+/1VxdxSaa8XuTZEmc9MG0ecqYNWHy9wQfm9KJUtlIw3ilTX4jdp35XWh45CPorFW8qxhJy0UUfnbxzOjbwU4as1rPve0UQCZanIjdaYL/fuQNcIWhX3h6EXzjob9kwpugbZFFvWp1vPJbKYMgGkRnUEZA7YLjuje+GCQK2ylz3DtPMN/lNE8pvrSxvPLZsqFBZKyiXOHDWP4Db7hIK+zSqRViBgy3CCTpThj5f7mdxmLCyEU5wrKiGJg1pCpohHTi77M1DYG0PsUigM74Lo4wEj7qo1tx8B5A6uDS22KhDq33A q2hkFTDs pveR26OL+Cd9JKAcwtXZfs6BY3QvpClwNhezOjPLsZh0aI4Bv1avaXowzjOET/GPKf2P2qp3Bv+j0/D0Ly6nq5nliMnCf7/40KYDUmb+xTWDUzN/kkBzQiVvi5KD1ln92Iquf5pfugU/XpZoUB8t0SjYUluFLg+QXqlD+9NO/tsLvf7umO/L12GoFt0MApKFqpToE5OZbFYYHSEJG4nHU4YqD1/Hfci2y8PlpFpYyFiQbFzLNe6p53uzyFjZr60IDZGnf4uFg6dugXY0v31boMp4eLTc/sMsxeWfdC+m2mJtDfnPvzDVEaPX5rWtUj9Dpe0MRJGT8u8bSESsTI8uKItCLF9LS3yaEGbf1xj/ccsrgRXclo3gE/Z4B8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: > Use str_disabled_enabled() helper instead of open > coding the same. > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index 6fe5e8f7017c..29647704bda8 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -3178,7 +3178,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd, > > /* [unimplemented] */ > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", > - arg ? "disabled" : "enabled"); > + str_disabled_enabled(arg)); You don't explain the 'why'. How is this an improvement? nack on this and 2 similar networking changes you sent