From: Hongbo Li <lihongbo22@huawei.com>
To: <kees@kernel.org>, <andy@kernel.org>,
<willemdebruijn.kernel@gmail.com>, <jasowang@redhat.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <akpm@linux-foundation.org>
Cc: <linux-hardening@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-mm@kvack.org>, <lihongbo22@huawei.com>
Subject: [PATCH -next 1/4] lib/string_choices: Introduce several opposite string choice helpers
Date: Sat, 31 Aug 2024 17:58:37 +0800 [thread overview]
Message-ID: <20240831095840.4173362-2-lihongbo22@huawei.com> (raw)
In-Reply-To: <20240831095840.4173362-1-lihongbo22@huawei.com>
Similar to the exists helper: str_enable_disable/
str_enabled_disabled/str_on_off/str_yes_no helpers, we can
add the opposite helpers. That's str_disable_enable,
str_disabled_enabled, str_off_on and str_no_yes.
There are more than 10 cases currently (expect
str_disable_enable now has 3 use cases) exist in the code
can be replaced with these helper.
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
include/linux/string_choices.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h
index f3670dbd1169..c2134eeda1fd 100644
--- a/include/linux/string_choices.h
+++ b/include/linux/string_choices.h
@@ -8,11 +8,13 @@ static inline const char *str_enable_disable(bool v)
{
return v ? "enable" : "disable";
}
+#define str_disable_enable(v) str_enable_disable(!(v))
static inline const char *str_enabled_disabled(bool v)
{
return v ? "enabled" : "disabled";
}
+#define str_disabled_enabled(v) str_enabled_disabled(!(v))
static inline const char *str_hi_lo(bool v)
{
@@ -36,11 +38,13 @@ static inline const char *str_on_off(bool v)
{
return v ? "on" : "off";
}
+#define str_off_on(v) str_on_off(!(v))
static inline const char *str_yes_no(bool v)
{
return v ? "yes" : "no";
}
+#define str_no_yes(v) str_yes_no(!(v))
static inline const char *str_true_false(bool v)
{
--
2.34.1
next prev parent reply other threads:[~2024-08-31 9:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 9:58 [PATCH -next 0/4] " Hongbo Li
2024-08-31 9:58 ` Hongbo Li [this message]
2024-08-31 9:58 ` [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Hongbo Li
2024-08-31 20:07 ` Jakub Kicinski
2024-09-02 1:27 ` Hongbo Li
2024-09-02 6:10 ` Gal Pressman
2024-09-02 16:11 ` Jakub Kicinski
2024-09-02 10:49 ` Andy Shevchenko
2024-09-02 14:30 ` Willem de Bruijn
2024-09-03 6:25 ` Hongbo Li
2024-09-03 15:09 ` Andy Shevchenko
2024-09-04 2:27 ` Hongbo Li
2024-09-04 14:33 ` Jakub Kicinski
2024-08-31 9:58 ` [PATCH -next 3/4] mm: page_alloc: Make use of str_off_on helper Hongbo Li
2024-08-31 9:58 ` [PATCH net-next 4/4] net: sock: Make use of str_no_yes() helper Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240831095840.4173362-2-lihongbo22@huawei.com \
--to=lihongbo22@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox