From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91C8CA101B for ; Sat, 31 Aug 2024 01:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A2C06B028C; Fri, 30 Aug 2024 21:28:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 752ED6B028D; Fri, 30 Aug 2024 21:28:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61AC06B028E; Fri, 30 Aug 2024 21:28:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 332806B028C for ; Fri, 30 Aug 2024 21:28:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F8D21A07E8 for ; Sat, 31 Aug 2024 01:28:50 +0000 (UTC) X-FDA: 82510806420.24.4AF0BA1 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id C50F4120015 for ; Sat, 31 Aug 2024 01:28:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IQRJ6MOd; spf=pass (imf29.hostedemail.com: domain of nathan@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725067637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rIeRYFicqvh9lxqMsJFMh/vRvWfO4XEhp2UkPo0cwBs=; b=BCUqmtT7bWVGA97/bL+j29dWtEybjIaHOA15zx6o0wTr9hFuPCjQU/byvlYNQMJa7JrY2L yJO4sPxHhxw7DRMCUXGZ0VbBAh4nLzC1yTsi/DkNNGa7FcyW/4ytHQYzRAcdTqbHe7JEGG c1r7VypW8KRV8F3tJAuTvHjro4QVw0w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725067637; a=rsa-sha256; cv=none; b=N6IGgEr+ZA6p04YpLHljns+n0Q3kcVtVN68R9qZnaWMoAUkh3mOP4Ss3a+T+TMH/u6MGPK Dn3yZ3G+Cwerq+zVWPd9Lrx53uJL8X4z+4RAwC1Vi2ppfCzpdpCKjjXsdDWzRnA8mEP+QC KtT9nyR7sRwE8Udrs2Q0jk6GReRWRa8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IQRJ6MOd; spf=pass (imf29.hostedemail.com: domain of nathan@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DB71CA427AC; Sat, 31 Aug 2024 01:28:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE424C4CEC2; Sat, 31 Aug 2024 01:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725067727; bh=/oIGIDZx1EL02vEkq3oxHjcflX1plTu8Qt53MH7r1RY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IQRJ6MOdEtrMwpjTXOeOKZjY7iYkZVdKz/t1kSB2S2micXC7NijpqBiChwUeMXAfB VuoHIXO77FXSh8wHPVmXu8mYY9ZAfd4NIqxzm1PcOFQYUPNPVGnsAKtTtoKUrGfFsw pa38RfrH6AGyeCsBCyWJA+xqsjc3uTF0fj2756KF/bIv50NTP94a/mR79qUaivVhV2 ZSRTnttMSClZJRzb5hsEgpDmEskXgtTWkJP+UUavoqhePADZ39of7LxokpQtsi7drX XL8aTaV6dB1ID/toAVbcMwU9Rju4iQY0GarEPljT6Iup5ESUVj/HBoq8g1Kvf7mst6 KqDrYD01NjWQw== Date: Fri, 30 Aug 2024 18:28:45 -0700 From: Nathan Chancellor To: Andrew Morton Cc: kernel test robot , "Liam R. Howlett" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List , "Matthew Wilcox (Oracle)" Subject: Re: lib/maple_tree.c:330:20: error: unused function 'mte_set_full' Message-ID: <20240831012845.GA2993938@thelio-3990X> References: <202408310728.S7EE59BN-lkp@intel.com> <20240830175015.3569d261b0d48d46eb6ec1cf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830175015.3569d261b0d48d46eb6ec1cf@linux-foundation.org> X-Stat-Signature: 8t6cp18miqi4nw4ucdkfqijn8kzh3epx X-Rspamd-Queue-Id: C50F4120015 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725067728-13135 X-HE-Meta: U2FsdGVkX19lEP+aDy6LI4KUJ1bWE+1HDZ2kZtVqmqdUlfCZp8nEywwPb5i2gRQ9clOlzwZdt/wmGvPDNMJQBSy3MbwK3fdST1MedTr4zoX/wl04crz80gkrX2hfa2Ek8eZn4j3/mBRaXQu1+F7NSdQ5OznjOsf17c01pDtYnROygSwHTLVGvnhBWv4wcqMFAgZIKX/SJ5/rA8N6BdfsIcHFm08SDygBhXIH9oxm4QElR6fBFSn7Va6d9Lj+dIreJ9lVncm51she8FvewJMKEgZJXUfDm/Qm/ddexC8uKKu4njTzZptuANz5XpoLqm72VypLfDFIWRInbJCHebDXarLFECr3KUyajCWZXEoSO1pRtVBqzFoBZa+YlhN2mmqtEd3/o1Sg0DzN6q067JacdG3Zx9xPN8b0arNs+ZhOQU8bvdI2oo7AN3HG2WJjG2iqxSEGG1kBlldHhLq4ZAuzvhhqVaxgbLJ4mpYlBgvPgTUrOezuKul5VWaJbV1XAtJOWeI+2/T3gsOQMiw1VaTVVYnqOnkFfEFpqBFdVJK8MLwSgavT8as01pW0M6reP+c8tHjmWCorSErC/RYG0Pao7B/hWgfXfs0Vlj9KR63j8aMO5+Od/HYj3uh4JWcqjrsW/tFNrRVLiyqyM73NNs1mhIuvIGlZnt6dTVFR6ojCFd8I+cO4CpazbVZggfZ4KZHxk+dZK8Bxwrvl2MkLgYTW1v3p7KKRC375tkyfRsbrZWbpvm7KF66zcZss37ymlEQbyP5TRbqhTV9t7LgJ7D6YyalvJxGc6TyJ6yzEDD9xsgtgM9iItzfe4iZJxaNELCrwX0KqH4RgwIGHmQITUC2d9mASNJRGnsP3ioPsl9n7aigj4I1mJm6rkFCQN6opxVv752Xb4DEA+Jxix+mw60NFLt7huDKlhzpJMhYdyG6a0CgdqUmHWLA+Umt7RjWW3IOVAG+tYEK7XLFsgkhDphA 7cDaI6pU TiyMhYfZ0PCfdcNNfUEaeWNtXR4aYY6SuTzmU7JOS5m5TJM7UAgV55aZgEwmJchEUUtVd07uNvE9c/mqdpZppBguwFKoBhJKZAfGAcFZth0vpkjAWu/rY5tQSYJD+KUdqlSFaqKk9IdyWtX9kzb9BbMrAtZ1vQZ9M1GsNsirmFTh4PY9pRYcLFHkqGBxN498XM8s9egy/vWUZJur7QCBY2iC2Mh/dr5M4RIWpWlTTtAtJeY40mUQ8VlYdffBA3D6gOQ6/d04BoGdmjDWUvriKM6w9wuLELSeBJ2zyNd81bZTkos1anS5Se2l4w7B+cC33cobuwEKlHIoDDwGq/QH28EutMPBw//+JQ4rgeTnfZ6ZH2A88yGznI4ykcDZkpDQfSUTf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024 at 05:50:15PM -0700, Andrew Morton wrote: > On Sat, 31 Aug 2024 07:42:38 +0800 kernel test robot wrote: > > > All errors (new ones prefixed by >>): > > > > >> lib/maple_tree.c:330:20: error: unused function 'mte_set_full' [-Werror,-Wunused-function] > > 330 | static inline void mte_set_full(const struct maple_enode *node) > > | ^~~~~~~~~~~~ > > >> lib/maple_tree.c:335:20: error: unused function 'mte_clear_full' [-Werror,-Wunused-function] > > 335 | static inline void mte_clear_full(const struct maple_enode *node) > > | ^~~~~~~~~~~~~~ > > 2 errors generated. > > afaict these have never been used. It's odd that this was just detected. I don't think it has just now been detected, as these functions have been flagged before: https://lore.kernel.org/20240503160821.GB3960118@thelio-3990X/ > Should we just zap them or is there some reason to retain? >From the above thread, Liam and Matthew seem to want to retain them. Perhaps just wrapping them in '#if 0' and a comment that says these will eventually see use would be a happy compromise between outright removal and doing nothing about this warning? > --- a/lib/maple_tree.c~a > +++ a/lib/maple_tree.c > @@ -348,21 +348,6 @@ static inline void *mte_safe_root(const > return (void *)((unsigned long)node & ~MAPLE_ROOT_NODE); > } > > -static inline void *mte_set_full(const struct maple_enode *node) > -{ > - return (void *)((unsigned long)node & ~MAPLE_ENODE_NULL); > -} > - > -static inline void *mte_clear_full(const struct maple_enode *node) > -{ > - return (void *)((unsigned long)node | MAPLE_ENODE_NULL); > -} > - > -static inline bool mte_has_null(const struct maple_enode *node) > -{ > - return (unsigned long)node & MAPLE_ENODE_NULL; > -} > - > static __always_inline bool ma_is_root(struct maple_node *node) > { > return ((unsigned long)node->parent & MA_ROOT_PARENT); > _ > > >