From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E826CA100C for ; Fri, 30 Aug 2024 20:22:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07A726B025E; Fri, 30 Aug 2024 16:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 052666B025F; Fri, 30 Aug 2024 16:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E354F6B0260; Fri, 30 Aug 2024 16:22:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD5436B025E for ; Fri, 30 Aug 2024 16:22:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5C86E4051B for ; Fri, 30 Aug 2024 20:22:33 +0000 (UTC) X-FDA: 82510034586.03.7E7314A Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 5A5C6A0012 for ; Fri, 30 Aug 2024 20:22:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=VS7uUK64; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725049259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JR/0i0yiNSc6+4mgZmofS3FVrEo7P/f9nDPweyfHOlc=; b=pNyY8BYF6hJ+zeT74HiUM4bexPUmQnZUxPPb0SCDKW53J0YB+GPpuLi2QH5VcULQEmH01b r446m/+QcwYATg178AGGTajCtsCTB/WxC725frxc/01QT+urhJ3Uop3I+RRRsjbGnDkBBZ PLmZhqSOFXEuqwtyM5kgA3ArWCUQxlU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725049259; a=rsa-sha256; cv=none; b=2JoyFqlvzMUM86bzgvZVbezVZIBVpzBkqMzBhtqUaWMi7j10e+TbkO2ENRlHhKCXJ2ex3K OehPHZRvfcWxu9yv9mJPE5yD5lnfgc5I3TyR+RZq4e20Y4L+L7OGjpOaT0zCJThrY5v9PA Rh9PjDMa2KS6tH0lt1n3abGcMEoc3sU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=VS7uUK64; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7a7f94938fcso144001485a.1 for ; Fri, 30 Aug 2024 13:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1725049349; x=1725654149; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JR/0i0yiNSc6+4mgZmofS3FVrEo7P/f9nDPweyfHOlc=; b=VS7uUK640DcBQA28okfWWqxC59WY44tXx/ulosCU/HxQ6MagFPzbWDJ60Deb1oq9aG 5T5myF1AV32FjMFe27YoJVrybA3rH0L4V1OonlDZeWDw23AdqCRv25JEgi3dHhuby7yB lwmTpP48/sDPLZTANbZLfkiHhbU/rq+l31ubGls5lETDqp6U+LstjL+dzUBAmS1zA2FR ideCrKKoXsylmUONMwXr5LF1oc/7I1XgnpBewhOvoXdIGJQGvGRWxNDN2TLHbS/XKdGa jKWWcK8T0tj+dSW33JZIsQrx2UvsTdPXiegdlK/oS5UjfffrKc/EiJ3YCIdz3sHhtq6o 3yrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725049349; x=1725654149; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JR/0i0yiNSc6+4mgZmofS3FVrEo7P/f9nDPweyfHOlc=; b=qfKNCnzTNZIeFFPjPEFbp5+9Rjq+/NIXfVcqUp4k46c2ogmswQbSFUwd2Xr9MO52mE +bEcEnziLI6AGg2Xi97YRWKsqVJaayfNNkEfHgDgzryajuB9TnivQXQ/W4VSAha35QPW cKRQWkV4vlxngPB7srql7aP3RRMmkMp9yoV3fSgBuMYVNAvcSnWy67aSCmtrageOr+NX INRxEuVCaBT4+C5xl4Di1RZgveSO+qTivdFBSbkTFgwoOCl/R5D42qpTzxyts/i4Vx0+ u0N97eyyhWyp+8nOOmkdj+MSWItLM+L7qiWjrdVDh9ocqxUTA24H319fA5umeAokeyVZ X/FQ== X-Forwarded-Encrypted: i=1; AJvYcCVz2rhRejP/vmpN/LfQLcGqTm6QXHBYfYntlFp7fAaOsmhe8cfI41BNmpr31DBIriH3muTUV5EMMg==@kvack.org X-Gm-Message-State: AOJu0YwB1DgHuYo1kP1KRt7zUjVVeDe/rR5VyVA52b4NqjXObG5FiVxA +qNvpOpO2iyT7gxvRECYknWKTYKp4Y+YY0do6DQ7cQG7pmcu/AZHxE5UqCoTGe4= X-Google-Smtp-Source: AGHT+IE3fznrLjug1k6BmssxKA2PoSv1rWSM5UMVETLEHHqg9/Fb0jaD+sDVJuxj/qFxWflQcys1Iw== X-Received: by 2002:a05:620a:f06:b0:79f:57b:f633 with SMTP id af79cd13be357-7a80427797dmr757399385a.56.1725049349148; Fri, 30 Aug 2024 13:22:29 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45682d66c30sm17088371cf.68.2024.08.30.13.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 13:22:28 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1sk88a-00Gb36-36; Fri, 30 Aug 2024 17:22:28 -0300 Date: Fri, 30 Aug 2024 17:22:28 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: James Houghton , Andrew Morton , Paolo Bonzini , Ankit Agrawal , Axel Rasmussen , Catalin Marinas , David Matlack , David Rientjes , James Morse , Jonathan Corbet , Marc Zyngier , Oliver Upton , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Suzuki K Poulose , Wei Xu , Will Deacon , Yu Zhao , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 02/11] KVM: x86: Relax locking for kvm_test_age_gfn and kvm_age_gfn Message-ID: <20240830202228.GB3468552@ziepe.ca> References: <20240724011037.3671523-1-jthoughton@google.com> <20240724011037.3671523-3-jthoughton@google.com> <20240830124720.GX3468552@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: joykwb4ar5xyqohd4jggjj13brb7jnyf X-Rspamd-Queue-Id: 5A5C6A0012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725049350-699457 X-HE-Meta: U2FsdGVkX180QpPOUQXcjDaCYVmk1ZgzBShhkLu6PGJhes+G6vMyfU7vKP+aiqI1ogB2Tc/xa+R3Zj1/2JQUQH0NdmHLU4Ug2YcoACAgeO3JK6blJI4LtdgZlNFYtRWNloOzq9CS4GAVZMyz5wmNYEXjsbNaeBD89carFpuGoIh5PfrrpCgTmmuh+AEIvKS5uUzOpjxIfXk+HMv9Hz82/mT3BWFaDEYhKXyGB+2ESy35AwFh3Pkw7885/lzEFIZLLEdUDzstHIFca1SZIqGO3PX1xqdS7fAsLrbqV93fy49v/DBNXTdGrLarySm5IUyyNN/VJx6rf0rvE9rmehDnz8oTufS/COablh175+Rf1cYkKIHHecFv93l8JmeKmFHaa4nyUqcKRzEpssm0ogjaw0z05bvF29qhruaL3yl+qk/BjWMB3CJdtdp/6RtXulaqm8ggsZMSEFVE249E9xL17pzBRZd0n88yWEsQgajLhi7naEdRWHw4AUebyABjYs61Zh4TGXtOjVBXyD3VPTAKQ9AOkqLZPU6HrtDRyMrSaT0lFSP0edVigZyoyvJTz+HnUw/sOMLjuZ9ZzB3009ZR0DY4vPHICeMjLrj/gMOMbPop4JhOOoxXSxyzPiU0a0SBfsnczrvUvGKdJ3XZdQEt5phLdCqwJo14r1ZZAwN1eKFrwqNTNxtxD2U2npBvWzEJjsNZn5XvC7VN6tUR+npsyn0W59z7FniRkOL6GeZMMUAZXIUib2/ildzasfOdlADo2JAq1MYb6QesT8LgLPaYdOIBg8UALmUisyQVXjVtvWt+wT86hdk81wrZEoOufo4UvxMw2go8X/+u3UCS56lGcQpp5iff2i22efHubnQovYIZmRowQ5zxBXh7TrUhhP89wJtnwvHR4zbGgRuA3TL/fbm0DgQlV+ka7ItiBlLgrERZxZZ6xM8QTXUJhTXGCWal7+JnA524O7B4EnEsIYQ liIwPKyo JTpmYX1FED7eOA9OcrOOH0RC/vzXL1GkiUqlQKNId2NrgaDhtpoecy3cDcpbLaXB8ftFZ3fjMvsNBoXPF9smtZLed1/N1VPCc+fdbMSyj3eS6d0Xsd/H+8E0Fn8qCQsfBq21ziIgya4LlcigpgmAxGgJ+k3tb/+T2H8PB8LhWnjvURJ5Lg3PyuVvpRxhyStrjhiXYSwU4BXjw+sqe5CIG02mPLmduKPax6m1uwwIQ19NEIOlNNp70jmW5FeJKqHog2Fb7XaBgmZNzE9hv350SN6eCN229p9Qedz2IuK+ZVUyu2yhD3Y3BioalQvjUtQflq6vpDkUAZCYmVz4jeEVHIYxby/kHrvKrbpzgh87kAGhImvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024 at 10:09:30AM -0700, Sean Christopherson wrote: > On Fri, Aug 30, 2024, Jason Gunthorpe wrote: > > On Thu, Aug 29, 2024 at 08:47:59PM -0700, Sean Christopherson wrote: > > > On Thu, Aug 29, 2024, James Houghton wrote: > > > > On Fri, Aug 16, 2024 at 6:05 PM Sean Christopherson wrote: > > > > > > +static __always_inline bool kvm_tdp_mmu_handle_gfn_lockless( > > > > > > + struct kvm *kvm, > > > > > > + struct kvm_gfn_range *range, > > > > > > + tdp_handler_t handler) > > > > > > > > > > Please burn all the Google3 from your brain, and code ;-) > > > > > > > > I indented this way to avoid going past the 80 character limit. I've > > > > adjusted it to be more like the other functions in this file. > > > > > > > > Perhaps I should put `static __always_inline bool` on its own line? > > > > > > Noooo. Do not wrap before the function name. Linus has a nice explanation/rant > > > on this[1]. > > > > IMHO, run clang-format on your stuff and just be happy with 99% of > > what it spits out. Saves *so much time* and usually arguing.. > > Heh, nope, not bending on this one. The time I spend far hunting for implementations > because of wraps before the function name far exceeds the time it takes me to > push back on these warts in review. clangd solved that problem for me :) Jason