From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C48CA101B for ; Sat, 31 Aug 2024 00:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C670F8D0002; Fri, 30 Aug 2024 20:50:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C17506B0171; Fri, 30 Aug 2024 20:50:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADEA08D0002; Fri, 30 Aug 2024 20:50:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7F2906B016D for ; Fri, 30 Aug 2024 20:50:20 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D8B9D14076D for ; Sat, 31 Aug 2024 00:50:19 +0000 (UTC) X-FDA: 82510709358.03.4CBA6CA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 2356F40011 for ; Sat, 31 Aug 2024 00:50:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QPhozql+; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725065373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sviQ13Dt3US+ucR7fUBCXHHPo34kKBrqcIcYoCUF7A0=; b=zQZKQHwLYi3t3ODq8/rx1x+fSotoBlUFfIrAzuo3kDyP+AOOvjX3PDaZ2hMeP11iDu3W+l WP33Yv4KtIXZrY3EVHfZrVXK2N83cZG8hEWys3scSmgXzeZwtXnlzwlWCfwGFFIP4WyVX3 6spWaXI6J0i+48zhFSzvwwg3agB6WXY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QPhozql+; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725065373; a=rsa-sha256; cv=none; b=1x9vp6dCil82SZqUOpJZSRD4eCREx4E2p0bArGu1YhfaIjTLHVUY3hqeMN1c2RuTJML3T8 nz3ZKZ4rkZdiZsK/wfkgOHh8H9TmPnv7EGBWCsU9ElWNI5y60cicMLI8v7SQ7pralVHuBq cBm4YefKhwG9rrqQUoU8pxzEz1p3gKE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A02C45C0FED; Sat, 31 Aug 2024 00:50:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 638C8C4CEC2; Sat, 31 Aug 2024 00:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725065416; bh=dArAaDyNKHpopF5ls6/ZjblTvjXOQ4qnRUSDMkJfEgg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QPhozql+04RQSZygVYg5aef32ibi/+VO4TLy45nz63AZPz+B/o09xsvspbJuDhf6t UnKS+L/aJ981ixFUrITnabMh5CsTZwMpS01Koj7Ai2IICQqLYgRhJXoQhbWVsV1+dr NegpmlC313N5m6G9XNcQwh9LnDSntIFdFEqsbBkU= Date: Fri, 30 Aug 2024 17:50:15 -0700 From: Andrew Morton To: kernel test robot Cc: "Liam R. Howlett" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List , "Matthew Wilcox (Oracle)" Subject: Re: lib/maple_tree.c:330:20: error: unused function 'mte_set_full' Message-Id: <20240830175015.3569d261b0d48d46eb6ec1cf@linux-foundation.org> In-Reply-To: <202408310728.S7EE59BN-lkp@intel.com> References: <202408310728.S7EE59BN-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2356F40011 X-Stat-Signature: qfw9aqznkt6pfucgs6gesg1xbrx17dmw X-HE-Tag: 1725065417-555457 X-HE-Meta: U2FsdGVkX1+ncaj1b2GU3Q0eEQHPWkk/Sa5fpD5dnHppteH49z3EdPCLonhJTpJY2/cME/zWjOZZiMpM70on3+FhDDSIq50nZewhyjyklE6Z3hmAjfi7Ylv0xvCimnnjXBhFP4TllXMhnL7ti8J3hRa1vdNiMyRS4WHwQLF4h4x4eWduD02o8EVKH6hf6r6qlAxyC/3rEGsqZTGSlULdlgh7Kn/YR4wFC/L1rbO5OxrdB39nq2jfn9cxJ3R0FYbZhwzatTWkAjR7SNEAcHFbMa2+Ziw9JCx8SWSwomPiLxUW3LQMiCwnk2L8Gt7CbfmXpgPOkVR4P8jjpoNR8l8MWdInwPRJ7q7K3TouqUXnXf8To1qgZabcWOPpgoYLor/zJGodtwSOCq9ix2FD/K0U+XjA18CxH/3g5yrz1uxk/6ZL0SPYmAFhqy0mvGm2fMWaqpTh+QiAWFLKKfdFrr9kuJsh9WaLJJCF5+lpQqWxojOJCF+nfXjF2FwXGk7A8TBQnp8kj1D9O/tVmgUeMROV6ZWnPJ5+SmZ3n0rUb4429zIF29TZJZyB45CSbpbXOwRLv3/P2Dyl3i4SD49/POAmhigfFxuYHLD+NTRUEAZ2UeWHblHTf7k5Q8PiR4owGIRE9Fca9S6RvI3450aE6a1m8UdCyDSUDtmLRNmbgQwzsnuOYpx6kIU50J0fSpmJbQ+1DzjRVgauAd581vQ7ikwNNXAEbnPGm+pLKZY3uff/ZJFwZQCvjQcDc+EOuc+CkU0t8MEahnWoq02I289hWEpXruVoQyccdnoNfsLovsVRFm//LRVNE/89tLTPBNMtmiJPJlKTbXW8BgBD+GyEgrpfa76cya/2MDeeKa/ClwBOBz9ynvtdSyQnyh8O2g8ucG8MrRyksyAVt6Kd8lfFXcrJPiWKYkarDJSLp5bBmspv7SxDsX/u6l47ZyskMEBXUVzdSOvvWl2xzx8tLzUiozr /LjB76Oi aqV+e7ICLSIKoLSbHEFL2+QE6u8zpAPO3qHPStxYWNtvmYG3oer0skH12vhp3xEH3sO0m4kvBfXFORBVzZram+ip1/zdhVzpiM+vxIBlaRrKFOmUTazETdpHq+/7KMzsioUlpb+1gINZuF5CleqVURE3FwQM9L9ZFGmZIxQGdiaaSZPqOI9SHB9UXTKQoStjxwXMdhe4KJOKeThHw1D3j53w77W8rVwTBX9g1L/MlxxPECwEPueSKJf+HNxhXzinDU144ZL4WQF/1wQc+74UZRcF3tIqLnaASLsACTj8p4381F7o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 31 Aug 2024 07:42:38 +0800 kernel test robot wrote: > All errors (new ones prefixed by >>): > > >> lib/maple_tree.c:330:20: error: unused function 'mte_set_full' [-Werror,-Wunused-function] > 330 | static inline void mte_set_full(const struct maple_enode *node) > | ^~~~~~~~~~~~ > >> lib/maple_tree.c:335:20: error: unused function 'mte_clear_full' [-Werror,-Wunused-function] > 335 | static inline void mte_clear_full(const struct maple_enode *node) > | ^~~~~~~~~~~~~~ > 2 errors generated. afaict these have never been used. It's odd that this was just detected. Should we just zap them or is there some reason to retain? --- a/lib/maple_tree.c~a +++ a/lib/maple_tree.c @@ -348,21 +348,6 @@ static inline void *mte_safe_root(const return (void *)((unsigned long)node & ~MAPLE_ROOT_NODE); } -static inline void *mte_set_full(const struct maple_enode *node) -{ - return (void *)((unsigned long)node & ~MAPLE_ENODE_NULL); -} - -static inline void *mte_clear_full(const struct maple_enode *node) -{ - return (void *)((unsigned long)node | MAPLE_ENODE_NULL); -} - -static inline bool mte_has_null(const struct maple_enode *node) -{ - return (unsigned long)node & MAPLE_ENODE_NULL; -} - static __always_inline bool ma_is_root(struct maple_node *node) { return ((unsigned long)node->parent & MA_ROOT_PARENT); _