From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9135FCA101A for ; Sat, 31 Aug 2024 00:38:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24A7E6B0193; Fri, 30 Aug 2024 20:38:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FA8B6B0285; Fri, 30 Aug 2024 20:38:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E9D96B0286; Fri, 30 Aug 2024 20:38:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D5C6F6B0193 for ; Fri, 30 Aug 2024 20:38:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 48797160788 for ; Sat, 31 Aug 2024 00:38:18 +0000 (UTC) X-FDA: 82510679076.15.B1C14E8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 8FFA0100007 for ; Sat, 31 Aug 2024 00:38:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=I4axDld3; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725064623; a=rsa-sha256; cv=none; b=w+FbLUWaRtJt077Kgn/gcBIQsJ1gNx6GA64LpW+dVO3eQkO6YIhq9SGCqYBiBXEDCywN/w 3+K3thOmCuwp9mMSyjGXVpxR1kYLlnq+1ZGtdQSSydOTgmIxv5IBNhCKl5v3bGqBOk08Uq Inqj4tPEszzfxfjVmBxtUPkK08r+H40= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=I4axDld3; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725064623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u1is+OydnSVrynWymOclTOerhCK3DHig1ThdaGSNH0E=; b=fpbPY370dpusyZD848/ebfZsYmUoUmcmtnqCoW2aXb3SPPpNn/cSOm0N9H6Tm8/TCGtsyJ lpzif8xAnLg8+bTVrMRu+rpJOY1/2qGzhWAIUwgAhLSxzluWKC+E7IfTy6Kn4a/8kWnocE pv6geBu6y49JKcOQlPqGo/IV6th7Bkw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CD9B35C0F97; Sat, 31 Aug 2024 00:38:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54827C4CEC2; Sat, 31 Aug 2024 00:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725064694; bh=41QhoOH043vB3lz1p4/QFHetCaG4BRSFEdl5XSgn20o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I4axDld3rFxM/mIdfbjlATcUOo6WidbcUVzr40cusz+DMssOens3X3GyvPkj8kqKv GMoWx6THtCgUzQty2MKBncRUTTpqspOO/4hDLgTi1FhcX2MLduJ+mtC+Nv6rBtq8dK CTuo2lYV3058JjLZLHwlcbJeET35X6mPRE0My5eI= Date: Fri, 30 Aug 2024 17:38:13 -0700 From: Andrew Morton To: Jingxiang Zeng Cc: Jingxiang Zeng , linux-mm@kvack.org, Yu Zhao , Wei Xu , "T . J . Mercier" , Kairui Song , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: wake up flushers conditionally to avoid cgroup OOM Message-Id: <20240830173813.c53769f62bf72116266f42ca@linux-foundation.org> In-Reply-To: <20240829102543.189453-1-jingxiangzeng.cas@gmail.com> References: <20240829102543.189453-1-jingxiangzeng.cas@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8FFA0100007 X-Stat-Signature: 8b49u17ys3myey3dkpyonmewgwgu1zp9 X-Rspam-User: X-HE-Tag: 1725064696-477763 X-HE-Meta: U2FsdGVkX1+2vlYSFo/E7mLQC9Oqf+Rgdq5XG8GQlX+B+6BmTJ1uQMMnkO6V+I9XBduuUSFwpjkvLM+uEjSgdjDi3j5C+pJ2ZfGNs99W/s+iKKQDzHx33yGAg3q+iN9Bl6f+G3i0JShZcvFmWftklHhNgztkz00j2LyTpjl9Mxc4jZ4qSBumvE62cBAQ8JO4cfnSAQzkPLFsKIUQFPjWsXzhMHWxsExdUQSIUGJsaZe+b+RZO0GjI9XaLXIO7x7FVA4dSIkFB2epaaxrgH5YnEEjTVENIKMKF/WNAK6oFMT6u3atoA9LbimjpA3hKmbnxjsJCaEcqcDRYwX4nlSsZZRmP4RcyhtnDbrsubo9OyI9fZKEqCaJwEjqgVo8mHeK5c2YGx4MjUHWII6exJA6VR//j7urbvuXom4EbuPVpUWLOcxdVvafmajUKy2ZmfF26JUkRDDctZ/TVWQz28aLwo5zYEhVgsRGWX0+UayChz/xA4pR67fIFn2rsxVFLMSL3Oleyb7XVBaG/q3PJSQA8QcX4RZA3h1se28CbsQeR2vQnW+l0jO6x1CvhNOudc/QTfgsFAIjz3JCZizkQIQMxAcBVV2QhuQaU2r9YKZKD4SOGufywfiuH645Zc515VzgnpheUu8TDULeMsMlNi3hUQ2QkO5COl81GJxkciJ7fMLl1ziQmBNztB/zhwhaG0JAoV4LFbvVFT6YCgU0hKjfjF1je+qGS771/E+t8lFEdoGyLnUjg4oRm/HRwUVzspqFXQUcE0GV2v70JE9g36G6fzD+gczN1vLY/ZFyohxDrd6kM+z91XRojKQPvCUHfr1Hv7OOJurxUaOVhI9J9JBCMeGb/GizsNt7QYEfERyyAUgQLuj7oQvgBa6IVnBIlQhnJvg09peMepT10G7ZrBjTTlnpaYtNmZ1no67UkTIOUe7sVTRAIafEZ7Aet+3ChXDG7gN69Cl8HRXOfOtpCh7 ENcCfdQm mBqTKQQKOiB3mdJc/gOQfwwuhRUtJP3oZx9XABBsoTangTMS9EmpQwlQi/1jCBuwhVz7vpsje9CUT2C7O7TRom4Ba9r4OvWfEbwQulXh3LotH4MluQGh4BBq25OCeUDiEKXb1gv9tZGCUUyDIh2AwMaMyJFiFOdaCbqQlH2q5McYyCZ0TX2VhSDywiFnn0Te+eF86FLjxYR4TNLyx1ICcl6FWKGz/O5xuezEakO1mP093nlgBMdD7G/RMwBuXNK6MzpWBPpFnisGgczVXrYw/UDzfRQGEkW23RvfDMu6nBPTXP6r5oM8mgvcCrcMUzh890Vig6ov6wqkr/dzzlc9HaLtJebiCErmoS0r6o+e1JwOfCeUTDzmlAANWau1Ru3UtcxKATEcVDDgsaus= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 Aug 2024 18:25:43 +0800 Jingxiang Zeng wrote: > From: Zeng Jingxiang > > Commit 14aa8b2d5c2e ("mm/mglru: don't sync disk for each aging cycle") > removed the opportunity to wake up flushers during the MGLRU page > reclamation process can lead to an increased likelihood of triggering > OOM when encountering many dirty pages during reclamation on MGLRU. > > This leads to premature OOM if there are too many dirty pages in cgroup: > Killed > > ... > > The flusher wake up was removed to decrease SSD wearing, but if we are > seeing all dirty folios at the tail of an LRU, not waking up the flusher > could lead to thrashing easily. So wake it up when a mem cgroups is > about to OOM due to dirty caches. Thanks, I'll queue this for testing and review. Could people please consider whether we should backport this into -stable kernels. > MGLRU still suffers OOM issue on latest mm tree, so the test is done > with another fix merged [1]. > > Link: https://lore.kernel.org/linux-mm/CAOUHufYi9h0kz5uW3LHHS3ZrVwEq-kKp8S6N-MZUmErNAXoXmw@mail.gmail.com/ [1] This one is already queued for -stable.