From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C905CA0EE4 for ; Fri, 30 Aug 2024 12:47:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F0DA6B0136; Fri, 30 Aug 2024 08:47:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A14D6B0137; Fri, 30 Aug 2024 08:47:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8416F6B0138; Fri, 30 Aug 2024 08:47:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 649506B0136 for ; Fri, 30 Aug 2024 08:47:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DFA2D8109F for ; Fri, 30 Aug 2024 12:47:24 +0000 (UTC) X-FDA: 82508887608.07.AEF4811 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf25.hostedemail.com (Postfix) with ESMTP id CD74BA0008 for ; Fri, 30 Aug 2024 12:47:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=CvBTLgcU; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.45 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725021971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WmShJpOz/GOmUnd0xKeTBcV3P2NCGM0BHpjZiSl8WN0=; b=orWT4O6yr70lud1A2//snxGcTUk4UgOPy2ziVEzcPxVMyItx3/1UqT0aXo5e5ZjMUrX+sC 5I7SvC68h51gtlH5fRDNXX5LqoBusmIeiZaE8ChOtvCoek04EVxFxFEj3XmfFytRbRuKU4 iHYhE1RyeBcE3hz1wO2kz8k0v1cCyNs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=CvBTLgcU; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.45 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725021971; a=rsa-sha256; cv=none; b=rZvLBLA7C4QGZ4GRKjw6/F7bKf+dKDxqWqkQhVy46XxsBtTqwRzSv0QhXCU4IjCpYhjdyx O8YQ8/ThttNR3ieSNqTo0gaCdBXxE0gtVyU0dxyLgTqYjpXtceuO8kbFcBCkYv4vu2c9lR v2btUN9clK15x+SbZi3m7iSi+FzGqVo= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6c35427935eso211326d6.3 for ; Fri, 30 Aug 2024 05:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1725022042; x=1725626842; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WmShJpOz/GOmUnd0xKeTBcV3P2NCGM0BHpjZiSl8WN0=; b=CvBTLgcUySOBQKlp1KfdUMER8pjkp16ynLNiKpinte+F4fsiGDRLsxQ81i+9Olih8g xB09G7LYd1VSFl8UIwQ32R7Haut9GzpO1yu/bJDaV5gYTF3RmtdJKCumokVKfvmzMdc+ KhOLEkgz+rYPiet/REUn8yn1VaO+RLgF9kYnys5xAgDgS6DLKUD+6QD/gMskImrJD9tz /Uqvd3mlGAgvceX0isQoRm+gwZv4vIUv37UeMc+ogpqkEsHn6gq3fnEHKtId34D5LlAI xHe+9lH9t/9B3Iz5mY8iRKymhdhpjJCi/x3tLqpfzNjyFauN1IjeOAtafWBeieN9/2KU oyIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725022042; x=1725626842; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WmShJpOz/GOmUnd0xKeTBcV3P2NCGM0BHpjZiSl8WN0=; b=jE/og0ZaQ7WjrDMOerDgDYRgfZoX3vxPumPa8mIrwrV5sIodWLNPp32/JEOo358GmA X1AK3sGTcW9SlsBdcqrLdoZmZop3AAjumotaKhvf3GTYpH8Loal0tnqQXI/rQC2tc1p3 32q6ygTlPrvxsbzKBTClg7hdx2O6l3YhAL8haPERpJubz1NBYW9QQH+HiHa7zyfu51H/ Nxbb6rAqg7XIZ+ugXesnEiLyECId033W57W0Z2JvFVW0vrIiZtj6CuRfZt17mzU0s2kC JZberKL3ADOl2vBKXbsY5LJplw2vAJgJfaHeng0VU5+rakmrBUs0F0a7wZe+78KlSxij HFZg== X-Forwarded-Encrypted: i=1; AJvYcCWgAjqiEWgDQp6E8Y+SQdri2cikZuyGIXLY7+wdmGX1sygEp47wvftdOOQd+57pOnLZ5IpuEHSVRA==@kvack.org X-Gm-Message-State: AOJu0YwCllZjbdraJCdyN4qRb7dAW581A31Bt6wTbKyzWf63/Qilx9To ofNFZt+HENG9r5+tZv8z8df+miGzjOM2EQ2Htv3bd69/go++PUsMnK8mBee0d6I= X-Google-Smtp-Source: AGHT+IF1zgT2NlSjbSBC4mUiCoFIEUsoyt95nAEze677a3G7gSdAzBNVY6enBBsIy8xyElYIQbGvzA== X-Received: by 2002:a05:6214:3c8b:b0:6c1:70c8:ead6 with SMTP id 6a1803df08f44-6c33e69695bmr78641056d6.50.1725022041738; Fri, 30 Aug 2024 05:47:21 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c34c04f512sm3869726d6.37.2024.08.30.05.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 05:47:21 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1sk128-00DlJD-Gs; Fri, 30 Aug 2024 09:47:20 -0300 Date: Fri, 30 Aug 2024 09:47:20 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: James Houghton , Andrew Morton , Paolo Bonzini , Ankit Agrawal , Axel Rasmussen , Catalin Marinas , David Matlack , David Rientjes , James Morse , Jonathan Corbet , Marc Zyngier , Oliver Upton , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Suzuki K Poulose , Wei Xu , Will Deacon , Yu Zhao , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 02/11] KVM: x86: Relax locking for kvm_test_age_gfn and kvm_age_gfn Message-ID: <20240830124720.GX3468552@ziepe.ca> References: <20240724011037.3671523-1-jthoughton@google.com> <20240724011037.3671523-3-jthoughton@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: xjfzxr1hxidbn6h8bt5w7qtp9bww9oxc X-Rspam-User: X-Rspamd-Queue-Id: CD74BA0008 X-Rspamd-Server: rspam02 X-HE-Tag: 1725022042-236633 X-HE-Meta: U2FsdGVkX19sF+Xh+M1Na3PBORwf3pj9EgIPqBEyIhxe7kV4yIcWQwnku6wFPtnTev8SLHqB85xGtNpYhm8ZmDN11drueWQ+tQFt2vXs3MCkRLjXFpApvAklB6nj1BmXbqHJ9CB6kaD4P8RI36DkIOkZXAiOk1s+5MD/LiXK9rcsCsiVXjeEQFGIARi0KhCai8PeK0sHlI+l7tZv66qDuKRXe4ZqSwZzKjUqhYZchBab4WPHu52HJoRuYyro+QFvlQlLTDS5BgN/qx5MFmnZqtRZLRmyw1Y2IAFpmpzsWqHYmTng8j3kR9X5QVDP7iw8T+uu02nf+b35/nG2kJ37re7HNE8DmXtpEe2DrEdDDpl7sBdkGGBh0fHxZeWHscx+fZzINE4OnPP6+CRCPklDCwOABap6j/meWWJp/7xDzvvBPRY6QsSKoWmx7cn4DLsL3ITMsqgklLrt3nLQUr4Nwpj3QMopcQ7xqVDV09BQYaED5Rn6JxrlsFzfP2PRyoPvRaTsIaDe8m+WQTaKQBTcKQ/x7hZSVLZdBZLajM9kqs9EkhTK9lowDILhCwCJ+DyFBOxk7OssMdq4vq9iWOkiaeKqDM7Xf1yb5JTt0OgcH7+aQM20U94D86eVZzKtmd14ycJmZMHmWKLKkPeqzh6rgx5F6EUKfPbvnLi2zzhb8GlAwRS/WMj6zgvnJZFMPI6sqBRa4JsZmL3ZLGXWeHPcfTV/26qgUiAFiD6XuQMUQPXYdGC6EvBqIz4+SlTLTPZVeulavrQrf4o9FS6MC6UTS3hCkUysTs36LsgVPNreuGOIeAIuFi/sTn/nVlsnU6fYhF6ShKSXkLptOrG0w1s4wiRbvw5ckZn6FdUaRovoFPWaIIxPWUlK/mB0dh83S97RIWC0SxktN3IcJuvwcJ7NazktT1bRHINy3W0Bci45yWfBDxy2Ku63pSxMylxRKVe+PP3X00UnelGA4QcMsf5 pKVUsaSX tpfcbvkV0+Vn1Wf4Yh0tj+YXg8WUG38rp8KxQaD4go5ZSPO3tC4K9Xh6cjf8mdIy8nMAVf16FSC0VdB20VIAchDio2qLSFo1iuXCAjEqz5HkEYSRmnZZ23HSJutnKvnp9/JIFEqd2hcoI3WOg9uYoZ0mIDHsbAd8WA7pU3Y9GOPUT2CD4lweK17qE6VBWBPABEurGZiNYPVusuutTnC7JWrzlV1g/0VJoKKAtqn+usr9l6QP+SOdEXRKRr/3UmEGFyimCA6y1l2KatXMMkgJyzJ1UzdFvo1zaPMVademuuZZLc3DmwRoAguTX/siGuk8JgkE5qOPsORwikqo+j124u8AmFNM29gz9bgO5SFHlRl7ReBU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 08:47:59PM -0700, Sean Christopherson wrote: > On Thu, Aug 29, 2024, James Houghton wrote: > > On Fri, Aug 16, 2024 at 6:05 PM Sean Christopherson wrote: > > > > +static __always_inline bool kvm_tdp_mmu_handle_gfn_lockless( > > > > + struct kvm *kvm, > > > > + struct kvm_gfn_range *range, > > > > + tdp_handler_t handler) > > > > > > Please burn all the Google3 from your brain, and code ;-) > > > > I indented this way to avoid going past the 80 character limit. I've > > adjusted it to be more like the other functions in this file. > > > > Perhaps I should put `static __always_inline bool` on its own line? > > Noooo. Do not wrap before the function name. Linus has a nice explanation/rant > on this[1]. IMHO, run clang-format on your stuff and just be happy with 99% of what it spits out. Saves *so much time* and usually arguing.. clang-format will occasionally decide to wrap in the GNU way, if it can put the arguments all on one line. People will never agree on small details of style, but it would be really nice if we can at least agree not to nitpick clang-format's decisions :) :) Jason