From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF798CA0EF7 for ; Fri, 30 Aug 2024 08:47:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70E126B00DA; Fri, 30 Aug 2024 04:47:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BDEE6B00DB; Fri, 30 Aug 2024 04:47:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D3426B00DC; Fri, 30 Aug 2024 04:47:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 400936B00DA for ; Fri, 30 Aug 2024 04:47:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AB26F140E34 for ; Fri, 30 Aug 2024 08:47:06 +0000 (UTC) X-FDA: 82508282052.20.ED480B7 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf09.hostedemail.com (Postfix) with ESMTP id C175A140012 for ; Fri, 30 Aug 2024 08:47:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KzCJ5+ne; spf=pass (imf09.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725007553; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZZYv0sqFZciH2gPE/Fa+Na9c7X9LlibN0yEt3RrBdYo=; b=1SjUyu/3I1hlBmqTepAqe/Bt8zQJSTsY3wugfQHzsttZJTlZ4YXvg1m3A/7SsM8/+yf/Pb ryRv0VbqU3OCB/7x5HPx3be4IFXF0f+jrqQf058CUZUKw2QPj4vt/O75riOXv/epIMvIAF jRdprJuRu0WbGCAmVtfYMX2zzYBDxfw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KzCJ5+ne; spf=pass (imf09.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725007553; a=rsa-sha256; cv=none; b=v0GNO4S2w3Js/xt68IvAuymzr+Oqt85+dJTgBdIorizIEC0XapW6h21YfSb7JD4IlY0i08 oY6vyjA5bS1p6vRXyWfAjU3mOkt1kDHqzeiJxBha1uRVDGuUHdXU4Ajrak4ndND5lpQAvj eN4V1IJ/+iygixpYsVj4Q7Ykyt5tqHM= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a8692bbec79so184137166b.3 for ; Fri, 30 Aug 2024 01:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725007623; x=1725612423; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZZYv0sqFZciH2gPE/Fa+Na9c7X9LlibN0yEt3RrBdYo=; b=KzCJ5+nekv+MkFHKCfNVsRVGSF6GbHBWdCotiz7N7QEzIgMZchlb8a8KMPZCLxoTT8 LYHj++oq2xCCZ6fDPPuqKb9Nt9Yl4a6IStdJjRJz0bjxHG8/1zyckwDWxiX7l1wkN19Z 3+CPTPRMd5qFJsAJDM9oL479zL6ncCd0qJnKNeUTdBN6yoXTkDsK6rD9PlCrgCBZyhoD 01YY8/Byf04AblmFh+G6anBChHUG0alxshpDeMocju4vjD1SEKdZr39nGMDstqnwnamo nasfTgMfw+THAw1XbgsXqowd89KWfQsTp6cHlgBT1iv9u3wd1znnWJBtKChZnzgwB5n1 GwMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725007623; x=1725612423; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZZYv0sqFZciH2gPE/Fa+Na9c7X9LlibN0yEt3RrBdYo=; b=oppvy5weris5qi+2eIKLhV5OAbugFCEl1DdwrZp1AVGM0fMxwVtsji/BCyUSbNnQwn Qc9Lm++0zwpVSND2u5/y/QTw2BReQWtviYMw8cy00h8XMZFGK1EEw6dRz3SB2p/6Pw4u i4kyuu4G20kSnvVjI9Qr0jhsTx07Sgkal7gXJY7ggruqHX83zv+Y8yutKrzRASpDfXPs 69Bg6mjVv1ur8flUtEfGpm4fw84ogGFGCT0f7/YshOp+8GPsPLTC9C4lF8l/KpDpUSPr dxZjG98jYWduoRI1xLBzdojgHyKU1QlPaw+S/+ppzHifhjmn7aJ6BDJMNfs3B+G6cVZ7 6KiA== X-Forwarded-Encrypted: i=1; AJvYcCXZJGjMVeiGOKe2eH0Jhk7BCwpaUwNL8mPr7Tz3e8AvxuKXtKMiht1DTkhytwRt3CooylZ5GrLwrg==@kvack.org X-Gm-Message-State: AOJu0YzEF/4y3lN9QpEbWkoO5/ylg1CuYQmOXPk2HYUU0GRptpmW3bBG x5PKGJ3rGSB5B+DNBpHH+uKTAJWK0lsvzmzRRtammfwrFddeECQx X-Google-Smtp-Source: AGHT+IHWrP+Z1Xf01YSvqEveCiS1QMbZTQQdhTyTfC2rrswTcQ/PIeH846y0B39yM5lY7xYad8GSnA== X-Received: by 2002:a17:907:1c94:b0:a7a:b643:654f with SMTP id a640c23a62f3a-a89a358274emr116645966b.15.1725007622756; Fri, 30 Aug 2024 01:47:02 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a898900f6e0sm188606366b.77.2024.08.30.01.47.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Aug 2024 01:47:02 -0700 (PDT) Date: Fri, 30 Aug 2024 08:47:01 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2] maple_tree: cleanup interface descriptions Message-ID: <20240830084701.7omry63kjgy2xsls@master> Reply-To: Wei Yang References: <20240830025648.22224-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: xw6ijuuq5qn5yjrhipwuwxtfzr1xj86c X-Rspam-User: X-Rspamd-Queue-Id: C175A140012 X-Rspamd-Server: rspam02 X-HE-Tag: 1725007624-805823 X-HE-Meta: U2FsdGVkX195uLaDmQ9x4SYZu1WgyeMGLb5qOvFK5VSdHXsvD0blb9m1EauSJvOSQqs6ndBQCEOsKoYCbkeQ2TyBTQH+2XmWnqQFcHbfcaBUgQZ6Y1pytZXVMYuxdz+3rCucKHX2l5mfI5XeeXyvFVICRD+zVmLcCM1EU3+cmHZtDJJ8mDCobaX/irh+RyL07HSntdjUmdx74qF5h/kD9jwt7zcLOATQD13+cRN5sevOZXawqWe/OrEcATrk2W3+dMtAXDQ/KLxGf0Inzkr0xNVhWEGh5XbYmWnuz0UjeC3JHjEVa1n4RGr1kVBrqd20Gvhjrxu4mtbeMsBC5vMl9Yv56k9E/mv4jV1gyfntTi8sRtQg51LfTsRVM7DQ1fbKPKyFT05jqg/rIzqQDMOE6JPUX3Z52codP8TqoxYxsRiDYw/gxups21oM5zs++ZNy77DiUELWbQlIMXys6j68C4Do7Jn7ZquoGswbH8BI7at4i+Lwx74vJE9E1/DQvplJ8NIGoxv1uac/ost/tIXWrfVPo3X52+SX5Mvi1tRt0HpgnrJeXgCauE+C7abSjxOyennVuSAxU0ApFRalNIuPa6Ss9ho7XgNZVjj8emk+j6JjMuJ0pk5TDcPU0uA5ZyTOXoieM1LFlI6MvOrOooaUc5cutivehRtXmuH2lkYBCGezQVeLi1L2kV6sOPxDDdZjdo9wmz3/ANQQSHIoBQEXmi8OVc7CNsDHPkGTPF5U+itcpYg0vYtpa98L8x1KO1sSd3iiZLJ2mt8m3DpjRSYGKLAtLo1CWttMeG2BkXHrtvlh8jca5C4staU4NkhJ37z74JQoh2JiCeqBbvVa402vtrbAM45iaSAFsy4YyRboZHgAHDpD1LFbq22JK/ePYWR7ZNQLCDXES4TWyayt6syL2QHNgw80oAkxwnaGiYiZiZJul9O6IFPeTkdTqSEOZ87nGgSThw6Bj76/XCf56XD QPVFMFvv 8uNeFV3Tlo4NCENnmttcpF7sHzG3zMxgswPlDGaQ6iSpFl2i6cdWqY5PkA4uu6K9xPXI+IBh6FHP8zG5m5kizqSQwq9qNUkySBwfGTEJxBE9ffpUaq3oCv5Jj+Y9BWDSqkDqMgtIQm5hqdubo9N8xbrrqbS54x9JNuFBhibrpm+/enrhhCX0hfnOA0DmGRn5Y55TD708NQ8JIfbliAe+BqzS4K6jdUy1t9md6y9Tu8u39Zy9EEVBmiiqaGJsIgsjPl4teO6Kw+yLVBoC5MNQHscehPjViBr/TNhhgJ9n1v/TD7xpBWoX92vb2q9h4P9yWQinNwZ8CLx36slSNirnDTECpt6xmSy18kVMAdHz/f0tSi/NshuMC4a1lU0taYF1ZRHRz5QKm2em2q43aT5XzD7ji/OGGPUnCvZw73LIj+h2iok5drIl7TmFGXHVQygZIGVMdiDcgvFg+v7/ZidSpa/QCZs7hVTS70X3d/dekDYmbrlAbZFrW6diPmV88b0FyKrpdH/zim4aEg1t2n1nto1XA2uUaEgsh/57faQ4INj3xEyC4gEXZDS5I4XM9gobHLmb2rtDwcMG+yC9qIARU/hyjmS8cbWQgv0fhPzzcvebRV1F30EThLNV85T0UpFNI3/hmX1rC0KJ2U155IV9jGwCiiP3mmek+XgTv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000238, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024 at 12:12:14AM -0400, Liam R. Howlett wrote: >* Wei Yang [240829 22:57]: >> This patch tries to cleanup some interface description: >> >> * function name mismatch >> * parameter name mismatch >> * parameter all end up with ':' >> * not prefix '*' if parameter is a pointer > >Why not use * if the parameter is a pointer? This tries to comply with kernel doc format. If you prefix a '*' in kenrel doc, ./scripts/kernel-doc would report a warning. > >> >> There is still some missing description of parameters, I didn't add them >> since I am not sure the exact meaning. >> >> Signed-off-by: Wei Yang >> --- >> v2: >> * not change them to kernel doc since they are internal interface > >Thanks, since they are not internal interfaces, could you also change >the patch description to state that? > Sorry for the un-precise change log. s/interface/function/ looks good? -- Wei Yang Help you, Help me