linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Wei Yang <richard.weiyang@gmail.com>,
	akpm@linux-foundation.org, maple-tree@lists.infradead.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v2] maple_tree: cleanup interface descriptions
Date: Fri, 30 Aug 2024 08:47:01 +0000	[thread overview]
Message-ID: <20240830084701.7omry63kjgy2xsls@master> (raw)
In-Reply-To: <u4c6uqyi6dunwcttwuxgch3yk5afuovkdwvftocmg2bz4xjyeq@34snnqgjzemk>

On Fri, Aug 30, 2024 at 12:12:14AM -0400, Liam R. Howlett wrote:
>* Wei Yang <richard.weiyang@gmail.com> [240829 22:57]:
>> This patch tries to cleanup some interface description:
>> 
>>   * function name mismatch
>>   * parameter name mismatch
>>   * parameter all end up with ':'
>>   * not prefix '*' if parameter is a pointer
>
>Why not use * if the parameter is a pointer?

This tries to comply with kernel doc format.

If you prefix a '*' in kenrel doc, ./scripts/kernel-doc would report a
warning.

>
>> 
>> There is still some missing description of parameters, I didn't add them
>> since I am not sure the exact meaning.
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> ---
>> v2:
>>   * not change them to kernel doc since they are internal interface
>
>Thanks, since they are not internal interfaces, could you also change
>the patch description to state that?
>

Sorry for the un-precise change log.

s/interface/function/ looks good?

-- 
Wei Yang
Help you, Help me


  parent reply	other threads:[~2024-08-30  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  2:56 Wei Yang
2024-08-30  4:12 ` Liam R. Howlett
2024-08-30  4:15   ` Liam R. Howlett
2024-08-30  8:47   ` Wei Yang [this message]
2024-08-30 13:30     ` Liam R. Howlett
2024-08-30 14:36       ` Wei Yang
2024-08-30 14:39         ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830084701.7omry63kjgy2xsls@master \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox