From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEA0C83F16 for ; Thu, 29 Aug 2024 15:58:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 086A76B007B; Thu, 29 Aug 2024 11:58:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00F0D6B0083; Thu, 29 Aug 2024 11:58:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3866B0088; Thu, 29 Aug 2024 11:58:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C37A86B007B for ; Thu, 29 Aug 2024 11:58:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6E8E416102A for ; Thu, 29 Aug 2024 15:58:41 +0000 (UTC) X-FDA: 82505740842.20.B516384 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 485F04000C for ; Thu, 29 Aug 2024 15:58:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Y0gfx6+Z; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724947099; a=rsa-sha256; cv=none; b=IptR4B0roLnpHSRZSyDT+UwT4i/2TJuGQzn3CV4gGnswomEDjsGlRt0IBYZJmeHQgzk9V0 rCPUP/QCWeO6pI/RVveRPVloE+6lZvy4AKuEr7Q67SXjC9ueNzDJzkY4ZTZu+5Eik2qbwl wK0vRXqZGrrFDV4vKsH1s2F8RqGdEhU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Y0gfx6+Z; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724947099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=peivlG6DATff813lbBsjO1GWRA37PjrlnLUSjaYzQeE=; b=XNNkKMY+40aRDABlqXp2oBLMaj0IE02lOhaq/ZjUlEV/Z1eoNfuT2aY7/eGQUDY+AnWq1R 4efHzco7RC7Ur4v8shIS7DboGep00OgKP+VPi9QodRKmx7HGGt0Jhzk69OeSJPnLQJgkUg dkhG3KsqcAuWTgMju0NuBHZsSgZ7dCE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DE39DCE1BF7; Thu, 29 Aug 2024 15:58:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45CD1C4CEC1; Thu, 29 Aug 2024 15:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724947114; bh=VVokIbso1eod+V2jCOqK7tDccyby/Y9yAysaTNvEBJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y0gfx6+ZPW2GXebkI4SsSSj8j1CQpGmLflFVcYuv9ZVGOi8CPFQaZPHZZd1p8xnuq vvznGLpJpZ2UyVuVOsZqQNJiF7wSKQwbCNIyucdlMygZXr4AuTJbNrWHfs9QFxhcLd QDaAwb0BR5MV/8FiE8oqGOzGFWddL4QsDzVW/As1qsFyjHaVFUTCTM1KoZ9045qdQW vhkNjyWySuo5bHJEaXUzl7ohgQplv7FgPStogTBUE7cOEVBWRIl6Ky6cEvVdMzcEjr ssqHU79Oa5Meqeca4xv505uJFusrVUfND84U5aJ7fsgyCrrCRaYB0x8ms/QSOF/YJD qonwe2j9cLFpw== From: Christian Brauner To: Vlastimil Babka Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, Jens Axboe , "Paul E. McKenney" , Roman Gushchin , Jann Horn , Linus Torvalds , Mike Rapoport , linux-mm@kvack.org Subject: Re: [PATCH v3 0/3] fs,mm: add kmem_cache_create_rcu() Date: Thu, 29 Aug 2024 17:58:05 +0200 Message-ID: <20240829-hautklinik-undurchdringlichen-2ce03f6e18da@brauner> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240828-work-kmem_cache-rcu-v3-0-5460bc1f09f6@kernel.org> References: <20240828-work-kmem_cache-rcu-v3-0-5460bc1f09f6@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1618; i=brauner@kernel.org; h=from:subject:message-id; bh=VVokIbso1eod+V2jCOqK7tDccyby/Y9yAysaTNvEBJo=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRdmLVQM3lW4l7l+8xC/64v4WXa2OV652Ejz5b5a1Wux Hp8ChHh6yhlYRDjYpAVU2RxaDcJl1vOU7HZKFMDZg4rE8gQBi5OAZiI4AlGhpvc/t5cviazXk5U vKsktEfV1vfmb1nxu2fmnp/2ceqd338YGX7WntrTUnF7/vbi27ErHUQyylKE7i5S+sL4teXFV4c DglwA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 485F04000C X-Rspamd-Server: rspam01 X-Stat-Signature: 856iz8rsimo4aybjz4ytxh3sbahi8way X-HE-Tag: 1724947118-384692 X-HE-Meta: U2FsdGVkX1+ScO+AXbYdZPCMo40QQBQngN8WQJ1/COKtiV0lzNPVMkl6Adlp79a1/PvP3GMCqkig7xqLNN7qGnQt9w8RutANgixffcBRRZpVJ8wUs/PHrMkftYEGogAR6S/b6Mijku56EIqqfpHCom6N2MDWmO0Q6BgJ7xdX+7cCF5jC2L9k5SG+64et2Y0P3UT2XiSiHqQnTGXrI6cIqvUWOPU2Oy7OcGcmNR9dOV3K2cFm0madK1scUpRHxqhnnApJ/SDZT1Gr5DV7gQ65nhv0Eu9LNgD9HQQ1oiQPps/ThhZnMlYz59sIsFXfZiyzAj6/IIxvn8LLWIIyycYHUrAvZ5Uy6b0rPYR5eM02AAUVtc9wjJdYVGo6y0Uc5unOJqit4l6nkj7Hp8GkmcYyjk/js1M+7rUJ4N3FpXJhTwhw9Sz+oPlkNCY2baJq5xXslJTta9khMPDBK8XL9AzWa+1/Bokg51MGI9aDXcs/Nqwpflre7Q0BWnNGRjdmOHvxYtPOEQTbnw6zlsXm0fpAe5w1tQ0SdztjnEgQCIdG0XK8/eRDA3ciCR1O/XJSD7F/2BDmeLAjWF9FXNxO9Mhnwg0cVkEzHfS2EyOhHNziwZUiTfB/ZwAx2TSUGHt5Q7evCS2m1xmrJPjH4ilY+Kd26xPT73Oe+4ZoWlFZZwQwn8bWPF8zmDUfn71F9rMhBjZJmytbxUYBUbAqd3N4kR2a/ZMZ8kB3JpThAr3JvghXaiLYWUHPoWdkJW9FUZzjb60fMqiE/VrdzlANuf/DHTjh1ojeA3D25AD6aKr1uIavn6MuyF2ntXvEqJq81DkCuJLzNcp6DcVtLbrwEtJOf4QaUu+4e9FVehj06PqtkB1K85d1KCE9QY5wqGFTOlOOo9efHI+Cl7kFbi71/G/fb1tCU5dWIKjrfY2uImqt13BKwsJ4QrMAMjiV9Lrw1v1fgw4oaw2PPSwCKt88SZQsI9v GW1KPZCF jaTDLR0BKL1JOUneIWuJYijC89PvpuLUwojFBXh2BuyUxB2MMVUqkciMVQqiW4Cu7XnV5XdB6FTq0v2uerKNFz6b08J8SehGw5hv0uS6zUSdq/CJLK08xh8uH8TUZCwj33hxrsTMVfAkdOLZaxejTDf+cUPZZGP+byIlrvKMJrcHTM9hJEXgg8fMv7M1cs4lni+N4yFcn673HIdkGLl7flplXfHnMFGC3oIc1dA6b76wO8pPLkEwpFtQRZDcU8de7S9gEW2ik0ADg5e2OJ+YEAUPX3HuAG0vXFtiYZ5Qxbm55VSuvXhzdiEthL6v/OMlrJ3ICS5affoLnbRprCswjsJEcZOkTYtU7kNC9sjN2it6PU6A/nBoRM7s8Ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Aug 2024 12:56:22 +0200, Christian Brauner wrote: > When a kmem cache is created with SLAB_TYPESAFE_BY_RCU the free pointer > must be located outside of the object because we don't know what part of > the memory can safely be overwritten as it may be needed to prevent > object recycling. > > That has the consequence that SLAB_TYPESAFE_BY_RCU may end up adding a > new cacheline. This is the case for .e.g, struct file. After having it > shrunk down by 40 bytes and having it fit in three cachelines we still > have SLAB_TYPESAFE_BY_RCU adding a fourth cacheline because it needs to > accomodate the free pointer and is hardware cacheline aligned. > > [...] Applied to the vfs.file branch of the vfs/vfs.git tree. Patches in the vfs.file branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.file [1/3] mm: remove unused root_cache argument https://git.kernel.org/vfs/vfs/c/a85ba9858175 [2/3] mm: add kmem_cache_create_rcu() https://git.kernel.org/vfs/vfs/c/ba8108d69e5b [3/3] fs: use kmem_cache_create_rcu() https://git.kernel.org/vfs/vfs/c/d1e381aa30cb