linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
	 Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Marc Zyngier <maz@kernel.org>,
	 Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	 Suzuki K Poulose <suzuki.poulose@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,  Oleg Nesterov <oleg@redhat.com>,
	Eric Biederman <ebiederm@xmission.com>,
	 Shuah Khan <shuah@kernel.org>,
	 "Rick P. Edgecombe" <rick.p.edgecombe@intel.com>,
	 Deepak Gupta <debug@rivosinc.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	 Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
	Kees Cook <kees@kernel.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Florian Weimer <fweimer@redhat.com>,
	Christian Brauner <brauner@kernel.org>,
	 Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
	 Ross Burton <ross.burton@arm.com>,
	 Yury Khrustalev <yury.khrustalev@arm.com>,
	 Wilco Dijkstra <wilco.dijkstra@arm.com>,
	 linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	 kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	 linux-arch@vger.kernel.org, linux-mm@kvack.org,
	 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-riscv@lists.infradead.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH v12 23/39] arm64/mm: Implement map_shadow_stack()
Date: Thu, 29 Aug 2024 00:27:39 +0100	[thread overview]
Message-ID: <20240829-arm64-gcs-v12-23-42fec947436a@kernel.org> (raw)
In-Reply-To: <20240829-arm64-gcs-v12-0-42fec947436a@kernel.org>

As discussed extensively in the changelog for the addition of this
syscall on x86 ("x86/shstk: Introduce map_shadow_stack syscall") the
existing mmap() and madvise() syscalls do not map entirely well onto the
security requirements for guarded control stacks since they lead to
windows where memory is allocated but not yet protected or stacks which
are not properly and safely initialised. Instead a new syscall
map_shadow_stack() has been defined which allocates and initialises a
shadow stack page.

Implement this for arm64.  Two flags are provided, allowing applications
to request that the stack be initialised with a valid cap token at the
top of the stack and optionally also an end of stack marker above that.
We support requesting an end of stack marker alone but since this is a
NULL pointer it is indistinguishable from not initialising anything by
itself.

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/mm/gcs.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/arch/arm64/mm/gcs.c b/arch/arm64/mm/gcs.c
index 979e02cece93..cdd4a9d7ff7d 100644
--- a/arch/arm64/mm/gcs.c
+++ b/arch/arm64/mm/gcs.c
@@ -68,6 +68,70 @@ unsigned long gcs_alloc_thread_stack(struct task_struct *tsk,
 	return addr;
 }
 
+SYSCALL_DEFINE3(map_shadow_stack, unsigned long, addr, unsigned long, size, unsigned int, flags)
+{
+	unsigned long alloc_size;
+	unsigned long __user *cap_ptr;
+	unsigned long cap_val;
+	int ret = 0;
+	int cap_offset;
+
+	if (!system_supports_gcs())
+		return -EOPNOTSUPP;
+
+	if (flags & ~(SHADOW_STACK_SET_TOKEN | SHADOW_STACK_SET_MARKER))
+		return -EINVAL;
+
+	if (!PAGE_ALIGNED(addr))
+		return -EINVAL;
+
+	if (size == 8 || !IS_ALIGNED(size, 8))
+		return -EINVAL;
+
+	/*
+	 * An overflow would result in attempting to write the restore token
+	 * to the wrong location. Not catastrophic, but just return the right
+	 * error code and block it.
+	 */
+	alloc_size = PAGE_ALIGN(size);
+	if (alloc_size < size)
+		return -EOVERFLOW;
+
+	addr = alloc_gcs(addr, alloc_size);
+	if (IS_ERR_VALUE(addr))
+		return addr;
+
+	/*
+	 * Put a cap token at the end of the allocated region so it
+	 * can be switched to.
+	 */
+	if (flags & SHADOW_STACK_SET_TOKEN) {
+		/* Leave an extra empty frame as a top of stack marker? */
+		if (flags & SHADOW_STACK_SET_MARKER)
+			cap_offset = 2;
+		else
+			cap_offset = 1;
+
+		cap_ptr = (unsigned long __user *)(addr + size -
+						   (cap_offset * sizeof(unsigned long)));
+		cap_val = GCS_CAP(cap_ptr);
+
+		put_user_gcs(cap_val, cap_ptr, &ret);
+		if (ret != 0) {
+			vm_munmap(addr, size);
+			return -EFAULT;
+		}
+
+		/*
+		 * Ensure the new cap is ordered before standard
+		 * memory accesses to the same location.
+		 */
+		gcsb_dsync();
+	}
+
+	return addr;
+}
+
 /*
  * Apply the GCS mode configured for the specified task to the
  * hardware.

-- 
2.39.2



  parent reply	other threads:[~2024-08-28 23:31 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 23:27 [PATCH v12 00/39] arm64/gcs: Provide support for GCS in userspace Mark Brown
2024-08-28 23:27 ` [PATCH v12 01/39] mm: Introduce ARCH_HAS_USER_SHADOW_STACK Mark Brown
2024-08-28 23:27 ` [PATCH v12 02/39] arm64/mm: Restructure arch_validate_flags() for extensibility Mark Brown
2024-08-28 23:27 ` [PATCH v12 03/39] prctl: arch-agnostic prctl for shadow stack Mark Brown
2024-09-03  8:55   ` [PATCH v12 3/39] " Yury Khrustalev
2024-08-28 23:27 ` [PATCH v12 04/39] mman: Add map_shadow_stack() flags Mark Brown
2024-09-03  8:57   ` [PATCH v12 4/39] " Yury Khrustalev
2024-08-28 23:27 ` [PATCH v12 05/39] arm64: Document boot requirements for Guarded Control Stacks Mark Brown
2024-08-28 23:27 ` [PATCH v12 06/39] arm64/gcs: Document the ABI " Mark Brown
2024-09-03  8:59   ` [PATCH v12 6/39] " Yury Khrustalev
2024-08-28 23:27 ` [PATCH v12 07/39] arm64/sysreg: Add definitions for architected GCS caps Mark Brown
2024-08-28 23:27 ` [PATCH v12 08/39] arm64/gcs: Add manual encodings of GCS instructions Mark Brown
2024-08-28 23:27 ` [PATCH v12 09/39] arm64/gcs: Provide put_user_gcs() Mark Brown
2024-08-28 23:27 ` [PATCH v12 10/39] arm64/gcs: Provide basic EL2 setup to allow GCS usage at EL0 and EL1 Mark Brown
2024-08-28 23:27 ` [PATCH v12 11/39] arm64/cpufeature: Runtime detection of Guarded Control Stack (GCS) Mark Brown
2024-08-28 23:27 ` [PATCH v12 12/39] arm64/mm: Allocate PIE slots for EL0 guarded control stack Mark Brown
2024-08-28 23:27 ` [PATCH v12 13/39] mm: Define VM_SHADOW_STACK for arm64 when we support GCS Mark Brown
2024-08-28 23:27 ` [PATCH v12 14/39] arm64/mm: Map pages for guarded control stack Mark Brown
2024-08-28 23:27 ` [PATCH v12 15/39] KVM: arm64: Manage GCS access and registers for guests Mark Brown
2024-09-03 16:24   ` Marc Zyngier
2024-08-28 23:27 ` [PATCH v12 16/39] arm64/idreg: Add overrride for GCS Mark Brown
2024-08-28 23:27 ` [PATCH v12 17/39] arm64/hwcap: Add hwcap " Mark Brown
2024-09-03  9:00   ` Yury Khrustalev
2024-08-28 23:27 ` [PATCH v12 18/39] arm64/traps: Handle GCS exceptions Mark Brown
2024-08-28 23:27 ` [PATCH v12 19/39] arm64/mm: Handle GCS data aborts Mark Brown
2024-09-02 18:54   ` Catalin Marinas
2024-08-28 23:27 ` [PATCH v12 20/39] arm64/gcs: Context switch GCS state for EL0 Mark Brown
2024-08-28 23:27 ` [PATCH v12 21/39] arm64/gcs: Ensure that new threads have a GCS Mark Brown
2024-09-03  9:04   ` Yury Khrustalev
2024-09-06 11:07   ` Szabolcs Nagy
2024-08-28 23:27 ` [PATCH v12 22/39] arm64/gcs: Implement shadow stack prctl() interface Mark Brown
2024-08-28 23:27 ` Mark Brown [this message]
2024-09-03  9:05   ` [PATCH v12 23/39] arm64/mm: Implement map_shadow_stack() Yury Khrustalev
2024-08-28 23:27 ` [PATCH v12 24/39] arm64/signal: Set up and restore the GCS context for signal handlers Mark Brown
2024-08-28 23:27 ` [PATCH v12 25/39] arm64/signal: Expose GCS state in signal frames Mark Brown
2024-09-02 18:55   ` Catalin Marinas
2024-09-03 12:13   ` Yury Khrustalev
2024-08-28 23:27 ` [PATCH v12 26/39] arm64/ptrace: Expose GCS via ptrace and core files Mark Brown
2024-09-02 18:56   ` Catalin Marinas
2024-09-02 18:58     ` Mark Brown
2024-09-03 16:38       ` Catalin Marinas
2024-08-28 23:27 ` [PATCH v12 27/39] arm64: Add Kconfig for Guarded Control Stack (GCS) Mark Brown
2024-08-28 23:27 ` [PATCH v12 28/39] kselftest/arm64: Verify the GCS hwcap Mark Brown
2024-08-28 23:27 ` [PATCH v12 29/39] kselftest/arm64: Add GCS as a detected feature in the signal tests Mark Brown
2024-08-28 23:27 ` [PATCH v12 30/39] kselftest/arm64: Add framework support for GCS to signal handling tests Mark Brown
2024-08-28 23:27 ` [PATCH v12 31/39] kselftest/arm64: Allow signals tests to specify an expected si_code Mark Brown
2024-08-28 23:27 ` [PATCH v12 32/39] kselftest/arm64: Always run signals tests with GCS enabled Mark Brown
2024-08-28 23:27 ` [PATCH v12 33/39] kselftest/arm64: Add very basic GCS test program Mark Brown
2024-08-28 23:27 ` [PATCH v12 34/39] kselftest/arm64: Add a GCS test program built with the system libc Mark Brown
2024-08-28 23:27 ` [PATCH v12 35/39] kselftest/arm64: Add test coverage for GCS mode locking Mark Brown
2024-08-28 23:27 ` [PATCH v12 36/39] kselftest/arm64: Add GCS signal tests Mark Brown
2024-08-28 23:27 ` [PATCH v12 37/39] kselftest/arm64: Add a GCS stress test Mark Brown
2024-08-28 23:27 ` [PATCH v12 38/39] kselftest/arm64: Enable GCS for the FP stress tests Mark Brown
2024-08-28 23:27 ` [PATCH v12 39/39] KVM: selftests: arm64: Add GCS registers to get-reg-list Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240829-arm64-gcs-v12-23-42fec947436a@kernel.org \
    --to=broonie@kernel.org \
    --cc=Szabolcs.Nagy@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=brauner@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=debug@rivosinc.com \
    --cc=ebiederm@xmission.com \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=james.morse@arm.com \
    --cc=kees@kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oleg@redhat.com \
    --cc=oliver.upton@linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=ross.burton@arm.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=thiago.bauermann@linaro.org \
    --cc=wilco.dijkstra@arm.com \
    --cc=will@kernel.org \
    --cc=yury.khrustalev@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox