From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 684D1C636F0 for ; Wed, 28 Aug 2024 18:54:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA57F6B0083; Wed, 28 Aug 2024 14:54:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E56346B0088; Wed, 28 Aug 2024 14:54:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF6836B0089; Wed, 28 Aug 2024 14:54:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B113A6B0083 for ; Wed, 28 Aug 2024 14:54:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A285A85BA for ; Wed, 28 Aug 2024 18:54:33 +0000 (UTC) X-FDA: 82502555226.15.CEBA49B Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf09.hostedemail.com (Postfix) with ESMTP id 0A54E14001F for ; Wed, 28 Aug 2024 18:54:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=BJjRIpZd; spf=pass (imf09.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724871201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ps9GxfPAYEKmArCYvi0Slcyk00VVGOSvePbyOgtbKyA=; b=eUCrybvBHAm+N8onTjgTnxBKKZBKVvFgzVNJBIKsFGkU42owLYAtwayXR2ZU0+hdkqYOY6 TXfuKysLgaH15ihDiQsZ/VcdRSwD7PhVxM++Ot879LtDcakseJ7lH75FOrFrPcEM/Amyco Zd/y8bdq98PYVCW7Q63zWdxIQK0/sOo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=BJjRIpZd; spf=pass (imf09.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724871201; a=rsa-sha256; cv=none; b=BuTTSMCLqyIm/XjqR3oX56nTasJZGjdNg88w1SUSIE7BNmxHK37nLjWT9ishvYuxl8VKpl S5sTcAGc0TKeLkWyXYQOl4s0y/h3Ri7MHC2WHEkirzveg4KrwK14DWRTVv5Q5sa28loxSB wjH7o67q0Lrsrr8BAA0hSEjA4Wv6Vgw= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20240828185427euoutp014f7b073ae8a16355ca726ce3e0d2e161~v_UdkA6la1527915279euoutp01c for ; Wed, 28 Aug 2024 18:54:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20240828185427euoutp014f7b073ae8a16355ca726ce3e0d2e161~v_UdkA6la1527915279euoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1724871267; bh=ps9GxfPAYEKmArCYvi0Slcyk00VVGOSvePbyOgtbKyA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=BJjRIpZd+f7kzDOlffKhzwXoagIBi/4DYlFDN/PhDy1NDJBtNBQ0sFlpY/A/KIcCl V5gEAW5T3eePFWsskg43qsfnz723D2q92Ud07ZfKAVIo1HwHQOteri1VDqNLqGySrh GbmFB4yP61fA/ijUoE2I4sC2M/eLAcCoS/AWLTyQ= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20240828185426eucas1p239740599d3d9c19514bce9c6db54760b~v_UdAJZ-p2500525005eucas1p2B; Wed, 28 Aug 2024 18:54:26 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id B8.D1.09624.2627FC66; Wed, 28 Aug 2024 19:54:26 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20240828185425eucas1p1d1a1c56773bae27481a5c65aede35638~v_UcAHdH60278902789eucas1p1N; Wed, 28 Aug 2024 18:54:25 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20240828185425eusmtrp1e91794f08be7570521c0dab23ed65a82~v_Ub-JGPb3027130271eusmtrp1E; Wed, 28 Aug 2024 18:54:25 +0000 (GMT) X-AuditID: cbfec7f2-c11ff70000002598-52-66cf7262a2ad Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id FB.84.08810.1627FC66; Wed, 28 Aug 2024 19:54:25 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240828185425eusmtip2b0ea0def328377cb8e7a99ba7395300e~v_Ub0lElP2240522405eusmtip2I; Wed, 28 Aug 2024 18:54:25 +0000 (GMT) Received: from localhost (106.110.32.87) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Aug 2024 19:54:24 +0100 Date: Wed, 28 Aug 2024 20:54:24 +0200 From: Daniel Gomez To: Jeff Xu CC: Andrew Morton , , Baolin Wang , Ryan Roberts , Subject: Re: build error at mm_unstable shmem.c: undefined reference to `vma_thp_gfp_mask') Message-ID: <20240828185424.tozywcsudn2xe7gj@AALNPWDAGOMEZ1.aal.scsc.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [106.110.32.87] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsWy7djP87pJRefTDK5OV7WYs34Nm8X/vccY LZ5+6mOxWPV7C7PFvTX/WS16dk9ldGDzWDNvDaPH7IaLLB4LNpV6bPo0id3jxIzfLB47H1oG sEVx2aSk5mSWpRbp2yVwZXT3HWEteMRWMf3FLJYGxhOsXYycHBICJhLT53xl72Lk4hASWMEo sfjqJiYI5wujROuk01CZz4wSS/YtZIFpebl2LytEYjmjxKb3s5ngqq62rYZq2cwoMeHdREaQ FhYBVYmuXzvBbDYBTYl9Jzexg9giAooSXw9cZgNpYBZYyyix6F8L2A5hgViJ5u3vwU7kFfCW OLxtFzOELShxcuYTsBpmAR2JBbs/ATVzANnSEsv/cYCEOQUCJR7PWgl1qqLEjIkwdq3EqS23 wC6VEHjAIXHx1HwmiISLxL3G4+wQtrDEq+NboGwZidOTe6Ca0yWWrJsFZRdI7Lk9ixVkr4SA tUTfmRyIsKNE8/PHUGE+iRtvBSGu5JOYtG06M0SYV6KjTQiiWk1i9b03LBMYlWch+WsWkr9m Ify1gJF5FaN4amlxbnpqsWFearlecWJucWleul5yfu4mRmCqOf3v+KcdjHNffdQ7xMjEwXiI UYKDWUmE98Txs2lCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeVVT5FOFBNITS1KzU1MLUotgskwc nFINTD6dvj/PaV3fW2DR+SAhXU635FzL8hW+Zj1/p0Sl7v7z0D32ZMLK8p+eXAzrF/2clbHD a2m925U/Pjl1E/qKnXO2Hahzr/3xmHfr9P75B4KKvERKv+mbifkWf2g2v9101phrz5RpvCXc dxhXqXTWPQ18Nfmg6MrIp8bnrSfPTDKZeIXTrDfKOSRt5s3K/kOnbhYflJy9Qntp3bFQqddd /JHJrCrVJyZryTzdyDXRw+pv7XkDued8jodvn1xkullh3zeGssOpWUG+h29v+XHg48FHj+Vf 7+VpTHGaoxnbtsHkSlHL3vTg7tZPchWh0XzpR8XXNfOVd1/bflzy8NpPkk8XzvNar5Ni+a5m VehzTSWW4oxEQy3mouJEAD5dNeSkAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t/xe7qJRefTDLoalSzmrF/DZvF/7zFG i6ef+lgsVv3ewmxxb81/Voue3VMZHdg81sxbw+gxu+Eii8eCTaUemz5NYvc4MeM3i8fOh5YB bFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6Gd19 R1gLHrFVTH8xi6WB8QRrFyMnh4SAicTLtXuBbC4OIYGljBI9W/4xQSRkJDZ+uQpVJCzx51oX G0TRR0aJ9esPQXVsZpQ4cPM/WBWLgKpE16+djCA2m4CmxL6Tm9hBbBEBRYmvBy6DdTMLrGWU eHJ4MQtIQlggVqJ5+3uwZl4Bb4nD23YxQ0xdwihxb9MnRoiEoMTJmU/AGpgFdCQW7P4ENIkD yJaWWP6PAyTMKRAo8XjWShaIUxUlZkyEsWslPv99xjiBUXgWkkmzkEyahTBpASPzKkaR1NLi 3PTcYkO94sTc4tK8dL3k/NxNjMCo23bs5+YdjPNefdQ7xMjEwXiIUYKDWUmE98Txs2lCvCmJ lVWpRfnxRaU5qcWHGE2BYTGRWUo0OR8Y93kl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp 2ampBalFMH1MHJxSDUwMx52eXS66p7ZvzYuHzU2Gx2bce+a3JbJms8UbMdEowS9JfX+drB+x haoKa/SYqad5GEoXfl+re0Xshe2nHy2nUlOPbv33Ue5Tq92/I+aLynNn3efa+W82h8jxQw+O 3XnaoLQsVjv02Jb7Jbd/PHdoCrK71sK8WGWr3LEfQkyxZ48sFX92rjvj2dr7C8/dC/RZbzXP sO4uu/yDLe0pYRUiMQXSP2r36RU/2vy0WtL6zsnvf2J0ZvYtCBPVfrvILNjvY9ELv8jVf/Mv +jPPM/owbQfPql0Cr6ruql3re9UcxHztUpW76d/vu6a697g8OJe7P4Y16diR69uu/WlibV+w xs+kSuibe/BfjmnhS0xVlViKMxINtZiLihMBGpw99UMDAAA= X-CMS-MailID: 20240828185425eucas1p1d1a1c56773bae27481a5c65aede35638 X-Msg-Generator: CA X-RootMTR: 20240828174816eucas1p219acb6d2665cc869ae403703e5aa9322 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240828174816eucas1p219acb6d2665cc869ae403703e5aa9322 References: X-Stat-Signature: srntcojie7rwyjxxbs5ogk5jbyhgndj8 X-Rspam-User: X-Rspamd-Queue-Id: 0A54E14001F X-Rspamd-Server: rspam02 X-HE-Tag: 1724871269-80413 X-HE-Meta: U2FsdGVkX18PBcf5cQVKflU//DeLm6A9qKyo++2Pwc3jTrw5JkMfnApGWL0nwtmqDpEhzHCskEGLOonKRyE6IcC8KYFyLmnqTMKRfTnlWmEMRylAIs9VZgamywBhmmTctgkZT7flcLTg+onRhkYFTRIlTulO8Jscp7PYZJceY2wp8gaZ+KokvYSvVC8/saEN53xvHXhZhuAi275hER6SWBSCacuCQq0sESdcmRIR4VjvFVeFoiWxeLq5zMeyvM0ysCLFmJ/Ylhhb5gfJcsGUJMUpG2X8prsuCneFzx3sYCVLK+AH4gfZLt1Ngr6AwtRuvaCNpSeKcsfoD0zV3GUkW5xTQ5lai8+pTgspvjs6qn2fD5Zi/kFnC7vBwtURlI/L/bbMmE5FVuj1dRzpnaR5cx1AbCO3/ijFotF93BqluI3x7L7qx+cPa3WHTU2Vv1/74RtdyjXfx2KotZc8/7kKfCuZb0SHe+5oxuv4mQx4FcjsH/6CrjTxezF0OfAcYjn2hvK6ofIT2FW+6aNsqvLyuBY1Rp/DHfxAco9nLC26QX/rwbR5APPRFE0RH3iZ2jsRobxZKE6LyPVHzZfk+4ZQ2+Y5sKOxiB6xx2dyQH6jfQGUGeO5Kgc3mHWRU6tS95HaADY7ohsAByGeKNDeF+zmyKNVU9yyGCQL1d1cIZ2W6LLNY8j+TuitHxDJlKntrAX/bWRZfbjCQMYkmIuJzf3qcilsz8lJGx1SYa43Qy8j1/xWFXMXzGwOuSH2/b07RR+4X6sFxVboDxbm56wuJxnvNNRvVqGvQ+VdeY4mVCrinSevEiQaCynq7lkDdp11g1l+B2yCVW5Nfn1fJp8pzZ9xsIU0MJIJDALoA/N8g/vHMTm1ImvpMdHIyIAdodoKvTydMRi+8N5oVK4YWGyu3ViVTQIm5ozD0qFWPZjn/aoapBcW30wOkqintEuDweHVg0avbVod4R5NMd82398ex3t 8tWjlJlA R7VUe8d2D7RxNoxqGEUQVFtmUUqnFB827c2nhEav0DBkJUxaxjpfVdYwUHt283IKJdcK0Aj9z+/KRTFUKGSN8vghPF4pipBXH6Eq8SrnARYV4drlFTazYJ5HnO5a8tYr4AKI6ZixfafDrHLoqOCS0nCI0pN87cijq9FLs9ZTvyi4E2RVAw1JUSFgCgh1+fYdbkoimpHQUN3DDURT5/+lT6pA1aFesN9aw8ctIDuXo9kKwNSLXGrfh+B8WFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 10:48:01AM -0700, Jeff Xu wrote: > Hi, > > When I enlist to mm_unstable branch, there is a build error: > > ld: vmlinux.o: in function `shmem_swapin_folio': > shmem.c:(.text+0x21b5d5): undefined reference to `vma_thp_gfp_mask' > make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1 > make[1]: *** [/usr/local/google/home/jeffxu/mm/Makefile:1156: vmlinux] Error 2 > make: *** [Makefile:224: __sub-make] Error 2 > > And it is fixed by adding CONFIG_TRANSPARENT_HUGEPAGE to .config > > Is there a recent change in shmem.c and adding this dependency ? > Maybe updating Kconfig or adding an ifdef ? This was reported by SeongJae Park already. And Baolin provided a hunk [1]. [1] https://lore.kernel.org/all/8c03467c-63b2-43b4-9851-222d4188725c@linux.alibaba.com/ Daniel > > Thanks > Best Regards > -Jeff