From: Daniel Gomez <da.gomez@samsung.com>
To: Jeff Xu <jeffxu@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Ryan Roberts <ryan.roberts@arm.com>, <linux-mm@kvack.org>
Subject: Re: build error at mm_unstable shmem.c: undefined reference to `vma_thp_gfp_mask')
Date: Wed, 28 Aug 2024 20:54:24 +0200 [thread overview]
Message-ID: <20240828185424.tozywcsudn2xe7gj@AALNPWDAGOMEZ1.aal.scsc.local> (raw)
In-Reply-To: <CABi2SkWmHaMbsJ7EXge7b4j_XpLCjWQfO6D2v0vY-PAoj5ePaA@mail.gmail.com>
On Wed, Aug 28, 2024 at 10:48:01AM -0700, Jeff Xu wrote:
> Hi,
>
> When I enlist to mm_unstable branch, there is a build error:
>
> ld: vmlinux.o: in function `shmem_swapin_folio':
> shmem.c:(.text+0x21b5d5): undefined reference to `vma_thp_gfp_mask'
> make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
> make[1]: *** [/usr/local/google/home/jeffxu/mm/Makefile:1156: vmlinux] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
>
> And it is fixed by adding CONFIG_TRANSPARENT_HUGEPAGE to .config
>
> Is there a recent change in shmem.c and adding this dependency ?
> Maybe updating Kconfig or adding an ifdef ?
This was reported by SeongJae Park already. And Baolin provided a hunk [1].
[1]
https://lore.kernel.org/all/8c03467c-63b2-43b4-9851-222d4188725c@linux.alibaba.com/
Daniel
>
> Thanks
> Best Regards
> -Jeff
prev parent reply other threads:[~2024-08-28 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240828174816eucas1p219acb6d2665cc869ae403703e5aa9322@eucas1p2.samsung.com>
2024-08-28 17:48 ` Jeff Xu
2024-08-28 18:54 ` Daniel Gomez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828185424.tozywcsudn2xe7gj@AALNPWDAGOMEZ1.aal.scsc.local \
--to=da.gomez@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hughd@google.com \
--cc=jeffxu@chromium.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox